Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()
milianw accepted this revision. milianw added a comment. This revision is now accepted and ready to land. agreed, lgtm but someone else must accept this upstream https://reviews.llvm.org/D18462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D5041: Fix for clang_Cursor_getSpellingNameRange() reportage of C++ functions
milianw added a comment. +1 from my side, but someone else has to approve. http://reviews.llvm.org/D5041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too
milianw accepted this revision. milianw added a reviewer: milianw. milianw added a comment. This revision is now accepted and ready to land. Still good from my side. @klimek, @rsmith: Could you please review this as well? Thanks http://reviews.llvm.org/D15729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D17820: Clang Code Completion Filtering
milianw added a comment. @akyrtzi raises a very valid point - I did not think about that. KDevelop uses the clang-c API and does fuzzy matching on top of the results, e.g. for camel-case matching. But, we currently always request code completion at a word start boundary so nothing would change for us. That said, I see how this patch could be seen as a breaking behavior change, and thus should probably only get enabled by an explicit option - if at all. Repository: rL LLVM http://reviews.llvm.org/D17820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D17820: Clang Code Completion Filtering
milianw added a subscriber: milianw. milianw added a comment. I'm not yet acquainted enough with the code at hand, but I wonder whether I'm understanding the code correctly: Could it be that you only filter before printing to the output stream? The other consumers, e.g. the one used by the clang-c API function clang_codeCompleteAt is thus not affected? That would be a shame, imo. This functionality should also be applied there, don't you think? Repository: rL LLVM http://reviews.llvm.org/D17820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D13388: Add support for querying the visibility of a cursor
milianw closed this revision. milianw added a comment. closing then, since this has been landed http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D15729: Load compiler plugins in ASTUnit, too
milianw added a subscriber: milianw. milianw added a comment. lgtm, but someone else should approve http://reviews.llvm.org/D15729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D13001: [libclang] Handle AutoType in clang_getTypeDeclaration
milianw added a comment. lgtm, but someone else should approve http://reviews.llvm.org/D13001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface
milianw accepted this revision. milianw added a comment. This revision is now accepted and ready to land. From my POV this is still fine. Manuel, Sergey - could you have a look at this please and push it upstream if you agree with me? Thanks http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D13388: Add support for querying the visibility of a cursor
milianw accepted this revision. milianw added a comment. This revision is now accepted and ready to land. From my POV, this looks good. http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D13000: [libclang] Expose AutoType
milianw added a comment. Looks good to me! http://reviews.llvm.org/D13000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface
milianw added a comment. This looks good to me, but it's missing a unit test. Take a look at http://reviews.llvm.org/D13388 for how to do that in principle. http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D13388: Add support for querying the visibility of a cursor
milianw added a comment. Yep, looks good to me as well - thanks! http://reviews.llvm.org/D13388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D13344: Keep the IfStmt node even if the condition is invalid
milianw added a comment. Is there still an error reported for the invalid condition? Anyhow, from my POV this is excellent and should fix a bunch of issues I've seen when using clang-c in KDevelop. I never got around to investigating it, but it always was related to conditionals. I'm pretty sure this patch fixes it then. @ogoffart: For Manuel to see the difference, could you share the before/after screenshots of your code browser? That makes the impact of this patch pretty clear. http://reviews.llvm.org/D13344 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Re: [PATCH] D12666: [LibClang] Fix clang_getCursorAvailability
milianw added a subscriber: milianw. milianw added a comment. Ping? Can someone please submit this upstream? http://reviews.llvm.org/D12666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
