[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2293146 , @MaskRay wrote: > In D81865#2293066 , @dblaikie wrote: > >> In D81865#2293059 , @MaskRay wrote: >> >>> @froydnj The committed

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

This revision was automatically updated to reflect the committed changes. Closed by commit rG31a3c5fb45b7: [clang] use string tables for static diagnostic descriptions (authored by froydnj). Changed prior to commit: https://reviews.llvm.org/D81865?vs=288628=294063#toc Repository: rG LLVM

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj requested review of this revision. froydnj added a comment. Throwing this back into the review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___ cfe-commits mailing list

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj updated this revision to Diff 288628. froydnj added a comment. Updated to use a struct instead of a union for the actual table in an effort to avoid UB. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 Files:

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. Ping for an opinion on the recent discussion of how to move forward with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. Ping for an opinion on the recent discussion of how to move forward with this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2176589 , @dblaikie wrote: > I believe this falls under the (using cppreference ( > https://en.cppreference.com/w/cpp/language/union ) , since it's a bit easier > to read) UB clause: " It's undefined behavior to read

[PATCH] D81865: [clang] Use string tables for static diagnostic descriptions

froydnj added a comment. In D81865#2176014 , @bkramer wrote: > Nice, those relocations have annoyed me for years. I'm worried about whether > the way you're accessing StaticDiagInfoDescriptionStringTable might be > undefined behavior. I won't block this

[PATCH] D81865: use string tables for static diagnostic descriptions

froydnj added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81865/new/ https://reviews.llvm.org/D81865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82388: move "basic" builtins to TableGen

froydnj added a comment. FWIW, an in-progress tree for the proposed move for all the architecture-specific builtins is: https://github.com/froydnj/llvm-project/tree/move-builtins-to-tablegen I don't know if the ARM/NEON/SVE builtins will be easily movable. It looks like they are separately

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

froydnj added a comment. Thanks for the review, @mstorsjo. Would you please land this for me? I don't have commit access. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57838/new/ https://reviews.llvm.org/D57838

[PATCH] D57838: [clang-cl] support /Oy- on aarch64

froydnj created this revision. froydnj added a reviewer: mstorsjo. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. MSVC supports /Oy- on aarch64, so clang-cl should too. Repository: rC Clang https://reviews.llvm.org/D57838 Files: