neil.hickey added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:414
else
-llvm_unreachable("Unsupported OpenCL C++ version");
+llvm_unreachable("Unsupported C++ version for OpenCL");
Builder.defineMacro("__CL_CPP_VERSION_1_0__", "100
This revision was automatically updated to reflect the committed changes.
Closed by commit rL366212: [OpenCL] Fixing sampler initialisations for C++
mode. (authored by neil.hickey, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
ht
neil.hickey created this revision.
neil.hickey added a reviewer: Anastasia.
Herald added a subscriber: yaxunl.
Sampler initialization from integer literal was broken in C++ mode for OpenCL.
Fixing to allow functions that take a sampler to take an integer and for
samplers to be initialized to int
neil.hickey added inline comments.
Comment at: docs/LanguageExtensions.rst:1538
+- ``dynamic_cast`` operator
+- Only placement ``new``/``delete`` operators
+- Standard C++ libraries. Currently there is no solution for alternative
This seems weird, you say the fol
neil.hickey accepted this revision.
neil.hickey added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59219/new/
https://reviews.llvm.org/D59219
___
cfe-commits mailing list
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL289544: Improve handling of floating point literals in
OpenCL to only use double… (authored by neil.hickey).
Changed prior to commit:
https://reviews.llvm.org/D24235?vs=77975&id=81235#toc
Repository:
