[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

2019-06-25 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas marked an inline comment as done. nicolas added inline comments. Comment at: clang/include/clang/AST/Decl.h:2331 + /// Attempt to compute an informative source range covering the + /// function parameters. This omits the ellipsis of a variadic function. + SourceRange

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

2019-06-25 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas updated this revision to Diff 206446. nicolas added a comment. - Added tests of instance and static functions - Added tests of parameters with cv qualifiers - Added tests of parameters with attributes - Removed `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

2019-06-21 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

2019-06-13 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas created this revision. nicolas added reviewers: rsmith, steveire. Herald added a project: clang. Herald added a subscriber: cfe-commits. This source range covers the list of parameters of the function declaration. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D63276

[PATCH] D60029: Add const children() accessors to all AST nodes.

2019-04-12 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas added a comment. Yes, thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60029: Add const children() accessors to all AST nodes.

2019-04-10 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60029/new/ https://reviews.llvm.org/D60029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D60029: Add const children() accessors to all AST nodes.

2019-04-02 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas updated this revision to Diff 193288. nicolas retitled this revision from "Add const children() accessors to Stmts" to "Add const children() accessors to all AST nodes.". nicolas edited the summary of this revision. nicolas added a comment. Added children() const to all AST nodes.

[PATCH] D60128: Add const children accessors to all nodes.

2019-04-02 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add const children accessors to all AST nodes where non const accessors exist. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60128 Files: clang/include/clang/AST/Expr.h

[PATCH] D60029: Add const children() accessors to Stmts

2019-03-30 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas added a comment. In D60029#1448938 , @riccibruno wrote: > Did you go over all the statements on `Stmt.h` systematically ? Yes. > You could also do the same thing for all of the statements/expressions in > `StmtCXX.h`, `Expr.h`, `ExprCXX.h`,

[PATCH] D60029: Add const children() accessors to Stmts

2019-03-30 Thread Nicolas Manichon via Phabricator via cfe-commits
nicolas created this revision. nicolas added reviewers: bkramer, rsmith. nicolas added a project: clang. Herald added a subscriber: cfe-commits. Exprs already have children() const but not Stmts. All the changes are very simple, except for `DeclStmt` where I used a `const_cast`. Repository: