[PATCH] D152818: [Clang] Make template instantiations respect pragma FENV_ACCESS state at point-of-definition

2023-06-28 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn added a comment. In D152818#4442116 , @rjmccall wrote: > Does https://reviews.llvm.org/D143241 solve the original problem here, or is > there something deeper? It does not solve the problem, at least for my test case (linked in

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

2023-06-14 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn added a comment. I've opened an issue (https://github.com/llvm/llvm-project/issues/63063) where we hit the same assertion. There's a smaller test case, and we've done enough investigation that we understand the problem. I'd be happy to discuss over on the issue as well.

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

2023-01-23 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn marked an inline comment as done. nicolerabjohn added inline comments. Comment at: clang/test/SemaCXX/class-layout.cpp:688 }; #if defined(CLANG_ABI_COMPAT) && CLANG_ABI_COMPAT <= 15 _Static_assert(sizeof(t3) == 8, ""); hubert.reinterpretcast

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

2023-01-23 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn updated this revision to Diff 491595. nicolerabjohn added a comment. Update to assertions for z/OS case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

2023-01-23 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn updated this revision to Diff 491505. nicolerabjohn added a comment. Reverting previous directive change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

2023-01-23 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn updated this revision to Diff 491501. nicolerabjohn added a comment. Addressing review comments - spacing, updates to run lines, updates to a directive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files:

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

2023-01-23 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn updated this revision to Diff 491477. nicolerabjohn added a comment. Opting out of clang ABI change in FieldPacked bool on AIX. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

2023-01-23 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn updated this revision to Diff 491431. nicolerabjohn added a comment. Adding run lines for AIX & z/OS, and updating comment line length. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

2023-01-23 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn updated this revision to Diff 491375. nicolerabjohn added a comment. Updating comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142358/new/ https://reviews.llvm.org/D142358 Files: clang/docs/ReleaseNotes.rst clang/lib/Basic/Targets/OSTargets.h

[PATCH] D142358: Opting out of Clang 15 ABI Changes for AIX and z/OS

2023-01-23 Thread Nicole Rabjohn via Phabricator via cfe-commits
nicolerabjohn created this revision. nicolerabjohn added reviewers: hubert.reinterpretcast, cebowleratibm, daltenty, dblaikie. Herald added a project: All. nicolerabjohn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is already a