[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

2019-05-08 Thread Nolan O'Brien via Phabricator via cfe-commits
NSProgrammer added a comment. In D17741#1413864 , @kristina wrote: > If the author is still missing at the end of next week, any objections to me > resubmitting a similar patch that just implements `__FILE_NAME__` or > `__BASE_NAME__` (Need a few more

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

2019-02-22 Thread Nolan O'Brien via Phabricator via cfe-commits
NSProgrammer added a comment. We would prefer a macro like `__FILE_NAME__` over a build flag for code reading consistency (they would clearly do different things vs varying based on an obscure flag being present/absent). This patch is languishing, unless the original author thinks otherwise, a

[PATCH] D17741: adds __FILE_BASENAME__ builtin macro

2019-01-03 Thread Nolan O'Brien via Phabricator via cfe-commits
NSProgrammer added a comment. To throw in my 2 cents. I don’t really have a preference between a compiler flag vs a different macro that’s just for the file name sans path prefix. But I have a real need for this to get into clang: with 1.2 million lines of code, the regular placement of log