[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. > Looks like this is causing a crash on current main: > https://github.com/llvm/llvm-project/issues/62838 That was fixed in D151326 . I think we should be okay to re-enable this now. The first assertion was a bit of an edge case; I

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4375881 , @hctim wrote: > Hey, found another error that occurs when building Android that looks to be > different from @maskray's revert. > ... Thanks for the report and the tiny reproducer! I've written D151795

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. That should be fixed with D149959 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-commits

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thanks for the reproducer and report! I'll have a patch up for this shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Great, thanks @paulkirth! I've just landed this again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-commits mailing list

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4299081 , @paulkirth wrote: > @jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI > that reverted the change that disabled this as default and tried it for x86. > It looks like this patch is

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thanks everyone for your reports and help, it's really appreciated. In D146987#4286318 , @dmgreen wrote: > Hello, I also noticed this potentially causing problems for scalable vectors: > https://godbolt.org/z/qdr8P86aW > That

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4281825 , @paulkirth wrote: > Here are reduced cases. I didn't bother bisecting flags, but the test case is > quite small > F27199288: clang-crashreports.zip > > struct a {}; >

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. > I think we may have an issue due to this. I'm basing that on the blamelist, > but I'm still bisecting our build, which may take some time to confirm. Can > you take a look, and revert if it's not a quick fix? That looks related to assignment tracking to me. I'm

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thanks everyone for begin patient with this one. I've just pushed again after landing D148536 . I am hoping that's the last issue... I am watching the buildbots and chromium build page. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4264491 , @jmorse wrote: > ... > H, that feels like a legitimate IR input where the configuration of > debug-info / intrinsics is just unexpected -- we probably shouldn't assert in > that situation but gracefully

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4263263 , @rupprecht wrote: > In D146987#4263048 , @MaskRay wrote: > >> The latest reland 3820e9a2b29a2e268319ed6635da0d59e18d736d >>

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4263139 , @aeubanks wrote: > I'm seeing > > llc: ../../llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6214: void > llvm::SelectionDAGBuilder::visitIntrinsicCall(const CallInst &, unsigned > int): Assertion

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thank you for the reports and revert, I will dig into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-commits mailing list

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. In D146987#4237124 , @haowei wrote: > This patch (which enables assignment tracking) and D147312 > breaks llvm runtime build for > `runtimes-armv7-unknown-linux-gnueabihf` > > ... > > Example

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Thank you @uabelho for the reproducer- I've added a fix in D147435 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Hi @haowei, thanks for the report and revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-commits mailing list

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. > The expected compile-time regression on ReleaseLTO-g is roughly 1.2% right, > in exchange for greater variable location coverage? The compile time tracker is currently reporting around 1.5% for an LTO build. However, it's disabled for LTO at the moment until that can

[PATCH] D146987: [Assignment Tracking] Enable by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa32490bfe0b: [Assignment Tracking] Enable by default (authored by Orlando). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D146615: [Assignment Tracking] Give -fexperimental-assignment-tracking flag 3 options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41c92c0dc679: [Assignment Tracking] Give -fexperimental-assignment-tracking flag 3 options (authored by Orlando). Herald added a project: clang.

[PATCH] D142029: [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a996c82a75f: [Assignment Tracking] Fix -fexperimental-assignment-tracking cc1 flag (authored by Orlando). Herald added a project: clang. Herald

[PATCH] D142027: [Assignment Tracking][NFC] Replace LLVM command line option with a new module flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Orlando marked an inline comment as done. Closed by commit rG4ece50737d53: [Assignment Tracking][NFC] Replace LLVM command line option with a module flag (authored by

[PATCH] D132226: [Assignment Tracking][7/*] Add assignment tracking functionality to clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28f9636edd7d: [Assignment Tracking][7/*] Add assignment tracking functionality to clang (authored by Orlando). Herald added a project: clang. Herald

[PATCH] D132221: [Assignment Tracking][2/*] Add flags to enable Assignment Tracking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Orlando marked an inline comment as done. Closed by commit rGc10a8473f48b: [Assignment Tracking][2/*] Add flags to enable Assignment Tracking (authored by Orlando).

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

Orlando added subscribers: probinson, Orlando. Orlando added a comment. When constructing the compiler command line (here in Clang.cpp ) there's a special case for SCE

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

Orlando added a comment. Hi @yln, the test you added `llvm/test/Transforms/LowerGlobalDestructors/lower-global-dtors.ll` is failing on some bots, e.g. https://lab.llvm.org/buildbot/#/builders/139/builds/18527 (builder `llvm-clang-x86_64-sie-ubuntu-fast`). Please can you take a look?

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

Orlando added a comment. In D120464#3363274 , @jansvoboda11 wrote: > In D120464#3363258 , @Orlando wrote: > >> Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this >> commit on the

[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

Orlando added a comment. Hi, the test `add-remove-irrelevant-module-map.m` starts failing with this commit on the `llvm-clang-x86_64-sie-win` builder: https://lab.llvm.org/buildbot/#/builders/216/builds/929. Please can you take a look when you get the chance? Repository: rG LLVM Github

[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

Orlando added a comment. Driver flag change seems ok but would appreciate another pair of eyes checking it makes sense. Everything else (test change omissions, new test, default flag settings) LGTM. Comment at: llvm/lib/Target/X86/X86TargetMachine.cpp:29 #include

[PATCH] D110783: [clang] Make crash reproducer work with clang-cl

Orlando added a comment. In D110783#3036403 , @thakis wrote: >> Hopefully better after ec4a82286674c44c9216e9585235b0fa5df4ae9f >> > > Your bot cycled green after that change: >

[PATCH] D72427: [DebugInfo] Add option to clang to limit debug info that is emitted for classes.

Orlando added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2225 + !CXXDecl->isLambda() && !isClassOrMethodDLLImport(CXXDecl)) { +for (const auto *ctor : CXXDecl->ctors()) { + if (ctor->isUserProvided()) Nit: Should `ctor` be