[PATCH] D51855: [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array

2018-10-04 Thread Petr Pavlu via Phabricator via cfe-commits
petpav01 added a comment. No worries, thanks. https://reviews.llvm.org/D51855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51855: [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array

2018-09-19 Thread Petr Pavlu via Phabricator via cfe-commits
petpav01 updated this revision to Diff 166073. petpav01 added a comment. Thanks for having a look at this patch. Updated version addresses the review comments. https://reviews.llvm.org/D51855 Files: include/clang/Basic/DiagnosticASTKinds.td lib/AST/ExprConstant.cpp

[PATCH] D51855: [constexpr] Fix ICE when memcpy() is given a pointer to an incomplete array

2018-09-10 Thread Petr Pavlu via Phabricator via cfe-commits
petpav01 created this revision. petpav01 added a reviewer: rsmith. Herald added a reviewer: javed.absar. Herald added subscribers: cfe-commits, kristof.beyls. Trying to compile the following example results in a clang crash: $ cat char.c void *memcpy(void *, const void *, unsigned int);

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

2018-07-04 Thread Petr Pavlu via Phabricator via cfe-commits
petpav01 added inline comments. Comment at: test/CodeGen/clang-sections-attribute.c:1 +// RUN: %clang_cc1 -emit-llvm -triple arm-none-eabi -o - %s | FileCheck %s + chill wrote: > Isn't it possible for the test to fail if the Arm target is not configured? I think

[PATCH] D48916: Fix setting of empty implicit-section-name attribute for functions affected by '#pragma clang section'

2018-07-04 Thread Petr Pavlu via Phabricator via cfe-commits
petpav01 created this revision. petpav01 added reviewers: javed.absar, chill, rnk. Herald added subscribers: cfe-commits, kristof.beyls. Code in `CodeGenModule::SetFunctionAttributes()` can set an empty attribute `implicit-section-name` on a function that is affected by `#pragma clang

[PATCH] D45807: [libclang] Fix test LibclangReparseTest.FileName when TMPDIR is set to a symbolic link

2018-04-19 Thread Petr Pavlu via Phabricator via cfe-commits
petpav01 created this revision. petpav01 added reviewers: MaskRay, jbcoe. Herald added a subscriber: cfe-commits. Commit r329515 recently added new test `LibclangReparseTest.FileName`. This test fails in an environment which has

[PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

2017-01-29 Thread Petr Pavlu via Phabricator via cfe-commits
petpav01 updated this revision to Diff 86217. petpav01 added a comment. Patch rebased. https://reviews.llvm.org/D13289 Files: include/valarray test/std/numerics/numarray/valarray.nonmembers/valarray.transcend/abs_valarray.pass.cpp