phst added a comment.
Thanks for the review! I think you also need to land it (I don't seem to have
the necessary permissions).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148918/new/
https://reviews.llvm.org/D148918
phst updated this revision to Diff 515697.
phst added a comment.
Check for a ‘buffer’ type instead of ‘buffer-live’.
In Emacs 29, ‘buffer-live’ is no longer recognized as a type and generates a
compilation warning. Every function that requires a live buffer already checks
whether the buffer is
phst updated this revision to Diff 515695.
phst added a comment.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
- Check for a ‘buffer’ type instead of ‘buffer-live’.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
phst added a comment.
I'm not super familiar with the process either, but IIRC @sammccall or @djasper
have to merge this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143560/new/
https://reviews.llvm.org/D143560
___
cfe-commits mailing
phst requested changes to this revision.
phst added inline comments.
This revision now requires changes to proceed.
Comment at: clang/tools/clang-format/clang-format.el:70
(cl-case (xml-node-name node)
-('replacement
+((replacement quote)
phst added a comment.
Thanks for the review! I think you have to commit this (I don't have commit
access).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120408/new/
https://reviews.llvm.org/D120408
___
phst created this revision.
phst added a reviewer: sammccall.
phst requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
In an indirect buffer, buffer-file-name is nil, so check the base buffer
instead. This works fine in direct buffers where
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE349150: clang-include-fixer.el: support remote files
(authored by phst, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54672?vs=174522=178227#toc
Repository:
rCTE Clang Tools
phst created this revision.
phst added a reviewer: klimek.
Herald added a subscriber: cfe-commits.
Support remote files (e.g., Tramp) in the Emacs integration for
clang-include-fixer
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54672
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329566: Improve completion experience for headers (authored
by phst, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43969
Files:
phst updated this revision to Diff 136598.
phst added a comment.
Fix condition
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43969
Files:
include-fixer/tool/clang-include-fixer.el
Index: include-fixer/tool/clang-include-fixer.el
phst updated this revision to Diff 136597.
phst added a comment.
Revert bogus additions
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43969
Files:
include-fixer/tool/clang-include-fixer.el
Index: include-fixer/tool/clang-include-fixer.el
phst created this revision.
phst added a reviewer: klimek.
Herald added a subscriber: cfe-commits.
When calling `completing-read', we should provide a default to prevent the
behavior described in
This revision was automatically updated to reflect the committed changes.
Closed by commit rC319621: Fix assume-filename handling in clang-format.el
(authored by phst).
Changed prior to commit:
https://reviews.llvm.org/D37903?vs=124242=125274#toc
Repository:
rC Clang
phi added a comment.
The patch doesn't apply any more to upstream head:
$ arc patch D37903
patching file tools/clang-format/clang-format.el
Hunk #1 FAILED at 122.
Hunk #2 FAILED at 193.
Could you please rebase it?
https://reviews.llvm.org/D37903
phi added a comment.
Hi, do you need anything more from us? This patch looks fine and can be
submitted.
https://reviews.llvm.org/D37903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
phst accepted this revision.
phst added inline comments.
Comment at: tools/clang-format/clang-format.el:126
+no active region. If no style is given uses `clang-format-style'. Use
+ASSUME-FILE-NAME to locate a style config file, if no assume-file-name is
given
+uses the
phst added inline comments.
Comment at: tools/clang-format/clang-format.el:122
;;;###autoload
-(defun clang-format-region (start end style assume-file-name)
- "Use clang-format to format the code between START and END according to STYLE
-using ASSUME-FILE-NAME to locate a
phst added inline comments.
Comment at: tools/clang-format/clang-format.el:123
+(defun clang-format-region (start end style assume-file-name)
+ "Use clang-format to format the code between START and END according to STYLE
+using ASSUME-FILE-NAME to locate a style config file.
phst accepted this revision.
phst added a comment.
This revision is now accepted and ready to land.
Your use case sounds good to me. Please be sure to document the new parameter,
though.
Comment at: tools/clang-format/clang-format.el:154
+
phst added inline comments.
Comment at: tools/clang-format/clang-format.el:125
If called interactively uses the region or the current statement if there
is no active region. If no style is given uses `clang-format-style'."
(interactive
Please document the
phst added a comment.
Thanks, generally looks good, but a couple of notes:
- This is actually a bug in clang-format, which can easily be triggered with
`clang-format -output-replacements-xml -assume-filename '' -offset 0 -length 10
-cursor 5 <<< ' = 1234;'`
It's fine to work around
22 matches
Mail list logo
