[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

2019-08-08 Thread Pierre GONDOIS via Phabricator via cfe-commits
Pierre added a comment. Just one comment, Thank you again for making everything clearer :) Comment at: clang/lib/Sema/OpenCLBuiltins.td:116 +// combination of Types and vector sizes. +// +// E.g.: If TypeListField = and VectorList = <1, 2, 4>, then Maybe it

[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

2019-07-12 Thread Pierre GONDOIS via Phabricator via cfe-commits
Pierre added a comment. Hello Tom, Thank you for adding me, the changes seem correct to me. There is a new version of the tablegen builtin functions that makes these tables static/const. It still needs some work, so I thing it's relevant to make this change in the meantime :

[PATCH] D64321: [OpenCL] Change diagnostic for function declaration

2019-07-08 Thread Pierre GONDOIS via Phabricator via cfe-commits
Pierre created this revision. Pierre added reviewers: Anastasia, svenvh. Pierre added projects: clang, LLVM. Herald added a subscriber: cfe-commits. When declaring functions only differing by their return type, diagnostic was indicating "conflicting types for" the function. Similarly to c++, it

[PATCH] D64320: [OpenCL] Print builtin function prototypes if ambiguous

2019-07-08 Thread Pierre GONDOIS via Phabricator via cfe-commits
Pierre created this revision. Pierre added reviewers: Anastasia, svenvh. Pierre added projects: clang, LLVM. Herald added subscribers: cfe-commits, kristina. When hitting an ambigous call to a builtin function with the -fdeclare-opencl-builtins option, diagnostics don't print the prototypes that

[PATCH] D64319: [OpenCL] Add function attributes handling for builtin functions

2019-07-08 Thread Pierre GONDOIS via Phabricator via cfe-commits
Pierre created this revision. Pierre added reviewers: Anastasia, svenvh. Pierre added projects: clang, LLVM. Herald added subscribers: cfe-commits, kristina. Add handling to for the "overload, "pure", "constant" and "convergent" function attributes for OpenCL builtin functions. Repository: