[clang] 7fe4757 - Set HOME for tests that use module cache path

Author: Colin Cross Date: 2022-09-15T23:58:57Z New Revision: 7fe475756b26080fe0bb02e8e317662ccc9a01f1 URL: https://github.com/llvm/llvm-project/commit/7fe475756b26080fe0bb02e8e317662ccc9a01f1 DIFF: https://github.com/llvm/llvm-project/commit/7fe475756b26080fe0bb02e8e317662ccc9a01f1.diff LOG:

[clang] f5b3879 - Revert "[CodeGen] Mark fma as const for Android"

Author: Alex Xu (Hello71) Date: 2022-01-10T11:31:09-08:00 New Revision: f5b387988bd4885a973f35deaf3881524f526e3f URL: https://github.com/llvm/llvm-project/commit/f5b387988bd4885a973f35deaf3881524f526e3f DIFF:

[clang] 0fd0a01 - [git-clang-format] Do not apply clang-format to symlinks

Author: Pirama Arumuga Nainar Date: 2021-05-11T10:34:40-07:00 New Revision: 0fd0a010a1ed2ce761d20bfc6378e5bbaa75c8de URL: https://github.com/llvm/llvm-project/commit/0fd0a010a1ed2ce761d20bfc6378e5bbaa75c8de DIFF:

Re: r371437 - [Driver] Add -static-openmp driver option

On Mon, Sep 9, 2019 at 1:03 PM Joerg Sonnenberger wrote: > On Mon, Sep 09, 2019 at 06:31:41PM -0000, Pirama Arumuga Nainar via > cfe-commits wrote: > > Author: pirama > > Date: Mon Sep 9 11:31:41 2019 > > New Revision: 371437 > > > > URL: http://llvm.org

r371444 - [Driver] Handle default case in refactored addOpenMPRuntime

Author: pirama Date: Mon Sep 9 12:52:39 2019 New Revision: 371444 URL: http://llvm.org/viewvc/llvm-project?rev=371444=rev Log: [Driver] Handle default case in refactored addOpenMPRuntime Summary: Appease failed builds (due to -Werror and -Wswitch) where OMPRT_Unknown is not handled in the

r371437 - [Driver] Add -static-openmp driver option

Author: pirama Date: Mon Sep 9 11:31:41 2019 New Revision: 371437 URL: http://llvm.org/viewvc/llvm-project?rev=371437=rev Log: [Driver] Add -static-openmp driver option Summary: For Gnu, FreeBSD and NetBSD, this option forces linking with the static OpenMP host runtime (similar to

r340424 - [Android] Default to -fno-math-errno

Author: pirama Date: Wed Aug 22 10:43:05 2018 New Revision: 340424 URL: http://llvm.org/viewvc/llvm-project?rev=340424=rev Log: [Android] Default to -fno-math-errno Summary: Android's libm does not set errno. Reviewers: srhines, enh Subscribers: cfe-commits Differential Revision:

r339284 - [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL

Author: pirama Date: Wed Aug 8 13:38:38 2018 New Revision: 339284 URL: http://llvm.org/viewvc/llvm-project?rev=339284=rev Log: [Headers] Define *_HAS_SUBNORM for FLT, DBL, LDBL Summary: These macros are defined in the C11 standard and can be defined based on the __*_HAS_DENORM__ default macros.

r338603 - [Android] Increase default new alignment for Android

Author: pirama Date: Wed Aug 1 10:55:34 2018 New Revision: 338603 URL: http://llvm.org/viewvc/llvm-project?rev=338603=rev Log: [Android] Increase default new alignment for Android Summary: Android's memory allocators also guarantee 8-byte alignment for 32-bit architectures and 16-byte alignment

[libcxx] r336141 - [Win32] Overload ==, != for locale_t and long long

Author: pirama Date: Mon Jul 2 13:11:15 2018 New Revision: 336141 URL: http://llvm.org/viewvc/llvm-project?rev=336141=rev Log: [Win32] Overload ==, != for locale_t and long long Summary: _is_chartype_l (needed for isxdigit_l) in MinGW compares locale_t and NULL. NULL is 'long long' for 64-bit,

[libcxx] r335916 - Configure ELAST for MinGW

Author: pirama Date: Thu Jun 28 13:16:45 2018 New Revision: 335916 URL: http://llvm.org/viewvc/llvm-project?rev=335916=rev Log: Configure ELAST for MinGW Summary: Use _LIBCPP_MSVCRT_LIKE while configuring ELAST, so MinGW gets the same configuration as MSVC. Reviewers: compnerd, srhines,

r328552 - [CodeGen] Mark fma as const for Android

Author: pirama Date: Mon Mar 26 10:03:34 2018 New Revision: 328552 URL: http://llvm.org/viewvc/llvm-project?rev=328552=rev Log: [CodeGen] Mark fma as const for Android Summary: r318093 sets fma, fmaf, fmal as const for Gnu and MSVC. Android also does not set errno for these functions. So mark

r319077 - Switch CPU names not recognized by GNU assembler

Author: pirama Date: Mon Nov 27 11:18:39 2017 New Revision: 319077 URL: http://llvm.org/viewvc/llvm-project?rev=319077=rev Log: Switch CPU names not recognized by GNU assembler Summary: Switch CPU names not recognized by GNU assembler to a close CPU that it does recognize. In this patch, kryo,

r297754 - [Driver] Fix arch-specific-libdir-rpath.c

Author: pirama Date: Tue Mar 14 12:26:56 2017 New Revision: 297754 URL: http://llvm.org/viewvc/llvm-project?rev=297754=rev Log: [Driver] Fix arch-specific-libdir-rpath.c Summary: Fix the test by adding missing -target flags with a 'linux' triple. Reviewers: rnk, srhines Subscribers:

r297751 - [Driver] Add flag to request arch-specific-subdir in -rpath

Author: pirama Date: Tue Mar 14 11:58:07 2017 New Revision: 297751 URL: http://llvm.org/viewvc/llvm-project?rev=297751=rev Log: [Driver] Add flag to request arch-specific-subdir in -rpath Summary: This patch adds -f[no-]rtlib-add-rpath, which if enabled, embeds the arch-specific subdirectory in

Re: r296927 - Add arch-specific directory to search path

wrote: > > Adding Reid, Michal > > > > > > On Mon, Mar 6, 2017 at 5:01 AM, Benjamin Kramer <benny@gmail.com> > wrote: > >> > >> On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits > >> <cfe-commits@lists.llvm.o

Re: r296927 - Add arch-specific directory to search path

Adding Reid, Michal On Mon, Mar 6, 2017 at 5:01 AM, Benjamin Kramer <benny@gmail.com> wrote: > On Sat, Mar 4, 2017 at 12:20 AM, Pirama Arumuga Nainar via cfe-commits > <cfe-commits@lists.llvm.org> wrote: > > Author: pirama > > Date: Fri Mar 3 17:20:49

r296929 - Restrict test arch-specific-libdir.c to Linux

Author: pirama Date: Fri Mar 3 17:48:15 2017 New Revision: 296929 URL: http://llvm.org/viewvc/llvm-project?rev=296929=rev Log: Restrict test arch-specific-libdir.c to Linux Summary: This fails on Windows due to dependence on path separators. Reviewers: rnk, srhines Subscribers: llvm-commits

r296927 - Add arch-specific directory to search path

Author: pirama Date: Fri Mar 3 17:20:49 2017 New Revision: 296927 URL: http://llvm.org/viewvc/llvm-project?rev=296927=rev Log: Add arch-specific directory to search path Summary: This change adds an arch-specific subdirectory in /lib/ to the linker search path. This path also gets added as

[PATCH] D26491: Define __ANDROID_API__ when specified as part of an Android target.

pirama accepted this revision. pirama added a reviewer: pirama. pirama added a comment. This revision is now accepted and ready to land. The bug points back to this Phab page instead of a bug. LGTM otherwise. https://reviews.llvm.org/D26491 ___

Re: [PATCH] D24010: [ReachableCode] Skip over ExprWithCleanups in isConfigurationValue

pirama added a comment. Ping... I am not the author of this patch, but am interested in seeing the issue fixed :) https://reviews.llvm.org/D24010 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r276904 - Adjust coercion of aggregates on RenderScript

Author: pirama Date: Wed Jul 27 14:01:51 2016 New Revision: 276904 URL: http://llvm.org/viewvc/llvm-project?rev=276904=rev Log: Adjust coercion of aggregates on RenderScript Summary: In RenderScript, the size of the argument or return value emitted in the IR is expected to be the same as the

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

This revision was automatically updated to reflect the committed changes. Closed by commit rL276455: Add .rgba syntax extension to ext_vector_type types (authored by pirama). Changed prior to commit: https://reviews.llvm.org/D20602?vs=62305=65119#toc Repository: rL LLVM

r276455 - Add .rgba syntax extension to ext_vector_type types

Author: pirama Date: Fri Jul 22 13:49:43 2016 New Revision: 276455 URL: http://llvm.org/viewvc/llvm-project?rev=276455=rev Log: Add .rgba syntax extension to ext_vector_type types Summary: This patch enables .rgba accessors to ext_vector_type types and adds tests for syntax validation and code

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. Ping... http://reviews.llvm.org/D20602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r274409 - Add TargetInfo for 32-bit and 64-bit RenderScript

Author: pirama Date: Fri Jul 1 19:05:42 2016 New Revision: 274409 URL: http://llvm.org/viewvc/llvm-project?rev=274409=rev Log: Add TargetInfo for 32-bit and 64-bit RenderScript Summary: The TargetInfo for 'renderscript32' and 'renderscript64' ArchTypes are subclasses of ARMleTargetInfo and

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

This revision was automatically updated to reflect the committed changes. Closed by commit rL274409: Add TargetInfo for 32-bit and 64-bit RenderScript (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21334?vs=62520=62581#toc Repository: rL LLVM

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama updated this revision to Diff 62520. pirama added a comment. Reformatted with clang-format for just the parts I added. I ignored clang-format-suggested changes in code unrelated to this patch. Is there a policy or practise on periodically fixing format-related issues? If not, I can

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 62305. pirama added a comment. Added GroupInfo to warning. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp

r273321 - Emit the DWARF tag for the RenderScript language

Author: pirama Date: Tue Jun 21 16:35:11 2016 New Revision: 273321 URL: http://llvm.org/viewvc/llvm-project?rev=273321=rev Log: Emit the DWARF tag for the RenderScript language Summary: If the RenderScript LangOpt is set, either via '-x renderscript' or the '.rs' file extension, set the DWARF

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

pirama abandoned this revision. pirama added a comment. Abandoning this revision. Patches for an alternative approach are listed above. http://reviews.llvm.org/D20709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21212: Add documentation for RenderScript changes

This revision was automatically updated to reflect the committed changes. Closed by commit rL273283: Add documentation for RenderScript changes (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21212?vs=61390=61391#toc Repository: rL LLVM

r273283 - Add documentation for RenderScript changes

Author: pirama Date: Tue Jun 21 11:09:30 2016 New Revision: 273283 URL: http://llvm.org/viewvc/llvm-project?rev=273283=rev Log: Add documentation for RenderScript changes Summary: - Document the new 'kernel' attribute - Mention RenderScript support in the Release Notes. Reviewers: rsmith

Re: [PATCH] D21212: Add documentation for RenderScript changes

pirama updated this revision to Diff 61390. pirama added a comment. computation -> computations. http://reviews.llvm.org/D21212 Files: docs/ReleaseNotes.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

[PATCH] D21451: Emit the DWARF tag for the RenderScript language

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. If the RenderScript LangOpt is set, either via '-x renderscript' or the '.rs' file extension, set the DWARF language tag to be that of RenderScript. http://reviews.llvm.org/D21451

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama updated this revision to Diff 60735. pirama added a comment. - revise test http://reviews.llvm.org/D21334 Files: lib/Basic/Targets.cpp test/CodeGen/renderscript.c Index: test/CodeGen/renderscript.c === --- /dev/null

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama added a comment. This patch is based on the discussion in http://reviews.llvm.org/D20709. http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20709: For RenderScript, set alignment and width of long to 64-bits

pirama added a comment. http://reviews.llvm.org/D21333 and http://reviews.llvm.org/D21334 add the RenderScript triple and modify 'long' based off the triple. r272317, r272342, r272438 take care of the LangOpt and handling of '-x renderscript' and '.rs' extensions.

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 60723. pirama added a comment. - Undo bad merge from different patch http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp test/CodeGen/ext-vector.c

Re: [PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama added a comment. http://reviews.llvm.org/D21333 is the corresponding patch to LLVM http://reviews.llvm.org/D21334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21334: Add TargetInfo for 32-bit and 64-bit RenderScript

pirama created this revision. pirama added reviewers: rsmith, echristo. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: mehdi_amini, danalbert, tberghammer, aemerson. The TargetInfo for 'renderscript32' and 'renderscript64' ArchTypes are subclasses of ARMleTargetInfo and

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 60718. pirama added a comment. Herald added subscribers: danalbert, tberghammer. - Add TargetInfo for 32-bit and 64-bit RenderScript http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 60425. pirama added a comment. Convert error to warning, update tests, and rename variable name. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp

Re: [PATCH] D21212: Add documentation for RenderScript changes

pirama updated this revision to Diff 60412. pirama added a comment. Rebase after submission of http://reviews.llvm.org/D21240. http://reviews.llvm.org/D21212 Files: docs/ReleaseNotes.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

r272438 - Revise RenderScript attribute declaration

Author: pirama Date: Fri Jun 10 16:51:18 2016 New Revision: 272438 URL: http://llvm.org/viewvc/llvm-project?rev=272438=rev Log: Revise RenderScript attribute declaration Summary: Address post-patch comments to r272342. - Rename the 'kernel' attribute's name - Idiomatically restrict the

Re: [PATCH] D21240: Revise RenderScript attribute declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL272438: Revise RenderScript attribute declaration (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21240?vs=60397=60411#toc Repository: rL LLVM http://reviews.llvm.org/D21240

Re: r272342 - RenderScript support in the Frontend

Uploaded http://reviews.llvm.org/D21240 with the requested changes. On Fri, Jun 10, 2016 at 7:39 AM, Aaron Ballman wrote: > > +def Kernel : Attr { > > Please rename this to RenderScriptKernel. We have another attribute > that is spelled "kernel" already, and we want to

Re: [PATCH] D21212: Add documentation for RenderScript changes

pirama updated this revision to Diff 60394. pirama added a comment. Expand description of RenderScript kernel functions. http://reviews.llvm.org/D21212 Files: docs/ReleaseNotes.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama added a comment. Thanks for the review. Docs update is in http://reviews.llvm.org/D21212 Repository: rL LLVM http://reviews.llvm.org/D21198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21212: Add documentation for RenderScript changes

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: danalbert, tberghammer. - Document the new 'kernel' attribute - Mention RenderScript support in the Release Notes. http://reviews.llvm.org/D21212 Files:

Re: [PATCH] D21198: RenderScript support in the Frontend

This revision was automatically updated to reflect the committed changes. Closed by commit rL272342: RenderScript support in the Frontend (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21198?vs=60277=60279#toc Repository: rL LLVM http://reviews.llvm.org/D21198

r272342 - RenderScript support in the Frontend

Author: pirama Date: Thu Jun 9 18:34:20 2016 New Revision: 272342 URL: http://llvm.org/viewvc/llvm-project?rev=272342=rev Log: RenderScript support in the Frontend Summary: Create a new Frontend LangOpt to specify the renderscript language. It is enabled by the "-x renderscript" option from

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama updated this revision to Diff 60277. pirama added a comment. Reorder IK_RenderScript before IK_AST like Richard had requested. http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Frontend/FrontendOptions.h

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama updated this revision to Diff 60252. pirama added a comment. Cleanup bad merge http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Frontend/FrontendOptions.h lib/Frontend/CompilerInvocation.cpp

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama added a comment. Oops, this update merged changes from http://reviews.llvm.org/D21199 as well. Let me clean up and upload a new patch. http://reviews.llvm.org/D21198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r272317 - Add a RenderScript language type

Author: pirama Date: Thu Jun 9 16:57:40 2016 New Revision: 272317 URL: http://llvm.org/viewvc/llvm-project?rev=272317=rev Log: Add a RenderScript language type Summary: Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to the

Re: [PATCH] D21199: Add a RenderScript language type

This revision was automatically updated to reflect the committed changes. Closed by commit rL272317: Add a RenderScript language type (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21199?vs=60238=60249#toc Repository: rL LLVM http://reviews.llvm.org/D21199 Files:

Re: [PATCH] D21198: RenderScript support in the Frontend

pirama updated this revision to Diff 60247. pirama updated the summary for this revision. pirama added a comment. Re-ordered enum http://reviews.llvm.org/D21198 Files: include/clang/Basic/Attr.td include/clang/Basic/LangOptions.def include/clang/Driver/Types.def

[PATCH] D21199: Add a RenderScript language type

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to the frontend for ".rs" files. (Also add '.rs' to the list of

[PATCH] D21198: Add a RenderScript language type

pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Add RenderScript language type and associate it with ".rs" extensions. Test that the driver passes "-x renderscript" to the frontend for ".rs" files. (Also add '.rs' to the list of

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. Friendly ping... http://reviews.llvm.org/D20602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20709: Support ARM subtarget feature +long64

pirama updated this revision to Diff 59294. pirama removed a reviewer: rsmith. pirama added a comment. Herald added subscribers: danalbert, tberghammer. Add a RenderScript langopt and updated to change long's size and alignment in TargetInfo::adjust(). http://reviews.llvm.org/D20709 Files:

Re: [PATCH] D20709: Support ARM subtarget feature +long64

pirama added a reviewer: rsmith. pirama added a comment. Adding Richard to reviewers as the planned direction of this patch directly relates to the Frontend. http://reviews.llvm.org/D20709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20709: Support ARM subtarget feature +long64

pirama added a comment. I looked at how LangOpts and TargetInfo are handled and found a way we can achieve 64-bit longs without a Target feature (and restrict it just to RenderScript!). This would be via TargetInfo::adjust(). I'll abandon the sibling patch to LLVM as we should be able to do

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58813. pirama added a comment. Switched to emitting errors when rgba is used in OpenCL < 2.2. Also, fixed the diagnostic's name mismatch at its point of issue. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h

[PATCH] D20709: Support ARM subtarget feature +long64

pirama created this revision. pirama added a reviewer: kristof.beyls. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: rengolin, aemerson. Set alignment and width of long datatype to be 64-bits if the ARM subtarget feature +long64 is set. http://reviews.llvm.org/D20709

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900 @@ -7897,1 +7899,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL 2.2 extension">; } // end of sema category

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58537. pirama added a comment. Renamed diagnostic to use ext_ prefix. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp test/CodeGen/ext-vector.c

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58535. pirama added a comment. Switched to ExtWarn, updated warning's message and made the version check strict w.r.t. 2.2. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. > > > I'm not suggesting it be treated as invalid. This extension is part of at > > > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is > > > Clang's implementation of the OpenCL vector type. Therefore if the user > > > asks us to support OpenCL

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58525. pirama added a comment. Added warnings when rgba is used with OpenCL http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. To summarize, there are two scenarios where a warning is warranted when the source language is OpenCL: > > I'm not suggesting it be treated as invalid. This extension is part of at > > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is > > Clang's

[PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama created this revision. pirama added subscribers: cfe-commits, srhines. This patch enables .rgba accessors to ext_vector_type types and adds tests for syntax validation and code generation. 'a' and 'b' can appear either in the point access mode or the numeric access mode (for indices 10

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

pirama added inline comments. Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp:5109 @@ -5108,3 +5108,3 @@ // natively, and does not need to interwork with AAPCS code. - if (Ty->isHalfType() && !getContext().getLangOpts().OpenCL) { + if (Ty->isHalfType() &&

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

pirama added a comment. Thanks for the review! Repository: rL LLVM http://reviews.llvm.org/D18138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18138: Add -fnative-half-arguments-and-returns

This revision was automatically updated to reflect the committed changes. Closed by commit rL263795: Add -fnative-half-arguments-and-returns (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D18138?vs=50564=51036#toc Repository: rL LLVM http://reviews.llvm.org/D18138

[PATCH] D18138: Add -fnative-half-arguments-and-returns

pirama created this revision. pirama added reviewers: srhines, olista01. pirama added a subscriber: cfe-commits. r246764 handled __fp16 arguments and returns for AAPCS, but skipped this handling for OpenCL. Simlar to OpenCL, RenderScript also handles __fp16 type natively. This patch adds the