[PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

rahmanl updated this revision to Diff 479906. rahmanl added a comment. - Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100808/new/ https://reviews.llvm.org/D100808 Files: llvm/include/llvm/CodeGen/BasicBlockSectionsProfileReader.h

[PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

rahmanl updated this revision to Diff 479905. rahmanl added a comment. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, hanchung, kadircet, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, steakhal, mtrofin, Enna1, bzcheeseman,

[PATCH] D88199: Introduce and use a new section type for the bb_addr_map section.

rahmanl updated this revision to Diff 295668. rahmanl added a comment. Diff reupload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88199/new/ https://reviews.llvm.org/D88199 Files: llvm/include/llvm/BinaryFormat/ELF.h

[PATCH] D88199: Introduce and use a new section type for the bb_addr_map section.

rahmanl updated this revision to Diff 295666. rahmanl added a comment. Herald added subscribers: libcxx-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commits, tatianashp, wenlei, ThomasRaoux, AlexeySotkin, msifontes, sstefan1, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer,

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7841e21c9849: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map… (authored by rahmanl). Repository: rG LLVM Github

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 291607. rahmanl added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files: clang/docs/UsersManual.rst

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 291595. rahmanl added a comment. - Merge branch 'master' into arcpatch-D85408 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files: clang/docs/UsersManual.rst

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 291589. rahmanl added a comment. - Remove the "labels" part of the clang test as the functionality is tested on LLVM tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added a comment. In D85408#2266559 , @dblaikie wrote: > In D85408#2262134 , @rahmanl wrote: > >> @efriedma Would you please chime in specially with respect to @MaskRay 's >> comment about the clang test

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 291156. rahmanl added a comment. - Remove the complex assembly from the clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files: clang/docs/UsersManual.rst

[PATCH] D87426: Disallow fbasic-block-sections on non-ELF, non-x86 targets.

rahmanl accepted this revision. rahmanl added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/fbasic-block-sections.c:11 // CHECK-OPT-LABELS: "-fbasic-block-sections=labels" +// CHECK-NOOPT-NOT: "-fbasic-block-sections"

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added a comment. @efriedma Would you please chime in specially with respect to @MaskRay 's comment about the clang test involving assembly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added a comment. Thanks for the review @MaskRay. Is this ready to land now? Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1047 + getObjFileLowering().getBBAddrMapSection(*MF.getSection()); + if (!BBAddrMapSection) +return; MaskRay

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 290511. rahmanl marked an inline comment as done. rahmanl added a comment. - Merge remote-tracking branch 'origin/master' into arcpatch-D85408 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1047 + getObjFileLowering().getBBAddrMapSection(*MF.getSection()); + if (!BBAddrMapSection) +return; MaskRay wrote: > BBAddrMapSection is always non-null. Delete the

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 289765. rahmanl marked 5 inline comments as done. rahmanl added a comment. - Address +MaskRay's comments: - Change the check prefix simply to "CHECK" for basic-block-sections-labels.ll - Change the triple to x86_64 for this test. - nits. - Remove the "-LABEL"

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added a comment. Thanks a lot for the comments @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 ___ cfe-commits mailing list

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 289498. rahmanl marked 5 inline comments as done. rahmanl added a comment. - Address @MaskRay's comments. - Rebase with upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl marked an inline comment as done. rahmanl added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1030 +/// recursive return edges vs. indirect branches. The format of the metadata is +/// described as follows: 1st bit (LSB): set if this is a return

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 288694. rahmanl added a comment. - Move getBBAddrMetadata to AsmPrinter as a static function + nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files:

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl added inline comments. Comment at: llvm/lib/CodeGen/MachineBasicBlock.cpp:58 +unsigned MachineBasicBlock::getBBAddrMapMetadata() const { + const TargetInstrInfo *TII = getParent()->getSubtarget().getInstrInfo(); snehasish wrote: > I think this method

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 288158. rahmanl marked 4 inline comments as done. rahmanl added a comment. Address Snehasish's comments. - Move getBBAddrMetadata to AsmPrinter as a static function in AsmPrinter - Remove unnecessary IR instructions in basic-block-sections-labels.ll

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 288105. rahmanl added a comment. Fix failing clang test which used to check for the old ".bb_info" name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/ https://reviews.llvm.org/D85408 Files:

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_addr_map section, instead of emitting special unary-encoded symbols.

rahmanl updated this revision to Diff 288104. rahmanl edited the summary of this revision. rahmanl added a comment. Fix failing clang test which used to check for the old ".bb_info" name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85408/new/

[PATCH] D85408: Let -basic-block-sections=labels emit basicblock metadata in a new .bb_info section, instead of emitting special unary-encoded symbols.

rahmanl created this revision. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. rahmanl updated this revision to Diff 285826. rahmanl added a comment. rahmanl updated this revision to Diff 285828. rahmanl updated this revision to Diff 285830. Herald added a project: