[PATCH] D122712: Make test case warning more specific for pattern match

rs added a comment. In D122712#3416238 , @benshi001 wrote: > I do not like this change, since > > 1. actually there may be many kinds of warnings emitted by the > clang-driver-avr depending on different options, and this single line `// > NOWARN-NOT:

[PATCH] D122712: Make test case warning more specific for pattern match

rs created this revision. rs added a reviewer: benshi001. Herald added subscribers: Jim, dylanmckay. Herald added a project: All. rs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It's possible that other compilers based on llvm might

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

This revision was automatically updated to reflect the committed changes. Closed by commit rG4df69c1ff19f: [ARM] Make testcase warning pattern match more specific (authored by rs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122487/new/

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

rs added a comment. @tstellar thanks for the review. I can't really think of any other way to test this. I'll wait till Monday if no one else has suggested anything else then I'll commit it. Thanks again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

rs created this revision. rs added reviewers: tstellar, lenary. Herald added a subscriber: kristof.beyls. Herald added a project: All. rs requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make the warning more specific as downstream

[PATCH] D88546: [ARM] Update NEON testcase with missing target string in

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4f50e587f07: [ARM] Add missing target for Arm neon test case. (authored by rs). Changed prior to commit: https://reviews.llvm.org/D88546?vs=295219=295435#toc Repository: rG LLVM Github Monorepo

[PATCH] D88546: [ARM] Update NEON testcase with missing target string in

rs created this revision. rs added reviewers: SjoerdMeijer, john.brawn. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. rs requested review of this revision. This is a follow-up from https://reviews.llvm.org/D61717. Where Richard described the

[PATCH] D31078: [libunwind] Clean up macro usage.

rs updated this revision to Diff 93646. rs marked 6 inline comments as done. https://reviews.llvm.org/D31078 Files: include/__libunwind_config.h include/libunwind.h include/unwind.h src/AddressSpace.hpp src/Unwind-EHABI.cpp src/Unwind-EHABI.h src/Unwind-sjlj.c

[PATCH] D31078: [libunwind] Clean up macro usage.

rs created this revision. Convention in libunwind is to use !defined(FOO) not !FOO. https://reviews.llvm.org/D31078 Files: include/__libunwind_config.h include/libunwind.h include/unwind.h src/AddressSpace.hpp src/Unwind-EHABI.cpp src/Unwind-EHABI.h src/Unwind-sjlj.c

[PATCH] D30459: [libcxxabi] Clean up macro usage

rs added a comment. ok thanks. https://reviews.llvm.org/D30459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30459: [libcxxabi] Clean up macro usage

rs created this revision. Herald added a subscriber: mgorny. Convention in libcxxabi is to use !defined(FOO) not !FOO. https://reviews.llvm.org/D30459 Files: CMakeLists.txt include/__cxxabi_config.h include/cxxabi.h src/abort_message.cpp src/config.h src/cxa_default_handlers.cpp

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

rs added a comment. > This works for me, but the idiomatic macro usage in libc++, and (hopefully) > libc++abi should always use !defined(FOO) as opposed to !FOO. I'll clean this > up in the next week if nobody else wants to. I can do the clean up later this week. Repository: rL LLVM

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

rs added a comment. Going for post-commit. https://reviews.llvm.org/D30343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30339: [libcxxabi] Disable calls to fprintf when building for baremetal targets in release mode

rs added a comment. Ah sorry for the mistake. Fix is here https://reviews.llvm.org/D30343 Repository: rL LLVM https://reviews.llvm.org/D30339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30343: [libcxxabi] Fix condition typo in rL296136

rs created this revision. Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always defined, I should have been checking the contents to see if it's enabled https://reviews.llvm.org/D30343 Files: src/abort_message.cpp Index: src/abort_message.cpp

[PATCH] D30340: [libunwind] Disable calls to fprintf when building for baremetal targets in release mode

rs created this revision. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is dependent on io functions, this patch disable calls to fprintf when building for baremetal targets in release mode. https://reviews.llvm.org/D30340 Files:

[PATCH] D30339: Disable calls to fprintf when building for baremetal targets in release mode

rs created this revision. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is dependent on io functions, this patch disable calls to fprintf when building for baremetal targets in release mode. https://reviews.llvm.org/D30339 Files: