[clang] 4df69c1 - [ARM] Make testcase warning pattern match more specific

2022-03-28 Thread Ranjeet Singh via cfe-commits
Author: Ranjeet Singh Date: 2022-03-28T14:44:15+01:00 New Revision: 4df69c1ff19f75e302cfc3e022009fe971fc5c24 URL: https://github.com/llvm/llvm-project/commit/4df69c1ff19f75e302cfc3e022009fe971fc5c24 DIFF: https://github.com/llvm/llvm-project/commit/4df69c1ff19f75e302cfc3e022009fe971fc5c24.diff

[clang] e4f50e5 - [ARM] Add missing target for Arm neon test case.

2020-09-30 Thread Ranjeet Singh via cfe-commits
Author: Ranjeet Singh Date: 2020-10-01T00:32:33+01:00 New Revision: e4f50e587f077c246b7f29db0b7daddf583e2b64 URL: https://github.com/llvm/llvm-project/commit/e4f50e587f077c246b7f29db0b7daddf583e2b64 DIFF: https://github.com/llvm/llvm-project/commit/e4f50e587f077c246b7f29db0b7daddf583e2b64.diff

[libcxxabi] r296612 - [libcxxabi] Clean up macro usage.

2017-03-01 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Wed Mar 1 05:42:01 2017 New Revision: 296612 URL: http://llvm.org/viewvc/llvm-project?rev=296612=rev Log: [libcxxabi] Clean up macro usage. Convention in libcxxabi is to use !defined(FOO) not !FOO. Differential Revision: https://reviews.llvm.org/D30459 Modified:

[libcxxabi] r296146 - [libcxxabi] Fix condition typo in rL296136

2017-02-24 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Fri Feb 24 12:22:59 2017 New Revision: 296146 URL: http://llvm.org/viewvc/llvm-project?rev=296146=rev Log: [libcxxabi] Fix condition typo in rL296136 Made a mistake in the condition typo because LIBCXXABI_BAREMETAL is always defined, I should have been checking the contents

[libunwind] r296135 - [libunwind] Disable calls to fprintf for baremetal targets.

2017-02-24 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Fri Feb 24 10:38:05 2017 New Revision: 296135 URL: http://llvm.org/viewvc/llvm-project?rev=296135=rev Log: [libunwind] Disable calls to fprintf for baremetal targets. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is

[libcxxabi] r296136 - [libcxxabi] Disable calls to fprintf for baremetal targets.

2017-02-24 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Fri Feb 24 10:43:36 2017 New Revision: 296136 URL: http://llvm.org/viewvc/llvm-project?rev=296136=rev Log: [libcxxabi] Disable calls to fprintf for baremetal targets. We've been having issues with using libcxxabi and libunwind for baremetal targets because fprintf is

Re: [PATCH] D16135: Macro Debug Info support in Clang

2016-07-22 Thread Ranjeet Singh via cfe-commits
rs added a subscriber: rs. rs added a comment. Hi Amjad, are you still planning on getting this patch and https://reviews.llvm.org/D16077 committed ? It looks like these two patches are final pieces in the puzzle to get macro information in the DWARF debug output. I've downloaded the diffs

r272983 - [ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics.

2016-06-16 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Thu Jun 16 19:59:41 2016 New Revision: 272983 URL: http://llvm.org/viewvc/llvm-project?rev=272983=rev Log: [ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics. Reapplying patch in r272777 which was reverted because the llvm patch which added support for

r272790 - Reverting r272777 because one of the tests

2016-06-15 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Wed Jun 15 09:21:28 2016 New Revision: 272790 URL: http://llvm.org/viewvc/llvm-project?rev=272790=rev Log: Reverting r272777 because one of the tests added in the llvm patch is causing an assertion to fail. Modified: cfe/trunk/include/clang/Basic/BuiltinsARM.def

r272777 - [ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics.

2016-06-15 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Wed Jun 15 06:32:18 2016 New Revision: 272777 URL: http://llvm.org/viewvc/llvm-project?rev=272777=rev Log: [ARM] Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics. Patch adds intrinsics for mrrc/mrrc2. The intrinsics for mrrc/mrrc2 return a single uint64_t

Re: [PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

2016-06-13 Thread Ranjeet Singh via cfe-commits
rs updated this revision to Diff 60504. rs added a comment. Hi Renato, please look again at this patch, I've addressed your comments. Thanks, Ranjeet http://reviews.llvm.org/D21179 Files: include/clang/Basic/BuiltinsARM.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-arm.c

Re: [PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

2016-06-13 Thread Ranjeet Singh via cfe-commits
rs marked 3 inline comments as done. Comment at: test/CodeGen/builtins-arm.c:203 @@ -188,5 +202,3 @@ -void mcrr2(unsigned a, unsigned b) { - // CHECK: define void @mcrr2(i32 [[A:%.*]], i32 [[B:%.*]]) - // CHECK: call void @llvm.arm.mcrr2(i32 15, i32 0, i32 [[A]], i32 [[B]],

Re: [PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

2016-06-09 Thread Ranjeet Singh via cfe-commits
rs added a comment. LLVM part of the patch is here http://reviews.llvm.org/D21178 http://reviews.llvm.org/D21179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21179: Add mrrc/mrrc2 intrinsics and update existing mcrr/mcrr2 intrinsics to accept a single uint64 type instead of 2 uint32 types

2016-06-09 Thread Ranjeet Singh via cfe-commits
rs created this revision. rs added reviewers: t.p.northover, rengolin. rs added a subscriber: cfe-commits. Patch adds support for the intrinsics mrrc/mrrc2 and updates the existing mcrr/mcrr2 intrinsic definition to accept a single uint64 type as the input value instead of 2 uint32's as I think

r271275 - [ARM] Add load/store co-processor intrinsics.

2016-05-31 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Tue May 31 08:31:25 2016 New Revision: 271275 URL: http://llvm.org/viewvc/llvm-project?rev=271275=rev Log: [ARM] Add load/store co-processor intrinsics. Differential Revision: http://reviews.llvm.org/D20563 Modified: cfe/trunk/include/clang/Basic/BuiltinsARM.def

Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Ranjeet Singh via cfe-commits
rs marked an inline comment as done. rs added a comment. Tim thanks for reviewing this patch. I've uploaded a new one with your suggested change. If I don't respond to any further comments after today it'll be because I'm on holiday and won't be back till next week.

Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Ranjeet Singh via cfe-commits
rs updated this revision to Diff 58314. http://reviews.llvm.org/D20563 Files: include/clang/Basic/BuiltinsARM.def test/CodeGen/builtins-arm.c test/Sema/builtins-arm.c Index: test/Sema/builtins-arm.c === ---

Re: [PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Ranjeet Singh via cfe-commits
rs added a comment. LLVM part of the patch is here http://reviews.llvm.org/D20564 http://reviews.llvm.org/D20563 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20563: Add load/store co-processor intrinsics

2016-05-24 Thread Ranjeet Singh via cfe-commits
rs created this revision. rs added a reviewer: rengolin. rs added a subscriber: cfe-commits. Patch adds intrinsics for ldc, ldcl, ldc2, ldc2l, stc, stcl, stc2 and stc2l. http://reviews.llvm.org/D20563 Files: include/clang/Basic/BuiltinsARM.def test/CodeGen/builtins-arm.c

r270058 - [ARM] Fix cdp intrinsic

2016-05-19 Thread Ranjeet Singh via cfe-commits
Author: rsingh Date: Thu May 19 08:04:34 2016 New Revision: 270058 URL: http://llvm.org/viewvc/llvm-project?rev=270058=rev Log: [ARM] Fix cdp intrinsic - Fixed cdp intrinsic to only accept compile time constant values previously you could pass in a variable to the builtin which would result

Re: [PATCH] D20325: Add ARM cdp intrinsics

2016-05-18 Thread Ranjeet Singh via cfe-commits
rs added a comment. > http://reviews.llvm.org/D20394 which adds a test for the intrinsic in llvm Wrong link, should be http://reviews.llvm.org/D20393 Repository: rL LLVM http://reviews.llvm.org/D20325 ___ cfe-commits mailing list

Re: [PATCH] D20325: Add ARM cdp intrinsics

2016-05-18 Thread Ranjeet Singh via cfe-commits
rs added a comment. Hi Renato, I've created 2 new reviews for this work http://reviews.llvm.org/D20394 which adds a test for the intrinsic in llvm and http://reviews.llvm.org/D20394 which fixes the builtin signature for the cdp intrinsic. Thanks, Ranjeet Repository: rL LLVM

[PATCH] D20394: Fix cdp intrinsic

2016-05-18 Thread Ranjeet Singh via cfe-commits
rs created this revision. rs added a reviewer: rengolin. rs added a subscriber: cfe-commits. Fixed cdp intrinsic to only accept compile time constant values, previously you could pass in a variable to the builtin which would result in illegal llvm assembly output.

Re: [PATCH] D20325: Add ARM cdp intrinsics

2016-05-18 Thread Ranjeet Singh via cfe-commits
rs marked an inline comment as done. rs added a comment. > It's been our stance for a long time to require docs to approve changes, > however small. I don't want to relax that which I think is a good constraint, > not for such a seemly irrelevant issue. > I also doubt this will be the only