[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

ravi-ramaseshan requested changes to this revision. ravi-ramaseshan added inline comments. Comment at: clang/tools/clang-stat-cache/clang-stat-cache.cpp:28 +#include +#include + Some of these includes may not be available on a platform like Windows. Can you

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan added a comment. In D74811#1885514 , @scott.linder wrote: > Multiple build bots were failing with the patch applied, see e.g. >

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan added a comment. Can you please land this change for me since I do not have commit rights. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan added a comment. In D74811#1882783 , @scott.linder wrote: > This LGTM, but could you add a simple test with a command-line that needs the > escaping? Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan updated this revision to Diff 245456. ravi-ramaseshan added a comment. Add a simple test with a command-line that needs the escaping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74811/new/ https://reviews.llvm.org/D74811 Files:

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan created this revision. ravi-ramaseshan added reviewers: scott.linder, rjmccall. Herald added a project: clang. Similar to the rest of the command line that is recorded, the program path must also have spaces and backslashes escaped. Without this parsing the recorded command line