[PATCH] D142733: Add _Optional as fast qualifier

rriddle added a comment. I don't understand the MLIR changes here, how are they relevant to the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142733/new/ https://reviews.llvm.org/D142733 ___

[PATCH] D134087: [TableGen] Track reference locations of Records/RecordVals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. rriddle marked 2 inline comments as done. Closed by commit rG50d96f59d096: [TableGen] Track reference locations of Records/RecordVals (authored by rriddle). Herald

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

rriddle added a comment. +1 on all of the other comments, especially related to the use of strings. In D124750#3503607 , @Mogball wrote: > On the matter of whether this should be a canonicalization, my concern with > this is that if an operation has

[PATCH] D123297: [flang][driver] Add support for -mmlir

rriddle added inline comments. Comment at: flang/test/Driver/mllvm_vs_mmlir.f90:17 +! MLLVM: flang (LLVM option parsing) [options] +! MLLVM: --print-ir-after-all +! MLLVM-NOT: --mlir-{{.*}} awarzynski wrote: > awarzynski wrote: > > rovka wrote: > > > rovka

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c484f11d355: [llvm] Add a SFINAE template parameter to DenseMapInfo (authored by rriddle). Changed prior to commit:

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle updated this revision to Diff 387386. rriddle added a comment. Herald added subscribers: lldb-commits, hiraditya. Herald added a project: LLDB. resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle added inline comments. Comment at: llvm/include/llvm/ADT/Hashing.h:59 namespace llvm { -template struct DenseMapInfo; lattner wrote: > Is there a way to keep the forward declarations references here instead of > #include? DenseMapInfo.h pulls in a

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle added a comment. Given the new template parameter, I needed to update the forward declarations. Some of them already had DenseMapInfo from an include, so I just dropped them. Some didn't, so I opted to just add an include for DenseMapInfo (seemed small enough). I could avoid the

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle created this revision. rriddle added reviewers: dblaikie, mehdi_amini, lattner, silvas. Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, ThomasRaoux, jdoerfert, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1,

[PATCH] D83088: Introduce CfgTraits abstraction

rriddle added inline comments. Comment at: mlir/include/mlir/IR/Dominance.h:49 +template <> +struct llvm::CfgTraitsFor { + using CfgTraits = mlir::CfgTraits; This seems to have broken the GCC5 build:

[PATCH] D83087: DomTree: remove explicit use of DomTreeNodeBase::iterator

rriddle accepted this revision. rriddle added a comment. Approval for anything MLIR related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83087/new/ https://reviews.llvm.org/D83087 ___ cfe-commits

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

rriddle accepted this revision. rriddle marked an inline comment as done. rriddle added a comment. This revision is now accepted and ready to land. I have run into the desire to have this on many occasions, so LGTM for me. Comment at: clang/include/clang/AST/DeclBase.h:521

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

rriddle accepted this revision. rriddle added a comment. This revision is now accepted and ready to land. (Appeasing herald for MLIR changes). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71775/new/ https://reviews.llvm.org/D71775 ___

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

rriddle added inline comments. Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVControlFlowOps.td:463 +Location loc, Value condition, +llvm::function_ref thenBody, +OpBuilder *builder); Drop the llvm::. Comment at: