[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. In D126172#3754221 , @mizvekov wrote: > Hello, @roberteg16, are you still interested in working on this patch? > > I might need a fix for this myself, and also it happened recently that > someone else attempted a fix for the

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. Hi again @mizvekov, I've been spending a bit of time on resuming this issue. When applying (after reverting the changes) the first change related to the `Template` case of profiling the as-written one name this resulted in the following test failing: Changes:

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. Thanks @mizvekov for such an insightful review. I'll try to address ASAP everything you said and let you know the results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 added a comment. @rsmith polite ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431451. roberteg16 added a comment. Fix wrongly moved clang-format disabling comment when trying to fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431416. roberteg16 added a comment. Fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 Files: clang/lib/AST/TemplateBase.cpp

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431389. roberteg16 added a comment. Try fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 Files: clang/lib/AST/TemplateBase.cpp

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431356. roberteg16 added a comment. Stricten comparison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172 Files: clang/lib/AST/TemplateBase.cpp

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431264. roberteg16 edited the summary of this revision. roberteg16 added a comment. Make clang-format not complain Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 created this revision. roberteg16 added reviewers: Richard, smith. Herald added a project: All. roberteg16 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff path takes care of comparing Template{Expansion} by template