[clang] 37be748 - Revert "[clang][ObjC] Add fix it for missing methods in impl"

2022-01-04 Thread Rumeet Dhindsa via cfe-commits
Author: Rumeet Dhindsa Date: 2022-01-04T16:43:54-08:00 New Revision: 37be74885946f18dbeb70343ad659924c61d2549 URL: https://github.com/llvm/llvm-project/commit/37be74885946f18dbeb70343ad659924c61d2549 DIFF:

[clang] 9b2ab41 - Revert "[MS] Fix assert handling enum forward decls in hasVisibleDefinition"

2020-04-20 Thread Rumeet Dhindsa via cfe-commits
Author: Rumeet Dhindsa Date: 2020-04-20T10:40:27-07:00 New Revision: 9b2ab41037f45ad92ab4e850591093ffc45d3e10 URL: https://github.com/llvm/llvm-project/commit/9b2ab41037f45ad92ab4e850591093ffc45d3e10 DIFF:

[clang] 57a2eaf - Revert "[modules] Do not cache invalid state for modules that we attempted to load."

2020-03-10 Thread Rumeet Dhindsa via cfe-commits
Author: Rumeet Dhindsa Date: 2020-03-10T10:59:26-07:00 New Revision: 57a2eaf3c1aa1a08e9b474b873064e075c52daef URL: https://github.com/llvm/llvm-project/commit/57a2eaf3c1aa1a08e9b474b873064e075c52daef DIFF:

Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

2020-02-25 Thread Rumeet Dhindsa via cfe-commits
Hi, I saw that this patch was reverted again later, but wanted to let you know the performance impact we saw with this patch. We are testing this on a variety of x86 machines and saw across the board regressions in Eigen of around 25-50%, changing no compile time options. Thanks, Rumeet On Wed,

Re: r364359 - Revert Devirtualize destructor of final class.

2019-06-25 Thread Rumeet Dhindsa via cfe-commits
Sorry for not including the reason, I discussed offline with the author to temporarily revert this patch. On Tue, Jun 25, 2019 at 4:00 PM Roman Lebedev wrote: > On Wed, Jun 26, 2019 at 1:58 AM Rumeet Dhindsa via cfe-commits > wrote: > > > > Author: rdhindsa > > Date:

r364359 - Revert Devirtualize destructor of final class.

2019-06-25 Thread Rumeet Dhindsa via cfe-commits
Author: rdhindsa Date: Tue Jun 25 15:58:25 2019 New Revision: 364359 URL: http://llvm.org/viewvc/llvm-project?rev=364359=rev Log: Revert Devirtualize destructor of final class. This reverts r364100 (git commit 405c2b16225fc6eaf5eb8ba3ce584699a3b159ef) Removed: