stringham added a comment.
I think that adding `AlwaysBreakWithDanglingParenthesis` as an option to
`BracketAlignmentStyle` should not impact any of the binpacking settings - they
should be distinct configuration.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D33029/new/
stringham added a comment.
Here's a commit rebased as of yesterday that is still adding
DanglingParenthesis option instead of extending the BracketAlignmentStyle
configuration.
https://github.com/lucidsoftware/llvm-project/commit/3c04de1feffaa9787234da8fe3cf288eebc979d6
CHANGES SINCE LAST
stringham added a comment.
@bbassi, I don't have plans to address this, and am supportive of you finishing
it up.
The plan was to move this as one of the options in the `BracketAlignmentStyle`
configuration (value of `AlwaysBreakWithDanglingParenthesis`) rather than have
it be a brand new
stringham added a comment.
@MyDeveloperDay done
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D33029/new/
https://reviews.llvm.org/D33029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
stringham added a comment.
@MyDeveloperDay I am happy to write unit tests and clean up the change set but
I don't want to spend more time on this if it has no chance of being merged.
I am looking for some agreement that this feature is worth adding to clang
format and then I'd like to know
stringham added a comment.
@djasper can you give some direction here?
Would you be okay with me extending the BracketAlignmentStyle option?
What do I need to do to get this change merged?
https://reviews.llvm.org/D33029
___
cfe-commits mailing
stringham added a comment.
@djasper should I move forward with extending the BracketAlignmentStyle option?
I'm happy to do it, but I'd like to get the idea signed off on before I spend
more time working on it. We've been using a version of clang-format with these
changes since May, and we've
stringham added inline comments.
Comment at: include/clang/Format/Format.h:793
+ /// \endcode
+ bool DanglingParenthesis;
+
djasper wrote:
> stringham wrote:
> > djasper wrote:
> > > I don't think this is a name that anyone will intuitively understand. I
> >
stringham updated this revision to Diff 99010.
stringham added a comment.
Generated the documentation using dump_format_style.py
removed some unnecessary braces.
https://reviews.llvm.org/D33029
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
stringham added a comment.
> Probably all of the examples from the original patch description and later
> comments should be turned into unit tests.
I would like to add some unit tests for this, but was not able to figure out
how to run the unit test suite. Where can I find instructions on how
stringham updated this revision to Diff 98873.
https://reviews.llvm.org/D33029
Files:
docs/ClangFormatStyleOptions.rst
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/ContinuationIndenter.h
lib/Format/Format.cpp
lib/Format/TokenAnnotator.cpp
stringham added a comment.
If the parameter list fits within the column limit, and there are no trailing
commas, then we don't end up wrapping the closing paren.
If it is long enough that it causes wrapping (regardless of trailing commas),
and the wrapping happens directly after the opening
stringham added a comment.
I think we should have the option whether or not a trailing comma is preset for
a few reasons:
1. clang-format doesn't support enforcing adding trailing commas
2. trailing commas aren't always supported (if you use the rest operator)
- `Uncaught SyntaxError: Rest
stringham added a comment.
1. be used in a project of significant size (have dozens of contributors)
- We are using this at Lucid Software (https://www.lucidchart.com &
https://www.lucidpress.com) to format our JS and TS (we are using clang-format
to automatically style over 650,000 lines of
stringham created this revision.
stringham added a project: clang-tools-extra.
Herald added a subscriber: klimek.
This adds an option to clang-format to support dangling parenthesis.
If you have a parameter list like
Foo(
param1,
param2,
param3,
);
clang-format currently only supports
15 matches
Mail list logo
