r364352 - android: enable double-word CAS on x64

2019-06-25 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jun 25 14:43:34 2019 New Revision: 364352 URL: http://llvm.org/viewvc/llvm-project?rev=364352=rev Log: android: enable double-word CAS on x64 The android target assumes that for the x86_64 target, the CPU supports SSE4.2 and popcnt. This implies that the CPU is Nehalem

r364147 - Revert "builtins: relax __iso_volatile_{load,store}32"

2019-06-22 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 22 19:53:03 2019 New Revision: 364147 URL: http://llvm.org/viewvc/llvm-project?rev=364147=rev Log: Revert "builtins: relax __iso_volatile_{load,store}32" This reverts commit SVN r364137. This seems to be cause problems with casting in C. Removed:

r364137 - builtins: relax __iso_volatile_{load,store}32

2019-06-22 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jun 22 11:55:51 2019 New Revision: 364137 URL: http://llvm.org/viewvc/llvm-project?rev=364137=rev Log: builtins: relax __iso_volatile_{load,store}32 This is reduced from MSVC's MSVCPRT 14.21.27702 atomic header. Because Windows is a LLP64 environment, `long`, `long

r361859 - Driver: support `/Zc:char8_t` and `/Zc:char8_t-`

2019-05-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue May 28 11:26:00 2019 New Revision: 361859 URL: http://llvm.org/viewvc/llvm-project?rev=361859=rev Log: Driver: support `/Zc:char8_t` and `/Zc:char8_t-` Update the `cl` emulation to support the `/Zc:char8_t[-]?` options as per the MSVC 2019.1 toolset. These are aliases

[clang-tools-extra] r358127 - clangd-fuzzer: repair the build

2019-04-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 10 12:16:14 2019 New Revision: 358127 URL: http://llvm.org/viewvc/llvm-project?rev=358127=rev Log: clangd-fuzzer: repair the build The inclusion of private headers of clangd percolates into the fuzzer. Modified:

[clang-tools-extra] r358107 - build: add binary dir to the unittests

2019-04-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 10 10:25:14 2019 New Revision: 358107 URL: http://llvm.org/viewvc/llvm-project?rev=358107=rev Log: build: add binary dir to the unittests Missed part of the change to make clangd build on Darwin. Fixes the build after SVN r358103. Modified:

[clang-tools-extra] r358103 - clangd: fix the build with XPC

2019-04-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 10 09:48:52 2019 New Revision: 358103 URL: http://llvm.org/viewvc/llvm-project?rev=358103=rev Log: clangd: fix the build with XPC `Transport.h` does not include `Features.inc`. However, since it is used in a subdirectory, it cannot directly include the header as

[clang-tools-extra] r358093 - clangd: repair the build after SVN r358091

2019-04-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 10 08:45:05 2019 New Revision: 358093 URL: http://llvm.org/viewvc/llvm-project?rev=358093=rev Log: clangd: repair the build after SVN r358091 Fix the name of the variable being checked. NFCI. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp

r354678 - CodeGen: use COMDAT for block copy/destroy helpers

2019-02-22 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Feb 22 08:29:50 2019 New Revision: 354678 URL: http://llvm.org/viewvc/llvm-project?rev=354678=rev Log: CodeGen: use COMDAT for block copy/destroy helpers SVN r339438 added support to deduplicate the helpers by using a consistent naming scheme and using LinkOnceODR

r350476 - CodeGen: fix autolink emission on ELF

2019-01-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 5 11:27:12 2019 New Revision: 350476 URL: http://llvm.org/viewvc/llvm-project?rev=350476=rev Log: CodeGen: fix autolink emission on ELF The autolinking extension for ELF uses a slightly different format for encoding the autolink information compared to COFF and

r350472 - CodeGen: switch iteration to range based for loop (NFC)

2019-01-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 5 10:39:32 2019 New Revision: 350472 URL: http://llvm.org/viewvc/llvm-project?rev=350472=rev Log: CodeGen: switch iteration to range based for loop (NFC) Change a loop to range based instead while working on cleaning up some modules autolinking issues on Linux.

r348939 - Basic: make `int_least64_t` and `int_fast64_t` match on Darwin

2018-12-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Dec 12 09:05:20 2018 New Revision: 348939 URL: http://llvm.org/viewvc/llvm-project?rev=348939=rev Log: Basic: make `int_least64_t` and `int_fast64_t` match on Darwin The Darwin targets use `int64_t` and `uint64_t` to define the `int_least64_t` and `int_fast64_t` types.

r348454 - ARM, AArch64: support `__attribute__((__swiftcall__))`

2018-12-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Dec 5 19:28:37 2018 New Revision: 348454 URL: http://llvm.org/viewvc/llvm-project?rev=348454=rev Log: ARM, AArch64: support `__attribute__((__swiftcall__))` Support the Swift calling convention on Windows ARM and AArch64. Both of these conform to the AAPCS, AAPCS64

r345479 - AST: extend MS decoration handling for extended vectors

2018-10-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Oct 28 11:05:20 2018 New Revision: 345479 URL: http://llvm.org/viewvc/llvm-project?rev=345479=rev Log: AST: extend MS decoration handling for extended vectors We correctly handled extended vectors of non-floating point types. However, we have the Intel style builtins

r345449 - AST: fix a typo in a comment (NFC)

2018-10-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 26 23:12:52 2018 New Revision: 345449 URL: http://llvm.org/viewvc/llvm-project?rev=345449=rev Log: AST: fix a typo in a comment (NFC) Fix a typo spotted by Akira! NFC Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL:

r345360 - CodeGen: correct the case for swift 4.2, 5.0

2018-10-25 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Oct 25 20:16:16 2018 New Revision: 345360 URL: http://llvm.org/viewvc/llvm-project?rev=345360=rev Log: CodeGen: correct the case for swift 4.2, 5.0 This corrects the leader for the swift names. The encoding for 4.2 and 5.0 differ by a single bit on the second

r345291 - CodeGen: alter CFConstantString class name for swift 5.0

2018-10-25 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Oct 25 10:52:13 2018 New Revision: 345291 URL: http://llvm.org/viewvc/llvm-project?rev=345291=rev Log: CodeGen: alter CFConstantString class name for swift 5.0 Swift 5.0 has changed the name decoration for swift symbols, using a 'S' sigil rather than 's' as in 4.2.

r345222 - Driver, CodeGen: introduce support for Swift CFString layout

2018-10-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Oct 24 16:28:28 2018 New Revision: 345222 URL: http://llvm.org/viewvc/llvm-project?rev=345222=rev Log: Driver,CodeGen: introduce support for Swift CFString layout Add a new driver level flag `-fcf-runtime-abi=` that allows one to specify the runtime ABI for

r345160 - CodeGen: extract some local variables in CFConstantString creation (NFC)

2018-10-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Oct 24 09:56:36 2018 New Revision: 345160 URL: http://llvm.org/viewvc/llvm-project?rev=345160=rev Log: CodeGen: extract some local variables in CFConstantString creation (NFC) Extract the reference to the ASTContext and Triple and use them throughout the function.

r345159 - AST: unindent CFConstantStringDecl by inverting condition (NFC)

2018-10-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Oct 24 09:38:16 2018 New Revision: 345159 URL: http://llvm.org/viewvc/llvm-project?rev=345159=rev Log: AST: unindent CFConstantStringDecl by inverting condition (NFC) Unindent the body of the function by inverting check at the top. This is in preparation for

r343338 - AST: add missing ObjC extensions to MS style name decoration

2018-09-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Sep 28 09:47:53 2018 New Revision: 343338 URL: http://llvm.org/viewvc/llvm-project?rev=343338=rev Log: AST: add missing ObjC extensions to MS style name decoration Add support for encoding type arguments for lightweight generics in Objective-C++ mode. Additionally,

r342929 - Driver: render arguments for the embedded bitcode correctly

2018-09-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Sep 24 16:50:02 2018 New Revision: 342929 URL: http://llvm.org/viewvc/llvm-project?rev=342929=rev Log: Driver: render arguments for the embedded bitcode correctly When embedding bitcode, only a subset of the arguments should be recorded into the bitcode compilation

r342581 - test: actually fix the condition properly

2018-09-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Sep 19 12:20:30 2018 New Revision: 342581 URL: http://llvm.org/viewvc/llvm-project?rev=342581=rev Log: test: actually fix the condition properly I had locally changed the test to add an explicit triple to figure out the issue with the SCEI buildbots, and that hid the

r342569 - test: improve condition for the check

2018-09-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Sep 19 11:41:07 2018 New Revision: 342569 URL: http://llvm.org/viewvc/llvm-project?rev=342569=rev Log: test: improve condition for the check When the type of `wint_t` is `int`, the promotion will allow this to pass. Check this explicitly rather than using the size.

r342565 - Sema: handle `wint_t` more carefully for printf checking

2018-09-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Sep 19 11:13:34 2018 New Revision: 342565 URL: http://llvm.org/viewvc/llvm-project?rev=342565=rev Log: Sema: handle `wint_t` more carefully for printf checking In the case that `win_t` is an `unsigned short` (e.g. on Windows), we would previously incorrectly diagnose

r342557 - Basic: correct `__WINT_TYPE__` on Windows

2018-09-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Sep 19 09:18:55 2018 New Revision: 342557 URL: http://llvm.org/viewvc/llvm-project?rev=342557=rev Log: Basic: correct `__WINT_TYPE__` on Windows Windows uses `unsigned short` for `wint_t`. Correct the type definition as vended by the compiler. This type is defined in

r342515 - Driver: extract a local variable for the Toolchain (NFC)

2018-09-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 18 15:14:50 2018 New Revision: 342515 URL: http://llvm.org/viewvc/llvm-project?rev=342515=rev Log: Driver: extract a local variable for the Toolchain (NFC) Create and store a reference to the current toolchain rather than calling `getToolChain` throughout the

r342512 - Driver: hoist `-mlimit-float-precision` (NFC)

2018-09-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 18 14:12:39 2018 New Revision: 342512 URL: http://llvm.org/viewvc/llvm-project?rev=342512=rev Log: Driver: hoist `-mlimit-float-precision` (NFC) Move the floating point argument handling into the RenderFloatingPointOptions helper. This relocation just puts the

r341877 - clang-check: rename the local FixItAction

2018-09-10 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Sep 10 15:57:26 2018 New Revision: 341877 URL: http://llvm.org/viewvc/llvm-project?rev=341877=rev Log: clang-check: rename the local FixItAction Resolve the ambiguity in the FixItAction definition by renaming the type. With Xcode 9.2, you would fail to build this

r340228 - libclang: add install/distribution targets for python

2018-08-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Aug 20 15:50:18 2018 New Revision: 340228 URL: http://llvm.org/viewvc/llvm-project?rev=340228=rev Log: libclang: add install/distribution targets for python Add installation support for the python bindings for libclang. Add an additional CMake configuration variable

r332821 - Sema: diagnose invalid catch parameter in ObjC

2018-05-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun May 20 12:26:44 2018 New Revision: 332821 URL: http://llvm.org/viewvc/llvm-project?rev=332821=rev Log: Sema: diagnose invalid catch parameter in ObjC Ensure that the type being used has an associated interface when declaring the parameter for `@catch`. Resolves

r331296 - Driver: fix an assertion with `-print-prog-name=`

2018-05-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue May 1 11:40:42 2018 New Revision: 331296 URL: http://llvm.org/viewvc/llvm-project?rev=331296=rev Log: Driver: fix an assertion with `-print-prog-name=` Fix an assertion when -print-prog-name= is invoked without parameter. Returns an empty string. Patch by Christian

r330378 - Implement proper support for `-falign-functions`

2018-04-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Apr 19 16:14:57 2018 New Revision: 330378 URL: http://llvm.org/viewvc/llvm-project?rev=330378=rev Log: Implement proper support for `-falign-functions` This implements support for the previously ignored flag `-falign-functions`. This allows the frontend to request

[libcxx] r330045 - support: add missing locale stubs for android L, M

2018-04-13 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Apr 13 11:14:57 2018 New Revision: 330045 URL: http://llvm.org/viewvc/llvm-project?rev=330045=rev Log: support: add missing locale stubs for android L, M The strto* family was introduced in android O (API Level 26). However, the support headers were adjusted to

r329866 - Lex: make `clang::Preprocessor::macros` work on MSVC

2018-04-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Apr 11 16:47:25 2018 New Revision: 329866 URL: http://llvm.org/viewvc/llvm-project?rev=329866=rev Log: Lex: make `clang::Preprocessor::macros` work on MSVC The order of argument construction is reversed on MS ABI on Windows. When `macros` was invoked, the `end` call is

r329025 - CodeGenCXX: support PreserveMostCC in MS ABI

2018-04-02 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Apr 2 15:25:50 2018 New Revision: 329025 URL: http://llvm.org/viewvc/llvm-project?rev=329025=rev Log: CodeGenCXX: support PreserveMostCC in MS ABI Microsoft has reserved 'U' for the PreserveMostCC which is used in the swift runtime. Add support for this. This allows

r328007 - Basic: support PreserveMost and PreserveAll on Windows ARM

2018-03-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Mar 20 10:33:26 2018 New Revision: 328007 URL: http://llvm.org/viewvc/llvm-project?rev=328007=rev Log: Basic: support PreserveMost and PreserveAll on Windows ARM Do not ignore these calling conventions on Windows ARM. They are used by the swift runtime for certain

r327183 - test: repair windows build after SVN r327105

2018-03-09 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Mar 9 15:00:29 2018 New Revision: 327183 URL: http://llvm.org/viewvc/llvm-project?rev=327183=rev Log: test: repair windows build after SVN r327105 Thanks to Nico Weber for pointing out the failure. Add an explicit target for the test. Modified:

r327105 - CodeGen: simplify and validate exception personalities

2018-03-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Mar 8 23:06:42 2018 New Revision: 327105 URL: http://llvm.org/viewvc/llvm-project?rev=327105=rev Log: CodeGen: simplify and validate exception personalities Simplify the dispatching for the personality routines. This really had no test coverage previously, so add

r326469 - Driver: hoist `-fno-rtti-data` to a driver flag

2018-03-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Mar 1 11:13:43 2018 New Revision: 326469 URL: http://llvm.org/viewvc/llvm-project?rev=326469=rev Log: Driver: hoist `-fno-rtti-data` to a driver flag This is needed for building with the GNU driver (`clang++`) when targeting Windows and using msvcprt. This flag is

r326362 - CodeGenObjCXX: handle inalloca appropriately for msgSend variant

2018-02-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Feb 28 12:16:12 2018 New Revision: 326362 URL: http://llvm.org/viewvc/llvm-project?rev=326362=rev Log: CodeGenObjCXX: handle inalloca appropriately for msgSend variant objc_msgSend_stret takes a hidden parameter for the returned structure's address for the

r325724 - CodeGen: handle blocks correctly when inalloca'ed

2018-02-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Feb 21 13:47:51 2018 New Revision: 325724 URL: http://llvm.org/viewvc/llvm-project?rev=325724=rev Log: CodeGen: handle blocks correctly when inalloca'ed When using blocks with C++ on Windows x86, it is possible to have the block literal be pushed into the inalloca'ed

r324701 - AST: support ObjC lifetime qualifiers in MS ABI

2018-02-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Feb 8 19:23:54 2018 New Revision: 324701 URL: http://llvm.org/viewvc/llvm-project?rev=324701=rev Log: AST: support ObjC lifetime qualifiers in MS ABI Adjust the ObjC protocol conformance workaround to be more extensible. Use a synthetic type for the protocol (`struct

Re: r324439 - AST: support SwiftCC on MS ABI

2018-02-06 Thread Saleem Abdulrasool via cfe-commits
On Tue, Feb 6, 2018 at 5:55 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Tue Feb 6 17:55:08 2018 > New Revision: 324439 > > URL: http://llvm.org/viewvc/llvm-project?rev=324439=rev > Log: > AST: support SwiftCC

[clang-tools-extra] r324441 - test: use target triple for the test

2018-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Feb 6 18:27:34 2018 New Revision: 324441 URL: http://llvm.org/viewvc/llvm-project?rev=324441=rev Log: test: use target triple for the test Now that `pragma comment` is also used on ELF-ish targets with a restricted set of options, we need to specify the full target

r324439 - AST: support SwiftCC on MS ABI

2018-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Feb 6 17:55:08 2018 New Revision: 324439 URL: http://llvm.org/viewvc/llvm-project?rev=324439=rev Log: AST: support SwiftCC on MS ABI Microsoft has reserved the identifier 'S' as the swift calling convention. Decorate the symbols appropriately. This enables swift on

r324438 - Support `#pragma comment(lib, "name")` in the frontend for ELF

2018-02-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Feb 6 17:46:46 2018 New Revision: 324438 URL: http://llvm.org/viewvc/llvm-project?rev=324438=rev Log: Support `#pragma comment(lib, "name")` in the frontend for ELF This adds the frontend support required to support the use of the comment pragma to enable auto linking

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

2018-02-02 Thread Saleem Abdulrasool via cfe-commits
nd and backend passes insert >> instructions between the call to the function returning an object and the >> call to objc_retainAutoreleasedReturnValue. We probably should find a way to >> prevent inserting instructions between the calls (maybe using instruction >> bundles)

Re: r294872 - CodeGen: annotate ObjC ARC functions with ABI constraints

2018-01-30 Thread Saleem Abdulrasool via cfe-commits
ing > instruction bundles), but we haven’t had the time to implement the fix. > Feel free to fix the bug if you’d like to do so. > > > On Feb 11, 2017, at 1:34 PM, Saleem Abdulrasool via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: compnerd

r323547 - AST: support protocol conformances on id/class/interfaces in MS ABI

2018-01-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Jan 26 11:08:26 2018 New Revision: 323547 URL: http://llvm.org/viewvc/llvm-project?rev=323547=rev Log: AST: support protocol conformances on id/class/interfaces in MS ABI Add support for mangling ObjC protocol conformances in MS ABI as if they are COM interfaces. By

r323461 - AST: inline a single-use variable (NFC)

2018-01-25 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Jan 25 11:54:31 2018 New Revision: 323461 URL: http://llvm.org/viewvc/llvm-project?rev=323461=rev Log: AST: inline a single-use variable (NFC) Inline the single use variable into the only use. NFC. Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp Modified:

r323257 - AST: correct mangling for SEL on MS ABI

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 12:56:52 2018 New Revision: 323257 URL: http://llvm.org/viewvc/llvm-project?rev=323257=rev Log: AST: correct mangling for SEL on MS ABI We would previously treat `SEL` as a pointer-only type. This is not the case. It should be treated similarly to `id` and

r323247 - CodeGen: use `llvm.used` for ObjC protocols

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 11:35:51 2018 New Revision: 323247 URL: http://llvm.org/viewvc/llvm-project?rev=323247=rev Log: CodeGen: use `llvm.used` for ObjC protocols These symbols are supposed to be preserved even by the linker. Use the `llvm.used` to ensure that the symbols are not

r323241 - AST: adjust ObjC MS mangling to work with typedefs

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 11:17:25 2018 New Revision: 323241 URL: http://llvm.org/viewvc/llvm-project?rev=323241=rev Log: AST: adjust ObjC MS mangling to work with typedefs Rather than hardcode the pointerness of the `id` and `class` types, handle them generically. This allows for the

r323230 - test: simplify the matching logic a bit (NFC)

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 09:57:04 2018 New Revision: 323230 URL: http://llvm.org/viewvc/llvm-project?rev=323230=rev Log: test: simplify the matching logic a bit (NFC) Use CHECK-SAME directives to simplify the test conditions a bit. This makes it easier to see what is being checked.

r323225 - test: adjust the target for some Windows tests

2018-01-23 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Jan 23 09:05:57 2018 New Revision: 323225 URL: http://llvm.org/viewvc/llvm-project?rev=323225=rev Log: test: adjust the target for some Windows tests The tests are targeting Windows but do not specify an environment. When executed on Linux, they would use an ELF

[libcxx] r321937 - Correct mistake in pragma usage for Windows

2018-01-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Jan 6 10:47:03 2018 New Revision: 321937 URL: http://llvm.org/viewvc/llvm-project?rev=321937=rev Log: Correct mistake in pragma usage for Windows The autolink pragma was missing the pragma name itself. This would result in the pragma being silently dropped.

[libcxx] r319816 - Enable auto-linking on Windows

2017-12-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Dec 5 11:32:49 2017 New Revision: 319816 URL: http://llvm.org/viewvc/llvm-project?rev=319816=rev Log: Enable auto-linking on Windows The MSVC driver and clang do not link against the C++ runtime explicitly. Instead, they rely on the auto-linking via the pragma

r318609 - Driver: remove `SupportsObjCGC` (NFC)

2017-11-18 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Nov 18 16:45:33 2017 New Revision: 318609 URL: http://llvm.org/viewvc/llvm-project?rev=318609=rev Log: Driver: remove `SupportsObjCGC` (NFC) This option is not used in the frontend. Remove the method. Modified: cfe/trunk/include/clang/Driver/ToolChain.h

r317146 - CodeGen: simplify EH personality selection (NFC)

2017-11-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Nov 1 17:25:40 2017 New Revision: 317146 URL: http://llvm.org/viewvc/llvm-project?rev=317146=rev Log: CodeGen: simplify EH personality selection (NFC) Fix a typo in the comment, reorder to ensure that the ordering matches across the ObjC/ObjC++ cases. NFCI.

r316858 - Driver: default to `unsigned int` `wchar_t` for ARM

2017-10-29 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Oct 28 23:01:14 2017 New Revision: 316858 URL: http://llvm.org/viewvc/llvm-project?rev=316858=rev Log: Driver: default to `unsigned int` `wchar_t` for ARM AAPCS and AAPCS64 mandate that `wchar_t` with `-fno-short-wchar` is an `unsigned int` rather than a `signed int`.

r316826 - Basic: improve coverage for Darwin targets and fix ABI

2017-10-28 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 27 23:00:43 2017 New Revision: 316826 URL: http://llvm.org/viewvc/llvm-project?rev=316826=rev Log: Basic: improve coverage for Darwin targets and fix ABI The existing coverage for the Darwin targets wasn't enough to catch all the variations. Improve the coverage a

r316810 - ARM: centralise SizeType, PtrDiffType, and IntPtrType

2017-10-27 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 27 16:04:27 2017 New Revision: 316810 URL: http://llvm.org/viewvc/llvm-project?rev=316810=rev Log: ARM: centralise SizeType, PtrDiffType, and IntPtrType Centralise the definitions of these compiler vended types to aid inspection to ensure that they are defined

Re: r316046 - Basic: fix __{,U}INTPTR_TYPE__ on ARM

2017-10-25 Thread Saleem Abdulrasool via cfe-commits
On Fri, Oct 20, 2017 at 11:56 AM, Friedman, Eli <efrie...@codeaurora.org> wrote: > On 10/17/2017 5:00 PM, Saleem Abdulrasool via cfe-commits wrote: > >> Author: compnerd >> Date: Tue Oct 17 17:00:50 2017 >> New Revision: 316046 >> >> URL: http://llvm.org

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-25 Thread Saleem Abdulrasool via cfe-commits
Sure, I’ll add a release note. The type for the -fno-short-wchar shouldn’t have changed on ARM. That sounds like a mistake. We could just promote the -fsigned-wchar to a driver level flag. Every target seems to use signed int, not unsigned int for wchar_t. On Wed, Oct 25, 2017 at 1:32 PM

r316599 - CodeGen: fix PPC Darwin variadics

2017-10-25 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Oct 25 10:56:50 2017 New Revision: 316599 URL: http://llvm.org/viewvc/llvm-project?rev=316599=rev Log: CodeGen: fix PPC Darwin variadics Darwin uses char * for the variadic list type (va_list). We use the PPC SVR4 ABI for PPC, which uses a structure type for the

r316545 - CodeGen: fix a case of incorrect checks for ivars

2017-10-24 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Oct 24 20:58:15 2017 New Revision: 316545 URL: http://llvm.org/viewvc/llvm-project?rev=316545=rev Log: CodeGen: fix a case of incorrect checks for ivars Ensure that we check the ivar containing decl for the DLL storage attribute rather than the ivar itself as the dll

Re: Attribute spelling policy

2017-10-22 Thread Saleem Abdulrasool via cfe-commits
Very much a +1 on having attributes map in via `__attribute__` and `[[clang::]]` uniformly when appropriate. On Sat, Oct 21, 2017 at 8:14 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Attributes come with multiple spelling flavors, but when it comes to > adding new

[libunwind] r316224 - GNU: do not read the FDE count if omitted

2017-10-20 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 20 11:47:35 2017 New Revision: 316224 URL: http://llvm.org/viewvc/llvm-project?rev=316224=rev Log: GNU: do not read the FDE count if omitted If there is no binary search table computed, the FDECount encoding is DW_EH_PE_omit. Do not attempt to read the FDECount in

r316204 - Basic: restore {,u}intptr_t on NetBSD/ARM

2017-10-19 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Oct 19 21:11:28 2017 New Revision: 316204 URL: http://llvm.org/viewvc/llvm-project?rev=316204=rev Log: Basic: restore {,u}intptr_t on NetBSD/ARM NetBSD uses `long int` for `intptr_t` on ARM. This was changed in SVN r316046, referenced against other compilers.

r316046 - Basic: fix __{,U}INTPTR_TYPE__ on ARM

2017-10-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Oct 17 17:00:50 2017 New Revision: 316046 URL: http://llvm.org/viewvc/llvm-project?rev=316046=rev Log: Basic: fix __{,U}INTPTR_TYPE__ on ARM Darwin and OpenBSD are the only platforms which use `long int` for `__INTPTR_TYPE__`. The other platforms use `int` in 32-bit,

r316042 - Basic: fix `__INTPTR_TYPE__` for Windows ARM

2017-10-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Oct 17 15:49:53 2017 New Revision: 316042 URL: http://llvm.org/viewvc/llvm-project?rev=316042=rev Log: Basic: fix `__INTPTR_TYPE__` for Windows ARM The `IntPtrType` for Windows ARM should be `int` as per MSVC. Adjust the type accordingly. Modified:

r316013 - Sema: use new `getNS{,U}IntegerType` for NS{,U}Integer

2017-10-17 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Oct 17 10:39:32 2017 New Revision: 316013 URL: http://llvm.org/viewvc/llvm-project?rev=316013=rev Log: Sema: use new `getNS{,U}IntegerType` for NS{,U}Integer Use the new helper methods to get the underlying type for NSUInteger, NSInteger types. This avoids spreading

r315968 - Basic: make the nan family pure

2017-10-16 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Oct 16 20:30:25 2017 New Revision: 315968 URL: http://llvm.org/viewvc/llvm-project?rev=315968=rev Log: Basic: make the nan family pure The nan family of math routines do not rely on global state. They do however depend on their parameter. This fits the description of

Re: r315856 - Add -f[no-]double-square-bracket-attributes as new driver options to control use of [[]] attributes in all language modes. This is the initial implementation of WG14 N2165, which is a pr

2017-10-15 Thread Saleem Abdulrasool via cfe-commits
On Sun, Oct 15, 2017 at 8:01 AM, Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aaronballman > Date: Sun Oct 15 08:01:42 2017 > New Revision: 315856 > > URL: http://llvm.org/viewvc/llvm-project?rev=315856=rev > Log: > Add -f[no-]double-square-bracket-attributes as

r315741 - Basic: adjust attributes on `nan` LIBBUILTINs

2017-10-13 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 13 13:07:30 2017 New Revision: 315741 URL: http://llvm.org/viewvc/llvm-project?rev=315741=rev Log: Basic: adjust attributes on `nan` LIBBUILTINs The `nan` family of functions will inspect the contents of the parameter that they are passed. As a result, the function

r315126 - Driver: hoist the `wchar_t` handling to the driver

2017-10-06 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Oct 6 16:09:55 2017 New Revision: 315126 URL: http://llvm.org/viewvc/llvm-project?rev=315126=rev Log: Driver: hoist the `wchar_t` handling to the driver Move the logic for determining the `wchar_t` type information into the driver. Rather than passing the single bit

[libunwind] r314834 - build: use POSITION_INDEPENDENT_CODE instead of -fPIC

2017-10-03 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Oct 3 13:22:26 2017 New Revision: 314834 URL: http://llvm.org/viewvc/llvm-project?rev=314834=rev Log: build: use POSITION_INDEPENDENT_CODE instead of -fPIC Rather than hardcode the flag and check if the compiler supports it, use the CMake property to get the right

[libunwind] r314632 - SjLj: make the SjLj implementation more portable

2017-10-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sun Oct 1 13:06:48 2017 New Revision: 314632 URL: http://llvm.org/viewvc/llvm-project?rev=314632=rev Log: SjLj: make the SjLj implementation more portable This moves the definition of the internal helpers `__Unwind_SjLj_GetTopOfFunctionStack` and

r314241 - Sema: rename SemaBuiltinVAStart to SemaBuiltinVAStartMicrosoft

2017-09-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 26 13:12:04 2017 New Revision: 314241 URL: http://llvm.org/viewvc/llvm-project?rev=314241=rev Log: Sema: rename SemaBuiltinVAStart to SemaBuiltinVAStartMicrosoft This function is used to perform semantic analysis on Microsoft style `__va_start`. Rename it to make

r314236 - Basic: support Preserve{Most,All} CC on Windows

2017-09-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 26 12:26:01 2017 New Revision: 314236 URL: http://llvm.org/viewvc/llvm-project?rev=314236=rev Log: Basic: support Preserve{Most,All} CC on Windows Add support for the `preserve_mostcc` and `preserve_allcc` on Windows x86_64 and AArch64. This is used by Swift.

Re: r314226 - Sema: Windows/ARM __va_start is not const correct

2017-09-26 Thread Saleem Abdulrasool via cfe-commits
LL_MS_LANGUAGES`. I suppoes that it would be better to rename the function to `SemaBuiltinVAStartARMMicrosoft`. Actually, I like this much better, I'll rename it. > On Tue, Sep 26, 2017 at 10:44 AM, Saleem Abdulrasool via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >>

r314009 - bindings: expose Linkage to the python bindings

2017-09-22 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Sep 22 11:35:09 2017 New Revision: 314009 URL: http://llvm.org/viewvc/llvm-project?rev=314009=rev Log: bindings: expose Linkage to the python bindings Add Python bindings for the 'clang_getCursorLinkage', and tests to validate the functionality. Patch by Masud Rahman!

r313954 - Driver: remove support for libstdc++ from CrossWindows

2017-09-21 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Sep 21 21:01:12 2017 New Revision: 313954 URL: http://llvm.org/viewvc/llvm-project?rev=313954=rev Log: Driver: remove support for libstdc++ from CrossWindows This code path is entirely untested and not really maintained. The expected use here is with libc++ only.

[libcxx] r313344 - typeinfo: provide a partial implementation for Win32

2017-09-14 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Sep 14 22:42:39 2017 New Revision: 313344 URL: http://llvm.org/viewvc/llvm-project?rev=313344=rev Log: typeinfo: provide a partial implementation for Win32 The RTTI structure is different on Windows when building under MS ABI. Update the definition to reflect this. The

r313111 - libclang: expose `clang_getCursorTLSKind`

2017-09-12 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 12 19:15:09 2017 New Revision: 313111 URL: http://llvm.org/viewvc/llvm-project?rev=313111=rev Log: libclang: expose `clang_getCursorTLSKind` Introduce the 'TLS Kind' property of variable declarations through libclang. Additionally, provide a Python accessor for it,

r312941 - Driver: default to `-fno-use-cxatexit` on Windows

2017-09-11 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Mon Sep 11 13:18:09 2017 New Revision: 312941 URL: http://llvm.org/viewvc/llvm-project?rev=312941=rev Log: Driver: default to `-fno-use-cxatexit` on Windows This primarily impacts the Windows MSVC and Windows itanium environments. Windows MSVC does not use `__cxa_atexit`

r312835 - CodeGen: correct arguments for NSFastEnumeration

2017-09-08 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Sep 8 16:41:17 2017 New Revision: 312835 URL: http://llvm.org/viewvc/llvm-project?rev=312835=rev Log: CodeGen: correct arguments for NSFastEnumeration When performing a NSFastEnumeration, the compiler synthesizes a call to `countByEnumeratingWithState:objects:count:`

r312618 - Driver: delete some dead code (NFC)

2017-09-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 5 22:11:19 2017 New Revision: 312618 URL: http://llvm.org/viewvc/llvm-project?rev=312618=rev Log: Driver: delete some dead code (NFC) This code has been `#if 0`'ed out for a very long time. After speaking with Duncan, opt to remove it even if it is something

r312616 - Driver: remove unused variable (NFC)

2017-09-05 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 5 21:56:23 2017 New Revision: 312616 URL: http://llvm.org/viewvc/llvm-project?rev=312616=rev Log: Driver: remove unused variable (NFC) Remove `IsHosted` which is no longer needed in `RenderSSPOptions` after SVN r312595. The single use can now be inlined. NFC

r312436 - Driver; extract target specific option application (NFC)

2017-09-02 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Sep 2 21:47:00 2017 New Revision: 312436 URL: http://llvm.org/viewvc/llvm-project?rev=312436=rev Log: Driver; extract target specific option application (NFC) Extract the target specific option application. This is a huge switch which was inlined into the

r312435 - Driver: extract debugging related options (NFC)

2017-09-02 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Sep 2 21:46:59 2017 New Revision: 312435 URL: http://llvm.org/viewvc/llvm-project?rev=312435=rev Log: Driver: extract debugging related options (NFC) Out-of-line the logic for selecting the debug information handling. This is still split across the new function and

r312434 - Driver: move `-mfpmath` into FP Options (NFC)

2017-09-02 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Sat Sep 2 21:46:57 2017 New Revision: 312434 URL: http://llvm.org/viewvc/llvm-project?rev=312434=rev Log: Driver: move `-mfpmath` into FP Options (NFC) Move the `-mfpmath` handling with the rest of the floating point optimization flags. Modified:

r312392 - Driver: extract `-fbuiltin` option handling (NFC)

2017-09-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Sep 1 16:44:01 2017 New Revision: 312392 URL: http://llvm.org/viewvc/llvm-project?rev=312392=rev Log: Driver: extract `-fbuiltin` option handling (NFC) Extract the handling of the `-fbuiltin` family of flags to the driver. This centralises the handling of those

r312385 - Driver: extract floating point optimization handling (NFC)

2017-09-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Sep 1 15:04:24 2017 New Revision: 312385 URL: http://llvm.org/viewvc/llvm-project?rev=312385=rev Log: Driver: extract floating point optimization handling (NFC) Extract the logic for the floating point handling into its own function. None of this information is needed

r312351 - Driver: extract diagnostics flag handling (NFC)

2017-09-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Sep 1 11:57:34 2017 New Revision: 312351 URL: http://llvm.org/viewvc/llvm-project?rev=312351=rev Log: Driver: extract diagnostics flag handling (NFC) Extract a function to render the diagnostics options to the clang frontend. This continues the simplification of the

r312344 - Driver: extract ObjC option rendering (NFC)

2017-09-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Sep 1 10:43:59 2017 New Revision: 312344 URL: http://llvm.org/viewvc/llvm-project?rev=312344=rev Log: Driver: extract ObjC option rendering (NFC) Extract the ObjC option rendering for the frontend. This localises the option translation. It augments the existing

r312330 - Driver: extract modules flag handling (NFC)

2017-09-01 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Fri Sep 1 08:25:17 2017 New Revision: 312330 URL: http://llvm.org/viewvc/llvm-project?rev=312330=rev Log: Driver: extract modules flag handling (NFC) Extract a function to render the options related to modules. This reduces the cyclomatic complexity of the `ConstructJob`

r312244 - Driver: extract ARCMT flag construction (NFC)

2017-08-31 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Thu Aug 31 08:35:01 2017 New Revision: 312244 URL: http://llvm.org/viewvc/llvm-project?rev=312244=rev Log: Driver: extract ARCMT flag construction (NFC) Extract the ARC migration tool flag handling into its own function. This simplifies the flow of the clang frontend

r312124 - Driver: out-of-line static analyzer flag handling (NFC)

2017-08-30 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Wed Aug 30 07:18:08 2017 New Revision: 312124 URL: http://llvm.org/viewvc/llvm-project?rev=312124=rev Log: Driver: out-of-line static analyzer flag handling (NFC) Extract the analyzer flag handling into its own function to reduce the overall complexity of the construction

  1   2   3   4   5   6   >