[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf sivachandra wrote: I think it was removed because it is listed on line 130 also.

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -9,15 +9,57 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H +#include "src/__support/File/file.h" #include "src/__support/arg_list.h" +#include "src/stdio/scanf_core/reader.h" +#include

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -220,6 +220,20 @@ add_libc_test( libc.src.stdio.vprintf ) + +if(LLVM_LIBC_FULL_BUILD) + # In fullbuild mode, fscanf's tests use the internal FILE for other functions. + list(APPEND fscanf_test_deps + libc.src.stdio.fclose + libc.src.stdio.ferror +

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/sivachandra edited https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/sivachandra commented: Few nits, but otherwise OK. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/sivachandra edited https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/sivachandra commented: Few nits, but otherwise OK. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -9,15 +9,57 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_VFSCANF_INTERNAL_H +#include "src/__support/File/file.h" #include "src/__support/arg_list.h" +#include "src/stdio/scanf_core/reader.h" +#include

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf sivachandra wrote: I think it was removed because it is listed on line 130 also.

[clang-tools-extra] [libc] Fix printf config not working (PR #66834)

@@ -112,6 +112,16 @@ add_libc_unittest( LibcMemoryHelpers ) +if(LIBC_CONF_PRINTF_DISABLE_FLOAT) sivachandra wrote: I do not think this pattern is how the copts are to be used. In this particular case, I think the right way would be to split

[clang] [libc] Fix printf config not working (PR #66834)

@@ -112,6 +112,16 @@ add_libc_unittest( LibcMemoryHelpers ) +if(LIBC_CONF_PRINTF_DISABLE_FLOAT) sivachandra wrote: I do not think this pattern is how the copts are to be used. In this particular case, I think the right way would be to split

[clang] remove common libc tuners (PR #66136)

https://github.com/sivachandra closed https://github.com/llvm/llvm-project/pull/66136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] remove common libc tuners (PR #66136)

https://github.com/sivachandra updated https://github.com/llvm/llvm-project/pull/66136: >From d1a9fda20a2be37385b44dcbf2f73b1890fa7d78 Mon Sep 17 00:00:00 2001 From: Siva Chandra Reddy Date: Tue, 12 Sep 2023 05:42:37 + Subject: [PATCH 1/3] [libc][NFC] Make entrypoint alias targets real

Re: [PATCH] D97736: [Driver] Add a experimental option to link to LLVM libc.

On Sat, Mar 13, 2021 at 9:36 AM Eric Christopher wrote: > > > On Fri, Mar 5, 2021 at 1:15 AM Siva Chandra via Phabricator < > revi...@reviews.llvm.org> wrote: > >> sivachandra added a comment. >> >> In D97736#2605535 , @phosek >> wrote: >> >> > Have you

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

On Mon, Oct 12, 2020 at 10:01 PM Galina Kistanova via lldb-commits wrote: > If somebody else could move their AnnotatedCommand bots to the staging area, > that would be much appreciated. I moved the libc bots to staging to now. Thanks, Siva Chandra

r361312 - Let -static-pie win if it is specified along with -pie or -static.

Author: sivachandra Date: Tue May 21 14:09:05 2019 New Revision: 361312 URL: http://llvm.org/viewvc/llvm-project?rev=361312=rev Log: Let -static-pie win if it is specified along with -pie or -static. Also, disallow specifying -no-pie/-nopie along with -static-pie. Differential Revision:

r354502 - [Clang Driver] Add support for "-static-pie" argument to the Clang driver.

Author: sivachandra Date: Wed Feb 20 11:07:04 2019 New Revision: 354502 URL: http://llvm.org/viewvc/llvm-project?rev=354502=rev Log: [Clang Driver] Add support for "-static-pie" argument to the Clang driver. Summary: This change mimics GCC's support for the "-static-pie" argument. Subscribers:

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. Thanks for the review; Committed. http://reviews.llvm.org/D21666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. Ping. http://reviews.llvm.org/D21666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61851. sivachandra added a comment. Improve global type handling. http://reviews.llvm.org/D21666 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/QualTypeNames.cpp unittests/Tooling/QualTypeNamesTest.cpp Index:

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added a comment. PTAL Comment at: lib/Tooling/Core/QualTypeNames.cpp:435 @@ -399,1 +434,3 @@ + // Create a nested name specifier if needed. Prefix = createNestedNameSpecifierForScopeOf(Ctx, QT.getTypePtr(), + true

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61837. sivachandra added a comment. Address comments. http://reviews.llvm.org/D21666 Files: include/clang/Tooling/Core/QualTypeNames.h lib/Tooling/Core/QualTypeNames.cpp unittests/Tooling/QualTypeNamesTest.cpp Index:

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra added inline comments. Comment at: lib/Tooling/Core/QualTypeNames.cpp:405 @@ -398,3 +404,3 @@ // is not the global scope. Prefix = createNestedNameSpecifierForScopeOf(Ctx, QT.getTypePtr(), true /*FullyQualified*/);

Re: [PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra updated this revision to Diff 61821. sivachandra added a comment. A little adjustment. http://reviews.llvm.org/D21666 Files: include/clang/AST/NestedNameSpecifier.h include/clang/Tooling/Core/QualTypeNames.h lib/AST/NestedNameSpecifier.cpp lib/Tooling/Core/QualTypeNames.cpp

[PATCH] D21666: [Tooling] Add optional argument to getFullyQualifiedName to prepend "::".

sivachandra created this revision. sivachandra added reviewers: rnk, saugustine. sivachandra added a subscriber: cfe-commits. Herald added a subscriber: klimek. http://reviews.llvm.org/D21666 Files: include/clang/AST/NestedNameSpecifier.h include/clang/Tooling/Core/QualTypeNames.h