sjoerdmeijer wrote:
> LGTM, let's go ahead and merge this and get it backported to 19.x, thank you!
Thanks for your help with this.
I am mostly unfamiliar with the release process. Do you know how we can achieve
this? Do we suggest this commit to the release manager for a backport and
cherry
https://github.com/sjoerdmeijer closed
https://github.com/llvm/llvm-project/pull/101005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sjoerdmeijer wrote:
@AaronBallman, shall we merge this?
https://github.com/llvm/llvm-project/pull/101005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sjoerdmeijer updated
https://github.com/llvm/llvm-project/pull/101005
>From 22f2e40c6d44c562e97162f04dee055a1be57460 Mon Sep 17 00:00:00 2001
From: Sjoerd Meijer
Date: Mon, 29 Jul 2024 19:31:18 +0530
Subject: [PATCH] Ofast documentation deprecation clarifications
Following u
https://github.com/sjoerdmeijer edited
https://github.com/llvm/llvm-project/pull/101005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sjoerdmeijer approved this pull request.
Thanks for the quick fix.
This looks okay to me. But let's see if @DavidSpickett has more comments before
merging this.
https://github.com/llvm/llvm-project/pull/84485
___
cfe-commits maili
https://github.com/sjoerdmeijer approved this pull request.
This is a very big patch, but it makes a lot of sense. The idea to do it in
this way is clearly an improvement. There are quite a number of (new) moving
parts involved here, but look reasonable to me so let's give this is a try.
Tha
Author: Sjoerd Meijer
Date: 2022-10-25T15:08:15+05:30
New Revision: 9bd273047d4f66e3f36416acb295a3fd75bc6af4
URL:
https://github.com/llvm/llvm-project/commit/9bd273047d4f66e3f36416acb295a3fd75bc6af4
DIFF:
https://github.com/llvm/llvm-project/commit/9bd273047d4f66e3f36416acb295a3fd75bc6af4.diff
Author: Sjoerd Meijer
Date: 2022-10-24T17:36:24+05:30
New Revision: 9ec7448857c1bcbc9878e9912167d9453d3be673
URL:
https://github.com/llvm/llvm-project/commit/9ec7448857c1bcbc9878e9912167d9453d3be673
DIFF:
https://github.com/llvm/llvm-project/commit/9ec7448857c1bcbc9878e9912167d9453d3be673.diff
Author: Sjoerd Meijer
Date: 2021-02-19T09:18:35Z
New Revision: 260f90bb3d1aef90764de3506f86dedd1339e37c
URL:
https://github.com/llvm/llvm-project/commit/260f90bb3d1aef90764de3506f86dedd1339e37c
DIFF:
https://github.com/llvm/llvm-project/commit/260f90bb3d1aef90764de3506f86dedd1339e37c.diff
LOG:
Author: Sjoerd Meijer
Date: 2020-12-10T12:54:51Z
New Revision: 99ad078b91ed601cd19c75a44106a4f86bfa1a41
URL:
https://github.com/llvm/llvm-project/commit/99ad078b91ed601cd19c75a44106a4f86bfa1a41
DIFF:
https://github.com/llvm/llvm-project/commit/99ad078b91ed601cd19c75a44106a4f86bfa1a41.diff
LOG:
Author: Sjoerd Meijer
Date: 2020-10-02T12:47:23+01:00
New Revision: 8825fec37e73eea1bc3e4f5c125e1fd02d002d6c
URL:
https://github.com/llvm/llvm-project/commit/8825fec37e73eea1bc3e4f5c125e1fd02d002d6c
DIFF:
https://github.com/llvm/llvm-project/commit/8825fec37e73eea1bc3e4f5c125e1fd02d002d6c.diff
Author: Sjoerd Meijer
Date: 2020-07-22T09:47:53+01:00
New Revision: 5567c62afa559dc2f2604601ec9269f1e3fbfdab
URL:
https://github.com/llvm/llvm-project/commit/5567c62afa559dc2f2604601ec9269f1e3fbfdab
DIFF:
https://github.com/llvm/llvm-project/commit/5567c62afa559dc2f2604601ec9269f1e3fbfdab.diff
Author: Sjoerd Meijer
Date: 2020-07-17T22:42:12+01:00
New Revision: c2d69d8d62f2aac941453177e2ae872f5f82feda
URL:
https://github.com/llvm/llvm-project/commit/c2d69d8d62f2aac941453177e2ae872f5f82feda
DIFF:
https://github.com/llvm/llvm-project/commit/c2d69d8d62f2aac941453177e2ae872f5f82feda.diff
Author: Sjoerd Meijer
Date: 2020-07-16T16:14:47+01:00
New Revision: 0160ad802e899c2922bc9b29564080c22eb0908c
URL:
https://github.com/llvm/llvm-project/commit/0160ad802e899c2922bc9b29564080c22eb0908c
DIFF:
https://github.com/llvm/llvm-project/commit/0160ad802e899c2922bc9b29564080c22eb0908c.diff
Author: Sjoerd Meijer
Date: 2020-07-16T16:12:47+01:00
New Revision: 31248b4785c14e50c1694fc986c69afcea64bd81
URL:
https://github.com/llvm/llvm-project/commit/31248b4785c14e50c1694fc986c69afcea64bd81
DIFF:
https://github.com/llvm/llvm-project/commit/31248b4785c14e50c1694fc986c69afcea64bd81.diff
Author: Sjoerd Meijer
Date: 2020-07-16T15:38:36+01:00
New Revision: a7a07a8d63b2008750347932e351d479a45bfc2c
URL:
https://github.com/llvm/llvm-project/commit/a7a07a8d63b2008750347932e351d479a45bfc2c
DIFF:
https://github.com/llvm/llvm-project/commit/a7a07a8d63b2008750347932e351d479a45bfc2c.diff
Author: Sjoerd Meijer
Date: 2020-07-16T15:19:45+01:00
New Revision: 3a624c327adde62d075a4477e9bb9e6a2c186731
URL:
https://github.com/llvm/llvm-project/commit/3a624c327adde62d075a4477e9bb9e6a2c186731
DIFF:
https://github.com/llvm/llvm-project/commit/3a624c327adde62d075a4477e9bb9e6a2c186731.diff
Author: Sjoerd Meijer
Date: 2020-04-22T09:15:48+01:00
New Revision: 35cf2f42dda4d708741e06570b2dbe91cec4dc41
URL:
https://github.com/llvm/llvm-project/commit/35cf2f42dda4d708741e06570b2dbe91cec4dc41
DIFF:
https://github.com/llvm/llvm-project/commit/35cf2f42dda4d708741e06570b2dbe91cec4dc41.diff
Author: Sjoerd Meijer
Date: 2020-03-09T20:43:05Z
New Revision: e32f8ef9277dbaaeef1fbabe9505683ff5e35edf
URL:
https://github.com/llvm/llvm-project/commit/e32f8ef9277dbaaeef1fbabe9505683ff5e35edf
DIFF:
https://github.com/llvm/llvm-project/commit/e32f8ef9277dbaaeef1fbabe9505683ff5e35edf.diff
LOG:
Author: Sjoerd Meijer
Date: 2020-03-09T19:57:03Z
New Revision: 3d9a0445cce368b55dc3a573bc91fe902bbb977f
URL:
https://github.com/llvm/llvm-project/commit/3d9a0445cce368b55dc3a573bc91fe902bbb977f
DIFF:
https://github.com/llvm/llvm-project/commit/3d9a0445cce368b55dc3a573bc91fe902bbb977f.diff
LOG:
Author: Sjoerd Meijer
Date: 2020-03-09T10:37:28Z
New Revision: f35d112efdb33abee853aeab8a5ed4a4743e204d
URL:
https://github.com/llvm/llvm-project/commit/f35d112efdb33abee853aeab8a5ed4a4743e204d
DIFF:
https://github.com/llvm/llvm-project/commit/f35d112efdb33abee853aeab8a5ed4a4743e204d.diff
LOG:
Author: Sjoerd Meijer
Date: 2020-03-09T10:07:37Z
New Revision: 2c36c23f3476baf3b9283ea387c579419a70b112
URL:
https://github.com/llvm/llvm-project/commit/2c36c23f3476baf3b9283ea387c579419a70b112
DIFF:
https://github.com/llvm/llvm-project/commit/2c36c23f3476baf3b9283ea387c579419a70b112.diff
LOG:
Author: Sjoerd Meijer
Date: 2020-03-03T10:00:36Z
New Revision: 4e363563fa149321514389a031fa063e998d7422
URL:
https://github.com/llvm/llvm-project/commit/4e363563fa149321514389a031fa063e998d7422
DIFF:
https://github.com/llvm/llvm-project/commit/4e363563fa149321514389a031fa063e998d7422.diff
LOG:
Author: Sjoerd Meijer
Date: 2020-03-03T09:15:07Z
New Revision: 0a9fc9233e172601e26381810d093e02ef410f65
URL:
https://github.com/llvm/llvm-project/commit/0a9fc9233e172601e26381810d093e02ef410f65
DIFF:
https://github.com/llvm/llvm-project/commit/0a9fc9233e172601e26381810d093e02ef410f65.diff
LOG:
Author: Sjoerd Meijer
Date: 2019-12-11T10:37:40Z
New Revision: 021685491727e023aeae9ca272a2d6cd727e20e4
URL:
https://github.com/llvm/llvm-project/commit/021685491727e023aeae9ca272a2d6cd727e20e4
DIFF:
https://github.com/llvm/llvm-project/commit/021685491727e023aeae9ca272a2d6cd727e20e4.diff
LOG:
Hi All,
Apologies for the delay in responding, I was away from keyboard (llvm dev conf).
This is a real funny patch! It is a (simple) fix that uncovers quite a few
things. Anyway, thanks Michael for your analysis! As I will need to make some
changes this time (this wasn't the case last time), I
Author: sjoerdmeijer
Date: Mon Oct 14 00:40:36 2019
New Revision: 374756
URL: http://llvm.org/viewvc/llvm-project?rev=374756&view=rev
Log:
[docs] loop pragmas: options implying transformations
Following our discussion on the cfe dev list:
http://lists.llvm.org/pipermail/cfe-dev/2019-August/063054
Author: sjoerdmeijer
Date: Thu Oct 10 01:27:14 2019
New Revision: 374288
URL: http://llvm.org/viewvc/llvm-project?rev=374288&view=rev
Log:
Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"
This was further discussed at the llvm dev list:
http://lists.llvm.org/pipermail/llvm-d
is in r372225 as it broke the Chromium build. It seems
it doesn't actually manage to enable vectorization of a simple loop at
-Oz, and at -Os it asserts. See details in my commit message.
On Tue, Sep 17, 2019 at 10:41 AM Sjoerd Meijer via cfe-commits
wrote:
>
> Author: sjoerdmeijer
>
Author: sjoerdmeijer
Date: Tue Sep 17 01:43:11 2019
New Revision: 372082
URL: http://llvm.org/viewvc/llvm-project?rev=372082&view=rev
Log:
[Clang] Pragma vectorize_width() implies vectorize(enable)
Specifying the vectorization width was supposed to implicitly enable
vectorization, except that it
Author: sjoerdmeijer
Date: Thu Aug 15 00:39:05 2019
New Revision: 368976
URL: http://llvm.org/viewvc/llvm-project?rev=368976&view=rev
Log:
[clang] Loop pragma parsing. NFC.
Just a refactoring and a tidy up.
Differential Revision: https://reviews.llvm.org/D64564
Modified:
cfe/trunk/lib/Parse
Author: sjoerdmeijer
Date: Wed Aug 14 23:24:40 2019
New Revision: 368970
URL: http://llvm.org/viewvc/llvm-project?rev=368970&view=rev
Log:
[Clang] Pragma vectorize_predicate implies vectorize
New pragma "vectorize_predicate(enable)" now implies "vectorize(enable)",
and it is ignored when vectoriz
Author: sjoerdmeijer
Date: Thu Jul 25 00:33:13 2019
New Revision: 366989
URL: http://llvm.org/viewvc/llvm-project?rev=366989&view=rev
Log:
[Clang] New loop pragma vectorize_predicate
This adds a new vectorize predication loop hint:
#pragma clang loop vectorize_predicate(enable)
that can be us
Author: sjoerdmeijer
Date: Wed Jul 24 06:30:36 2019
New Revision: 366904
URL: http://llvm.org/viewvc/llvm-project?rev=366904&view=rev
Log:
Test commit. NFC.
Removed 2 trailing whitespaces in 2 files that used to be in different
repos to test my new github monorepo workflow.
Modified:
cfe/tru
Author: sjoerdmeijer
Date: Wed Jul 10 06:34:57 2019
New Revision: 365629
URL: http://llvm.org/viewvc/llvm-project?rev=365629&view=rev
Log:
Loop pragma parsing. NFC.
I would like to add some pragma handling here, but couldn't resist a little NFC
and tidy up first.
Differential Revision: https://r
Author: sjoerdmeijer
Date: Fri Jun 7 08:20:56 2019
New Revision: 362806
URL: http://llvm.org/viewvc/llvm-project?rev=362806&view=rev
Log:
[ARM] Add ACLE feature macros for MVE
If MVE is present at all, then the macro __ARM_FEATURE_MVE is defined
to a value which has bit 0 set for integer MVE, an
Author: sjoerdmeijer
Date: Wed Jun 5 06:12:01 2019
New Revision: 362601
URL: http://llvm.org/viewvc/llvm-project?rev=362601&view=rev
Log:
[ARM] Allow "-march=foo+fp" to vary with foo
Now, when clang processes an argument of the form "-march=foo+x+y+z",
then instead of calling getArchExtFeature()
Author: sjoerdmeijer
Date: Thu May 30 08:04:06 2019
New Revision: 362100
URL: http://llvm.org/viewvc/llvm-project?rev=362100&view=rev
Log:
Follow up of r362096
The new tests were failing, because I missed dependent patch D60697.
I have removed the failing cases for now, which I will restore once
Author: sjoerdmeijer
Date: Thu May 30 07:22:26 2019
New Revision: 362096
URL: http://llvm.org/viewvc/llvm-project?rev=362096&view=rev
Log:
[ARM] Add CLI support for Armv8.1-M and MVE
Given the existing infrastructure in LLVM side for +fp and +fp.dp,
this is more or less trivial, needing only one
Author: sjoerdmeijer
Date: Thu Oct 4 00:38:53 2018
New Revision: 343758
URL: http://llvm.org/viewvc/llvm-project?rev=343758&view=rev
Log:
[AArch64][ARM] Context sensitive meaning of crypto
For AArch64, crypto means:
- sm4 + sha3 + sha2 + aes for Armv8.4-A and up, and
- sha2 + aes for Armv8.3-A a
Author: sjoerdmeijer
Date: Mon Sep 24 00:55:20 2018
New Revision: 342862
URL: http://llvm.org/viewvc/llvm-project?rev=342862&view=rev
Log:
[ARM][AArch64] Add feature +fp16fml
Armv8.4-A adds a few FP16 instructions that can optionally be implemented
in CPUs of Armv8.2-A and above.
This patch adds
Author: sjoerdmeijer
Date: Thu Aug 9 07:07:27 2018
New Revision: 339347
URL: http://llvm.org/viewvc/llvm-project?rev=339347&view=rev
Log:
[AArch64][NFC] better matching of AArch64 target in aarch64-cpus.c tests
Differential Revision: https://reviews.llvm.org/D50175
Modified:
cfe/trunk/test/
Author: sjoerdmeijer
Date: Wed Aug 1 05:41:10 2018
New Revision: 338525
URL: http://llvm.org/viewvc/llvm-project?rev=338525&view=rev
Log:
[AArch64][ARM] Add Armv8.4-A tests
This adds tests for Armv8.4-A, and also some v8.2 and v8.3 tests that were
missing.
Differential Revision: https://reviews
Author: sjoerdmeijer
Date: Wed Jun 20 02:49:40 2018
New Revision: 335111
URL: http://llvm.org/viewvc/llvm-project?rev=335111&view=rev
Log:
[SPIR] Prevent SPIR targets from using half conversion intrinsics
The SPIR target currently allows for half precision floating point types to be
emitted using
Author: sjoerdmeijer
Date: Mon Mar 19 06:22:49 2018
New Revision: 327836
URL: http://llvm.org/viewvc/llvm-project?rev=327836&view=rev
Log:
[ARM] Pass half or i16 types for NEON intrinsics
For generating NEON intrinsics, this determines the NEON data type, and whether
it should be a half type or a
Author: sjoerdmeijer
Date: Thu Mar 15 06:36:30 2018
New Revision: 327623
URL: http://llvm.org/viewvc/llvm-project?rev=327623&view=rev
Log:
[AAch64] Tests for ACLE FP16 macros
This adds some missing tests for the AArch64 FP16 macros.
Differential Revision: https://reviews.llvm.org/D44512
Modifie
Author: sjoerdmeijer
Date: Tue Mar 13 15:11:06 2018
New Revision: 327455
URL: http://llvm.org/viewvc/llvm-project?rev=327455&view=rev
Log:
[ARM] ACLE FP16 feature test macros
This is a partial recommit of r327189 that was reverted
due to test issues. I.e., this recommits minimal functional
change
Author: sjoerdmeijer
Date: Tue Mar 13 12:38:56 2018
New Revision: 327437
URL: http://llvm.org/viewvc/llvm-project?rev=327437&view=rev
Log:
This reverts "r327189 - [ARM] Add ARMv8.2-A FP16 vector intrinsic"
This is causing problems in testing, and PR36683 was raised.
Reverting it until we have sor
Author: sjoerdmeijer
Date: Fri Feb 16 08:01:08 2018
New Revision: 325351
URL: http://llvm.org/viewvc/llvm-project?rev=325351&view=rev
Log:
[ARM] Add tests for the vcvtr builtins
This adds Sema and Codegen tests for the vcvtr builtins
(because they were missing).
Differential Revision: https://re
Author: sjoerdmeijer
Date: Tue Jan 23 02:13:49 2018
New Revision: 323185
URL: http://llvm.org/viewvc/llvm-project?rev=323185&view=rev
Log:
[ARM] Pass _Float16 as int or float
Pass and return _Float16 as if it were an int or float for ARM, but with the
top 16 bits unspecified, similarly like we al
Author: sjoerdmeijer
Date: Thu Dec 7 01:54:39 2017
New Revision: 320019
URL: http://llvm.org/viewvc/llvm-project?rev=320019&view=rev
Log:
[ARM] ACLE parallel arithmetic and DSP style multiplications
This is a follow up of r302131, in which we forgot to add SemaChecking
tests. Adding these tests
Author: sjoerdmeijer
Date: Tue Nov 7 02:09:45 2017
New Revision: 317558
URL: http://llvm.org/viewvc/llvm-project?rev=317558&view=rev
Log:
[docs] Add section 'Half-Precision Floating Point'
This documents the differences/interactions between _Float16 and __fp16
and is a companion change for the _
Author: sjoerdmeijer
Date: Wed Sep 13 08:23:19 2017
New Revision: 313152
URL: http://llvm.org/viewvc/llvm-project?rev=313152&view=rev
Log:
This adds the _Float16 preprocessor macro definitions.
Differential Revision: https://reviews.llvm.org/D34695
Added:
cfe/trunk/test/Headers/float16.c
Mod
Author: sjoerdmeijer
Date: Fri Sep 8 09:43:10 2017
New Revision: 312798
URL: http://llvm.org/viewvc/llvm-project?rev=312798&view=rev
Log:
Add _Float16 as a C/C++ source language type
Pacify the windows builder; fixed the new test as on Windows some additional
attributes are printed.
Modified:
Author: sjoerdmeijer
Date: Fri Sep 8 08:15:00 2017
New Revision: 312794
URL: http://llvm.org/viewvc/llvm-project?rev=312794&view=rev
Log:
Recommit "Add _Float16 as a C/C++ source language type"
This is a recommit of r312781; in some build configurations
variable names are omitted, so changed the
Author: sjoerdmeijer
Date: Fri Sep 8 03:20:52 2017
New Revision: 312784
URL: http://llvm.org/viewvc/llvm-project?rev=312784&view=rev
Log:
Revert "Add _Float16 as a C/C++ source language type"
The clang-with-lto-ubuntu bot didn't like the new regression
test, revert while I investigate the issue.
Author: sjoerdmeijer
Date: Fri Sep 8 02:42:32 2017
New Revision: 312781
URL: http://llvm.org/viewvc/llvm-project?rev=312781&view=rev
Log:
Add _Float16 as a C/C++ source language type
This adds _Float16 as a source language type, which is a 16-bit floating point
type defined in C11 extension ISO/
Author: sjoerdmeijer
Date: Fri Jun 30 01:07:34 2017
New Revision: 306805
URL: http://llvm.org/viewvc/llvm-project?rev=306805&view=rev
Log:
ARMV8-A archkind and target defines helper functions
This introduces helper functions that set target defines for different ARMV8-A
architecture kinds. It fix
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284121: Guard flag –fdenormal-fp-math with –fno-fast-math.
(authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D25479?vs=74363&id=74508#toc
Repository:
rL LLVM
https://revi
SjoerdMeijer added a comment.
thanks again for reviewing.
https://reviews.llvm.org/D25479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer updated this revision to Diff 74363.
SjoerdMeijer added a comment.
Thanks for catching this: the logic and test have been updated.
https://reviews.llvm.org/D25479
Files:
lib/Driver/Tools.cpp
test/Driver/denormal-fp-math.c
Index: test/Driver/denormal-fp-math.c
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: rengolin, jmolloy.
SjoerdMeijer added a subscriber: cfe-commits.
Guard the -fdenormal-fp-math with -fno-fast-math. This allows disabling the FP
options with just one flag: –fno-fast-math.
https://reviews.llvm.org/D25479
Files:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283109: This adds a separate file for the fp denormal
regression tests. NFC. (authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D24907?vs=72457&id=73411#toc
Repository:
rL
SjoerdMeijer abandoned this revision.
SjoerdMeijer added a comment.
Ok, thanks for the feedback and looking into this. I will abandon this change.
To still answer your question, there is nothing more to it than emitting an
AArch64 build attribute symbol (for library selection). This done based o
SjoerdMeijer added a comment.
Hi Hal,
Thanks for reviewing and you're right: this should work. We actually have
actually some downstream (aarch64) build attribute selection code that would
work better with this change. Are you okay with committing this change?
Cheers,
Sjoerd.
https://reviews.
Hi,
I just committed to Clang and noticed that the corresponding Phabricator ticket
does not get automatically closed (I have "Differential Revision:" in my commit
message and believe I didn't make a typo).
Is it just me, or is this is broken after the upgrade? For committing to LLVM
this still
Author: sjoerdmeijer
Date: Mon Oct 3 08:13:50 2016
New Revision: 283110
URL: http://llvm.org/viewvc/llvm-project?rev=283110&view=rev
Log:
This adds a separate file for the fp denormal regression tests. NFC.
I forgot to svn add the new file in my previous commit.
Added:
cfe/trunk/test/Driver
Author: sjoerdmeijer
Date: Mon Oct 3 08:12:20 2016
New Revision: 283109
URL: http://llvm.org/viewvc/llvm-project?rev=283109&view=rev
Log:
This adds a separate file for the fp denormal regression tests. NFC.
Differential Revision: https://reviews.llvm.org/D24907
Modified:
cfe/trunk/test/Driv
SjoerdMeijer added a comment.
Yes, excellent, I will rename it to denormal-fp-math.c and commit. Thanks for
reviewing!
https://reviews.llvm.org/D24907
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
SjoerdMeijer added a comment.
Ping
https://reviews.llvm.org/D24909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: rengolin, jmolloy, olista01.
SjoerdMeijer added a subscriber: cfe-commits.
This is a fix for not copying fp denormal and trapping options, and depends on
the nfc cleanups in D24906 and D24907.
https://reviews.llvm.org/D24909
File
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: rengolin, jmolloy, olista01.
SjoerdMeijer added a subscriber: cfe-commits.
For clarity, this moves checks for -fdenormal-fp-math values from fast-math.c
to a new separate file.
https://reviews.llvm.org/D24907
Files:
test/Driver
o Golin [mailto:renato.go...@linaro.org]
Sent: 23 September 2016 17:00
To: Sjoerd Meijer
Cc: Clang Commits
Subject: Re: r282255 - Fix for r280064 that added options for fp denormals and
exceptions.
On 23 September 2016 at 16:21, Sjoerd Meijer via cfe-commits
wrote:
> Author: sjoerdmeijer
> Date:
Author: sjoerdmeijer
Date: Fri Sep 23 10:37:17 2016
New Revision: 282257
URL: http://llvm.org/viewvc/llvm-project?rev=282257&view=rev
Log:
Revert of r282255 because of "Fell off the end of a string-switch" buildbot
failures.
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk
Author: sjoerdmeijer
Date: Fri Sep 23 10:21:33 2016
New Revision: 282255
URL: http://llvm.org/viewvc/llvm-project?rev=282255&view=rev
Log:
Fix for r280064 that added options for fp denormals and exceptions.
These options were forgotten to be copied in setCommandLineOpts.
Modified:
cfe/trunk/l
Author: sjoerdmeijer
Date: Wed Aug 31 07:31:03 2016
New Revision: 280227
URL: http://llvm.org/viewvc/llvm-project?rev=280227&view=rev
Log:
Revision r280064 adds new options -fdenormal-fp-math and passes through option
-ffast-math to CC1, but it included a wrong llvm regression tests which was
remo
Golin [mailto:renato.go...@linaro.org]
Sent: 31 August 2016 11:10
To: Sjoerd Meijer
Cc: Clang Commits; Diana Picus; James Molloy
Subject: Re: r280065 - Fix for commit 280064 that break the build.
On 30 August 2016 at 09:56, Sjoerd Meijer via cfe-commits
wrote:
> Author: sjoerdmeijer
> Date: Tue Aug
Author: sjoerdmeijer
Date: Tue Aug 30 03:56:00 2016
New Revision: 280065
URL: http://llvm.org/viewvc/llvm-project?rev=280065&view=rev
Log:
Fix for commit 280064 that break the build.
Modified:
cfe/trunk/test/Driver/fast-math.c
Modified: cfe/trunk/test/Driver/fast-math.c
URL:
http://llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280064: This adds new options -fdenormal-fp-math and passes
through option -ffast-math (authored by SjoerdMeijer).
Changed prior to commit:
https://reviews.llvm.org/D23840?vs=69379&id=69647#toc
Reposit
Author: sjoerdmeijer
Date: Tue Aug 30 03:09:45 2016
New Revision: 280064
URL: http://llvm.org/viewvc/llvm-project?rev=280064&view=rev
Log:
This adds new options -fdenormal-fp-math and passes through option -ffast-math
to CC1, which are translated to function attributes and can e.g. be mapped on
bu
SjoerdMeijer updated this revision to Diff 69379.
SjoerdMeijer added a comment.
Sorry, forgot to add the doc patch, but it has been included now.
This will be used in llvm to emit and appropriately set build attributes
ABI_FP_denormal and ABI_FP_exceptions. I am now trying to get a llvm patch
r
SjoerdMeijer updated this revision to Diff 69367.
SjoerdMeijer added a comment.
Hi James,
Thanks for the review. I got rid of that new option -fexceptions-fp-math and
now use -ftrapping-math for that which indeed was not passed through to CC1.
Cheers.
https://reviews.llvm.org/D23840
Files:
SjoerdMeijer updated this revision to Diff 69125.
https://reviews.llvm.org/D23840
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/CGCall.cpp
lib/Driver/Tools.cpp
lib/Frontend/CompilerInvocation.cpp
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: jmolloy, ddunbar, rengolin, sanjoy.
SjoerdMeijer added a subscriber: cfe-commits.
This adds options -fexceptions-fp-math and -fdenormal-fp-math, which are
translated to function attributes. This is intended to be mapped on build
a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271672: RAS extensions are part of ARMv8.2. (authored by
SjoerdMeijer).
Changed prior to commit:
http://reviews.llvm.org/D20283?vs=57451&id=59551#toc
Repository:
rL LLVM
http://reviews.llvm.org/D202
Author: sjoerdmeijer
Date: Fri Jun 3 09:08:20 2016
New Revision: 271672
URL: http://llvm.org/viewvc/llvm-project?rev=271672&view=rev
Log:
RAS extensions are part of ARMv8.2.
This patch enables +ras +noras to AArch64 in clang.
Patch by: Roger Ferrer Ibanez and Oliver Stannard
Differential Revis
Author: sjoerdmeijer
Date: Fri Jun 3 03:47:56 2016
New Revision: 271636
URL: http://llvm.org/viewvc/llvm-project?rev=271636&view=rev
Log:
Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72
Differential Revision: http://reviews.llvm.org/D20908
Modified:
cfe/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271636: Add a few missing Clang regression tests for
Cortex-A53, Cortex-A57, Cortex-A72 (authored by SjoerdMeijer).
Changed prior to commit:
http://reviews.llvm.org/D20908?vs=59371&id=59500#toc
Reposit
SjoerdMeijer created this revision.
SjoerdMeijer added a reviewer: rengolin.
SjoerdMeijer added a subscriber: cfe-commits.
Add a few missing Clang regression tests for Cortex-A53, Cortex-A57, Cortex-A72
http://reviews.llvm.org/D20908
Files:
test/Preprocessor/arm-target-features.c
Index: test/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271507: This adds target support and tests for Cortex-A73
(authored by SjoerdMeijer).
Changed prior to commit:
http://reviews.llvm.org/D20864?vs=59219&id=59357#toc
Repository:
rL LLVM
http://reviews
Author: sjoerdmeijer
Date: Thu Jun 2 05:48:37 2016
New Revision: 271507
URL: http://llvm.org/viewvc/llvm-project?rev=271507&view=rev
Log:
This adds target support and tests for Cortex-A73
Differential Revision: http://reviews.llvm.org/D20864
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: rengolin, t.p.northover.
SjoerdMeijer added a subscriber: cfe-commits.
This adds target support and tests for Cortex-A73
http://reviews.llvm.org/D20864
Files:
lib/Basic/Targets.cpp
lib/Driver/Tools.cpp
test/CodeGen/arm-targe
I've taken the latest suggestions into account, see attached patch. Could you
have a look?
Thanks.
-Original Message-
From: scott douglass [mailto:sdougl...@arm.com]
Sent: 18 August 2015 14:16
To: Sjoerd Meijer
Cc: 'Marshall Clow'; 'Gabriel Dos Reis'; 'Richard Smith'; 'cfe-commits'
Subje
Please see updated patch file attached, which now includes a fixed/added
regression test.
Sjoerd.
From: Sjoerd Meijer
Sent: 17 August 2015 13:34
To: 'Gabriel Dos Reis'; Richard Smith
Cc: Marshall Clow; cfe-commits
Subject: RE: [PATCH] RE: [cfe-dev] missing return statement for non-void
func
Agreed, let’s get that right first.
The attached patch causes the program to trap for all optimizations levels,
except when optimizing for size.
Sjoerd.
From: dosr...@gmail.com [mailto:dosr...@gmail.com] On Behalf Of Gabriel Dos Reis
Sent: 13 August 2015 21:51
To: Richard Smith
Cc: Sjoerd Meijer
Yes, I got confused when clang is in C++ mode. In my patch, I was checking the
driver status, but that’s not the complete story. From these combinations of
invoking clang with some input:
./clang[++] [-x [c | c++]] myinput.[TY_C | TY_CXX]
I wanted to create a special case for these combinations
Hi Richard,
Thanks for reviewing. Agree, that was a bit confusing. More specifically,
the warning message was confusing (i.e. wrong). This patch is for compiling .c
input in C++ mode. The new flag should be ignored for C++ *input*, and indeed
not when it is in C++ *mode* as the warning message said
[ + cfe-commits@lists.llvm.org ]
Hi,
The functionality is now available under a flag, see attached patch. Note that
the flag is ignored in C++ mode, so it will help the use case of compiling
(legacy) C code with a C++ compiler.
Cheers,
Sjoerd.
From: Sjoerd Meijer [mailto:sjoerd.mei...@
99 matches
Mail list logo
