[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-05-31 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski added a comment. In https://reviews.llvm.org/D19201#768693, @baloghadamsoftware wrote: > There is a patch (https://reviews.llvm.org/D33537) for a check which is a > superset of this: [...] A more important difference is that we traverse the > whole call-chain and check all the throw

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-05-20 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski marked 3 inline comments as done. sbarzowski added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25 + Finder->addMatcher( + cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func" + .bind("throw"), --

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-05-20 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski updated this revision to Diff 99670. sbarzowski marked 5 inline comments as done. sbarzowski added a comment. Cosmetic https://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowWithNoexceptCheck.cpp clang-tid

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-05-18 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski updated this revision to Diff 99502. sbarzowski marked 8 inline comments as done. sbarzowski added a comment. Removed unnecessary colon from message https://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowWit

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-05-18 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski updated this revision to Diff 99500. sbarzowski marked 3 inline comments as done. sbarzowski added a comment. Docs and cosmetic issues https://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowWithNoexceptCheck

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-05-04 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski updated this revision to Diff 97859. sbarzowski added a comment. Herald added a subscriber: xazax.hun. Fixed false positive issues https://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/ThrowWithNoexceptCheck.cpp

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-03-13 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20 +///\brief Warns about using throw in function declared as noexcept. +/// It complains about every throw, even if it is caught later. +class ThrowWithNoexceptCheck : public ClangTidyCheck {

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-03-06 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20 +///\brief Warns about using throw in function declared as noexcept. +/// It complains about every throw, even if it is caught later. +class ThrowWithNoexceptCheck : public ClangTidyCheck {

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-02-07 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54 +// FIXME use DiagnosticIDs::Level::Note +diag(NoExceptRange.getBegin(), "in a function declared no-throw here:", DiagnosticIDs::Note) +<< FixItHint::CreateRemoval(NoExcep

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-02-07 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54 +// FIXME use DiagnosticIDs::Level::Note +diag(NoExceptRange.getBegin(), "in a function declared no-throw here:", DiagnosticIDs::Note) +<< FixItHint::CreateRemoval(NoExcep

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-01-26 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski updated this revision to Diff 85882. sbarzowski marked 3 inline comments as done. sbarzowski added a comment. Improved messages, added tests with templates, fixed some typos. https://reviews.llvm.org/D19201 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

[PATCH] D19201: [clang-tidy] misc-throw-with-noexcept

2017-01-16 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski removed rL LLVM as the repository for this revision. sbarzowski updated this revision to Diff 84577. sbarzowski added a comment. Herald added subscribers: JDevlieghere, mgorny. I took advantage of new getExceptionSpecSourceRange (it wasn't available before) instead of getting exception

[PATCH] D27806: [clang-tidy] Add obvious-invalid-range

2016-12-16 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski added inline comments. Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36 +"std::for_each; std::find; std::find_if; std::find_end; " +"std::find_first_of; std::adjacent_find; std::count; std::count_if;" +"std::mismatch; std::equal; std::search; std:

[PATCH] D27806: [clang-tidy] Add obvious-invalid-range

2016-12-16 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski requested changes to this revision. sbarzowski added inline comments. This revision now requires changes to proceed. Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36 +"std::for_each; std::find; std::find_if; std::find_end; " +"std::find_first_of; std:

[PATCH] D27752: [clang] Use after move bug fixes

2016-12-15 Thread Stanisław Barzowski via Phabricator via cfe-commits
sbarzowski accepted this revision. sbarzowski added a reviewer: sbarzowski. sbarzowski added a comment. LGTM https://reviews.llvm.org/D27752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c