sbarzowski added a comment.
In https://reviews.llvm.org/D19201#768693, @baloghadamsoftware wrote:
> There is a patch (https://reviews.llvm.org/D33537) for a check which is a
> superset of this: [...] A more important difference is that we traverse the
> whole call-chain and check all the throw
sbarzowski marked 3 inline comments as done.
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:25
+ Finder->addMatcher(
+ cxxThrowExpr(stmt(hasAncestor(functionDecl(isNoThrow()).bind("func"
+ .bind("throw"),
--
sbarzowski updated this revision to Diff 99670.
sbarzowski marked 5 inline comments as done.
sbarzowski added a comment.
Cosmetic
https://reviews.llvm.org/D19201
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/ThrowWithNoexceptCheck.cpp
clang-tid
sbarzowski updated this revision to Diff 99502.
sbarzowski marked 8 inline comments as done.
sbarzowski added a comment.
Removed unnecessary colon from message
https://reviews.llvm.org/D19201
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/ThrowWit
sbarzowski updated this revision to Diff 99500.
sbarzowski marked 3 inline comments as done.
sbarzowski added a comment.
Docs and cosmetic issues
https://reviews.llvm.org/D19201
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/ThrowWithNoexceptCheck
sbarzowski updated this revision to Diff 97859.
sbarzowski added a comment.
Herald added a subscriber: xazax.hun.
Fixed false positive issues
https://reviews.llvm.org/D19201
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/ThrowWithNoexceptCheck.cpp
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck {
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.h:20
+///\brief Warns about using throw in function declared as noexcept.
+/// It complains about every throw, even if it is caught later.
+class ThrowWithNoexceptCheck : public ClangTidyCheck {
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExcep
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExcep
sbarzowski updated this revision to Diff 85882.
sbarzowski marked 3 inline comments as done.
sbarzowski added a comment.
Improved messages, added tests with templates, fixed some typos.
https://reviews.llvm.org/D19201
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
sbarzowski removed rL LLVM as the repository for this revision.
sbarzowski updated this revision to Diff 84577.
sbarzowski added a comment.
Herald added subscribers: JDevlieghere, mgorny.
I took advantage of new getExceptionSpecSourceRange (it wasn't available
before) instead of getting exception
sbarzowski added inline comments.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36
+"std::for_each; std::find; std::find_if; std::find_end; "
+"std::find_first_of; std::adjacent_find; std::count; std::count_if;"
+"std::mismatch; std::equal; std::search; std:
sbarzowski requested changes to this revision.
sbarzowski added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/obvious/InvalidRangeCheck.cpp:20-36
+"std::for_each; std::find; std::find_if; std::find_end; "
+"std::find_first_of; std:
sbarzowski accepted this revision.
sbarzowski added a reviewer: sbarzowski.
sbarzowski added a comment.
LGTM
https://reviews.llvm.org/D27752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
15 matches
Mail list logo