[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. In D154869#4652703 , @DanielCChen wrote: > Sorry about the breakage This is why we have CI ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.ll

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. Thanks for the revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D154869: [Flang] [FlangRT] Introduce FlangRT project as solution to Flang's runtime LLVM integration

sylvestre.ledru added a comment. With this patch, it started to fail with: It would be nice to have a better error message suggesting what to do -- Performing Test HAVE_DECL_STRERROR_S -- Performing Test HAVE_DECL_STRERROR_S - Failed CMake Error at /build/source/flang-rt/unittests/CMakeList

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

sylvestre.ledru added a comment. I reverted the patch for causing https://github.com/llvm/llvm-project/issues/63974 https://github.com/llvm/llvm-project/commit/443f490b6aac4af28500f4b09b68a13260f4fba9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D153989: [compiler-rt] Move crt into builtins

sylvestre.ledru added a comment. Seems that it caused: https://github.com/llvm/llvm-project/issues/63799 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153989/new/ https://reviews.llvm.org/D153989 ___ cfe

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru added a comment. thanks. reverting is fine :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141047/new/ https://reviews.llvm.org/D141047 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f3081dc6fe8: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too (authored by sylvestre.ledru). Repository: rG LLVM Github

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru updated this revision to Diff 486546. sylvestre.ledru added a comment. add the missing {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141047/new/ https://reviews.llvm.org/D141047 Files: clang/cmake/modules/AddGRPC.cmake cmake

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added subscribers: bmahjour, kadircet, arphaman. Herald added a project: All. sylvestre.ledru requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald a

[PATCH] D125860: [clang] Only use major version in resource dir

sylvestre.ledru added a comment. i hope not too many people rely on it. LGTM but please add it to the release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 ___ cfe-commits mailing list cfe-co

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

sylvestre.ledru added a comment. Maybe add it to the release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. ouf, thanks :) I am sure the doc has plenty of other issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits m

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. yeah, happy to do that if the author wants :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. oh, crappy, i forgot to update the author of the patch :( really sorry about that... :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 __

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. pushed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D136424: Update links to googletest documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb814d85e5b9d: Update links to googletest documentation (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://revi

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru added a comment. np, let me land this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D136424: Update links to googletest documentation

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Thanks for carrying about the doc! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136424/new/ https://reviews.llvm.org/D136424

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

sylvestre.ledru added inline comments. Comment at: clang/docs/ReleaseNotes.rst:49 + present in major C++ implementations (including Clang), this error has the + ability to be downgraded into a warning (via: -Wno-error=enum-constexpr-conversion) + to provide a transition perio

[PATCH] D131565: [cmake] Fix tablegen exports

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f555a52e033: [cmake] Fix tablegen exports (authored by nikic, committed by sylvestre.ledru). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

sylvestre.ledru added a comment. We have this error in OpenMP: https://github.com/llvm/llvm-project/issues/57022 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307 ___

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sylvestre.ledru added a comment. Same, it broke apt.llvm.org It is installing some of the libs in debian/tmp/libgomp.so instead of debian/tmp/usr/lib/llvm-15/lib/libgomp.so I think it should be indeed revert (and in the branch 15 too) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

sylvestre.ledru added a comment. @pengfei I am not convinced it is an issue on my side. I don't have anything particular in this area and using a stage2 build system. Anyway, this patch fixes the issue on my side: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/snapshot/debian/patch

[PATCH] D129049: [clang] Fix gcc-6 compilation error. (NFC)

sylvestre.ledru added a comment. thanks I will retrigger the CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129049/new/ https://reviews.llvm.org/D129049 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

sylvestre.ledru added a comment. Same as in https://reviews.llvm.org/D114099 It breaks the build on ubuntu bionic, Hirsute, etc on amd64: "/build/llvm-toolchain-snapshot-15~++20220702091600+23ee84f43201/build-llvm/./bin/clang" --target=x86_64-pc-linux-gnu -DVISIBILITY_HIDDEN -fstack-protecto

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Herald added a subscriber: jsji. Herald added a project: All. @zahiraam Sorry, i missed your questions > But I see in the command above that it is compiling with > -DCOMPILER_RT_HAS_FLOAT16. @sylvestre.ledru is this flag really supposed to > be on? dunno, I gu

[PATCH] D126672: [Driver] Add multiarch path for RISC-V

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126672/new/ https://reviews.llvm.org/D126672 _

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

sylvestre.ledru added inline comments. Comment at: clang/docs/ReleaseNotes.rst:177 +* CMake ``-DCLANG_DEFAULT_PIE_ON_LINUX=ON`` is now the default. + This matches GCC installations on many Linux distros. it would be nice to explain what "pie" it is doing :)

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

sylvestre.ledru added a comment. Could you please stop with the pings? and chat directly ? (It seems that you are colleagues?!) I would like to follow what is happening here but not get flooded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

sylvestre.ledru added a comment. Thanks for this, it found 74 occurrences of this in the firefox code base https://hg.mozilla.org/mozilla-central/rev/b07f125d09fd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D798

[PATCH] D60380: Also document -arch as -arch is mac specific

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4bb622fc94a: Also document -arch as -arch is mac specific (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D60380: Also document -arch as -arch is mac specific

sylvestre.ledru updated this revision to Diff 405262. sylvestre.ledru added a comment. add . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/new/ https://reviews.llvm.org/D60380 Files: clang/docs/CommandGuide/clang.rst Index: clang/docs/Co

[PATCH] D60380: Also document -arch as -arch is mac specific

sylvestre.ledru updated this revision to Diff 405259. sylvestre.ledru added a comment. Take in account Serge's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/new/ https://reviews.llvm.org/D60380 Files: clang/docs/CommandGuide/clang.

[PATCH] D118211: Add missing namespace to PPCLinux.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd71493ff060: Add missing namespace to PPCLinux.cpp (authored by glandium, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHA

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

sylvestre.ledru added a comment. I am not sure why you are pinging this review often?! Maybe chat with people who gave you feedback before directly?! Myself I wasted so much time because of D107799 that I am very reluctant to enable LLVM_ENABLE_PER_TARGET_RUN

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

sylvestre.ledru added a comment. Maybe add it to the release notes too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 ___ cfe-commits mailing list cfe-commits

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Actually, it breaks on all Debian. Could you please revert it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Full log: https://llvm-jenkins.debian.net/view/Debian%20sid/job/llvm-toolchain-binaries/architecture=amd64,distribution=unstable,label=amd64/104/consoleFull CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114099/new/ https://reviews.llvm.org/D114099 _

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. As mentioned in https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b#commitcomment-60741407 This change is breaking build of compiler-rt on Ubuntu bionic and others on amd64: "/build/llvm-toolchain-snapshot-14~++2029100719

[PATCH] D112519: parallel-libs: remove some artifacts

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: dblaikie, jlebar. sylvestre.ledru requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D112

[PATCH] D112299: Replace references to Makefile.sphinx

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd5e3f36f218: Replace references to Makefile.sphinx (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112299: Replace references to Makefile.sphinx

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: tstellar. Herald added a reviewer: aaron.ballman. sylvestre.ledru requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. and fix some typos Repository:

[PATCH] D112030: [docs] Remove Makefile.sphinx files

sylvestre.ledru added a comment. Adjustment made on my side: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/commit/daf38c1634954d9aad7a1393eef0828c57f41a53 @tstellar Maybe you could add this to the release notes? (I think others are probably using it) Repository: rG LLVM Github Mon

[PATCH] D112030: [docs] Remove Makefile.sphinx files

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. I don't need any time, please land it when you want, I will adjust later :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112030/new/ https://reviews.llvm.org/D112030 ___

[PATCH] D112030: [docs] Remove Makefile.sphinx files

sylvestre.ledru added a comment. I am using them but I can move to sphinx calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112030/new/ https://reviews.llvm.org/D112030 ___ cfe-commits mailing list cf

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

sylvestre.ledru added a comment. This change caused libclc to fail to build on old ubuntu (using llvm-spir 10.0.0-1) See: https://bugs.llvm.org/show_bug.cgi?id=52200 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llvm.o

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru added a comment. @Quuxplusone fixed, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c8f950a0400: clang release notes: document the -Wbool-operation improvement (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru updated this revision to Diff 377486. sylvestre.ledru added a comment. add "which have side effects" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 Files: clang/docs/ReleaseNotes.rst

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru added a comment. @xbolva00 sorry but you would like -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands which have side effects or -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boole

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru updated this revision to Diff 377483. sylvestre.ledru added a comment. Take in account the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 Files: clang/docs/ReleaseNotes.rst In

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

sylvestre.ledru added a comment. It found a few issues on Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1734285 I think it should be added it in the release notes: https://reviews.llvm.org/D111215 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: xbolva00, nathanchance. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111215 Files:

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

sylvestre.ledru added a comment. just to make sure I understand, it will also update the install or "just" the dumpmachine option ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. @phosek It was probably my fault (mix of different in-tree / out of tree builds) Quick question, why the path to `__config_site` contains this triple `x86_64-pc-linux-gnu` (in `/usr/lib/llvm-14/include/x86_64-pc-linux-gnu/c++/v1/__config_site`) when it is usually:

[PATCH] D110521: Make analyze-cc path discovery sensible to symlinks

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110521/new/ https://reviews.llvm.org/D110521 __

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. > How was the toolchain in > /home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0 > > /build-llvm > built? Only using PROJECTS

[PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build

sylvestre.ledru added a comment. Building with this patch Debian packages is failing with: "/home/sylvestre/dev/debian/pkg-llvm/llvm-toolchain/branches/llvm-toolchain-snapshot-14~++20210922093928+5da21338bcd0/build-llvm/tools/clang/stage2-bins/bin/clang++" -DHAVE___CXA_THREAD_ATEXIT_IMPL -DLI

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. https://github.com/llvm/llvm-project/blob/release/13.x/clang/docs/ReleaseNotes.rst#new-compiler-flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109642/new/ https://review

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

sylvestre.ledru added a comment. it landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109642/new/ https://reviews.llvm.org/D109642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeccd477ce312: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables (authored by sylvestre.ledru). Repository: rG LLVM Githu

[PATCH] D53014: Add CMAKE_BUILD_TYPE to the list of BOOTSTRAP_DEFAULT_PASSTHROUGH variables

sylvestre.ledru updated this revision to Diff 373804. sylvestre.ledru added a comment. Herald added a project: clang. Rebase of the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53014/new/ https://reviews.llvm.org/D53014 Files: clang/CMake

[PATCH] D109023: libclang: Document the soname change in the release notes

sylvestre.ledru closed this revision. sylvestre.ledru added a comment. it landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109023/new/ https://reviews.llvm.org/D109023 ___ cfe-commits mailing list cf

[PATCH] D109659: Fix scan-build-py executable lookup path

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. LGTM, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109659/new/ https://reviews.llvm.org/D109659 _

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

sylvestre.ledru added a comment. To land in the 13.x branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109642/new/ https://reviews.llvm.org/D109642 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D109642: -Wunused-but-set-parameter/-Wunused-but-set-variable Add to the release notes

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: mbenfield, tstellar, lebedev.ri. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109642

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:1 += +Clang Nvlink Wrapper please remove one "=" rst expects alignment Comment at: clang/docs/ClangNvlinkWrapper.rst:52 + Output file gen

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:19 + +During linking of heterogenous device archive libraries with an OpenMP program, +the `Clang Offload Bundler `_ hetero

[PATCH] D106813: [clang-repl] Build and install clang-repl by default

sylvestre.ledru added a comment. Maybe add this to the release notes of clang 13 or 14? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106813/new/ https://reviews.llvm.org/D106813 ___ cfe-commits mailing

[PATCH] D108291: [clang-nvlink-wrapper] Wrapper around nvlink for archive files

sylvestre.ledru added a comment. Maybe add this to the release notes of clang 14? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108291/new/ https://reviews.llvm.org/D108291 ___ cfe-commits mailing list c

[PATCH] D109023: libclang: Document the soname change in the release notes

sylvestre.ledru added a comment. OK, for the variable, I took the liberty then to cherry-pick : https://github.com/llvm/llvm-project/commit/039d1a94b908d786965bf4fd35f9e933ca899719 For the release notes: https://github.com/llvm/llvm-project/commit/d597db1aebf282fa88d4359816f409d164054095 https://

[PATCH] D109023: libclang: Document the soname change in the release notes

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: MaskRay, tstellar. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109023 Files: cla

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe611b1da84b: [clang] Move the soname declaration in a variable at the top of the file (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

sylvestre.ledru updated this revision to Diff 368126. sylvestre.ledru added a comment. Move the comment too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533 Files: clang/tools/libclang/CMakeLists.txt I

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: tstellar, MaskRay. Herald added a subscriber: mgorny. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, it is a bit buried in the file even if

[PATCH] D107887: scan-build-py: Force the opening in utf-8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70b06fe8a186: scan-build-py: Force the opening in utf-8 (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D107887: scan-build-py: Force the opening in utf-8

sylvestre.ledru updated this revision to Diff 366937. sylvestre.ledru added a comment. Replace " => ' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107887/new/ https://reviews.llvm.org/D107887 Files: clang/tools/scan-build-py/lib/libscanbuild/re

[PATCH] D107887: scan-build-py: Force the opening in utf-8

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: phosek, isthismyaccount, aabbaabb. Herald added a subscriber: whisperity. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It fails on ubuntu bionic othe

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

sylvestre.ledru added a comment. As this is a big deal for packager, maybe it should be part of the release notes ? (maybe it is and I just missed it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 __

[PATCH] D99081: [clang-tidy] ensure run-clang-tidy reports children killed by signals

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ba03584b3c: [clang-tidy] ensure run-clang-tidy reports children killed by signals (authored by ijc, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D99081: [clang-tidy] ensure run-clang-tidy reports children killed by signals

sylvestre.ledru added a comment. Oh, I missed your message. I can land it for you, ok? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99081/new/ https://reviews.llvm.org/D99081 ___ cfe-commits mailing lis

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

sylvestre.ledru added a comment. > I think this change broke apt.llvm.org Confirmed: reverting this change fixed the link issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94333/new/ https://reviews.llvm.org/D94333 _

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

sylvestre.ledru added a comment. Herald added a subscriber: ormris. I think this change broke apt.llvm.org > [100%] Linking CXX shared library ../../lib/libLLVM-13.so > cd "/build/llvm-toolchain-snapshot-13~++20210619083511+1605fce6c307/build-llvm/tools/llvm-shlib" && /usr/bin/cmake -E cmak

[PATCH] D100484: add test case for ignoring -flto=auto and -flto=jobserver

This revision was automatically updated to reflect the committed changes. Closed by commit rG56cb214b38a7: add test case for ignoring -flto=auto and -flto=jobserver (authored by doko, committed by sylvestre.ledru). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

sylvestre.ledru added a comment. To understand better, we will be fixing a bug from 2015, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-commits

[PATCH] D99501: ignore -flto= options recognized by GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG162848654842: ignore -flto= options recognized by GCC (authored by sylvestre.ledru). Herald added a project: clang. Herald added a subscriber: cfe-co

[PATCH] D99852: [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on Debian i386

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Many thanks. it fixed my issues! /usr/include/i386-linux-gnu/c++/8 is indeed much nicer :) Thanks for all your hard work on fixing the header detection. it was indeed too co

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. I guess this will be clearly mentioned in the release notes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 ___ cfe-commits ma

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Let's do it then :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. Yeah, my question is more "is that enough for distro?" https://www.debian.org/doc/manuals/maint-guide/advanced.en.html https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html I might be wrong but if 11.1 and 11.0 aren't compatible (not jus

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. I might be wrong but if the ABI is incompatible, are we not supposed to update the SONAME itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 __

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru added a comment. Thanks for the revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d59c8fdb955: -fstack-clash-protection: Return an actual error when used on unsupported OS (authored by sylvestre.ledru). Repository: rG LLVM Gith

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 313271. sylvestre.ledru added a comment. Error only on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru added a comment. @serge-sans-paille ok to push this? :) merci Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing list cfe-com

[PATCH] D92652: [clang-tidy][docs] Update check options with boolean values instead of non-zero/0/1

sylvestre.ledru added a comment. Thanks for doing that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92652/new/ https://reviews.llvm.org/D92652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308402. sylvestre.ledru added a comment. Herald added subscribers: llvm-commits, pengfei. Herald added a project: LLVM. extend the test (thanks serge) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308290. sylvestre.ledru added a comment. Fix the error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 308160. sylvestre.ledru added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files: clang/include/clang/Basic/DiagnosticDriverKinds.t

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. sylvestre.ledru requested review of this revision. $ clang-12: error: -fstack-clash-protection is not supported on Windows or Mac OS X

  1   2   3   4   5   >