[PATCH] D91979: [Clang][Attr] Introduce the `assume` function attribute

2020-11-23 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Swift uses a similar mechanism: https://github.com/apple/swift/blob/887464b7b67d5202bfa7adc4e3f045ff1027a5a7/stdlib/public/core/Array.swift#L829 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91979/new/

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

2020-11-19 Thread Thorsten via Phabricator via cfe-commits
tschuett added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:909 + FeatureMTE, + FeatureSVE2, + FeatureTRBE]>; SVE2 Bitperm is

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

2020-11-18 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. The features still differ from gcc. https://github.com/gcc-mirror/gcc/blob/cb1a4876a0e724ca3962ec14dce9e7819fa72ea5/gcc/config/aarch64/aarch64-cores.def#L146 It has SVE2_Bitperm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91695: [ARM][AArch64] Adding Neoverse N2 CPU support

2020-11-18 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. In the first version N2 had FeatureTME. Did you remove that on purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91695/new/ https://reviews.llvm.org/D91695 ___ cfe-commits

[PATCH] D78903: [Driver] Add option -fproc-stat-report

2020-11-17 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78903: [Driver] Add option -fproc-stat-report

2020-11-16 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Could you add quotation marks around the executable name to make the CSV file easier to parse? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903

[PATCH] D91498: [NFC, Refactor] Convert TypeSpecifierSign from Specifiers.h to a scoped enum

2020-11-16 Thread Thorsten via Phabricator via cfe-commits
tschuett updated this revision to Diff 305490. tschuett added a comment. rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91498/new/ https://reviews.llvm.org/D91498 Files: clang/include/clang/AST/TypeLoc.h clang/include/clang/Basic/Specifiers.h

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

2020-11-16 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Yes. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91506/new/ https://reviews.llvm.org/D91506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

2020-11-16 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I am happy, if you could commit this for me. I am still learning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91506/new/ https://reviews.llvm.org/D91506 ___ cfe-commits

[PATCH] D91506: [NFC, Refactor] Convert TypeSpecifiersPipe from Specifiers.h to a scoped enum (tiny)

2020-11-15 Thread Thorsten via Phabricator via cfe-commits
tschuett created this revision. tschuett added reviewers: aaron.ballman, faisalv, wchilders. Herald added subscribers: cfe-commits, dexonsmith, usaxena95, kadircet. Herald added a project: clang. tschuett requested review of this revision. Herald added a subscriber: ilya-biryukov. > ninja clang

[PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

2020-11-14 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I started with specifiers.h here: https://reviews.llvm.org/D91409, but it is not yet committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91035/new/ https://reviews.llvm.org/D91035

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

2020-11-09 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I did not consider false positives, but it provides better visibility. It is always on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

2020-11-09 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Out of curiosity: why is this in clang-tidy and not in clang? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055 ___ cfe-commits mailing

[PATCH] D89959: UBSAN: emit distinctive traps in trapping mode

2020-11-02 Thread Thorsten via Phabricator via cfe-commits
tschuett added inline comments. Comment at: llvm/docs/LangRef.rst:19494 + + declare void @llvm.ubsantrap(i32 immarg) cold noreturn nounwind + This is still i32. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89959/new/

[PATCH] D86895: [Modules] Add stats to measure performance of building and loading modules.

2020-09-22 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Where is the test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86895/new/ https://reviews.llvm.org/D86895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86802: [Modules] Don't parse/load explicit module maps if modules are disabled

2020-08-28 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Herald added a subscriber: danielkiss. How about a malformed module map is not loaded and gives no errors? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86802/new/ https://reviews.llvm.org/D86802

[PATCH] D86688: [RecoveryExpr] Add 11.0.0 release note.

2020-08-27 Thread Thorsten via Phabricator via cfe-commits
tschuett added inline comments. Comment at: clang/docs/ReleaseNotes.rst:73 + + // clangd-11 produces a richer AST: + // VarDecl col:5 x 'int' cinit clangd-11 or clang-11? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85977: [release][docs] Update contributions to LLVM 11 for SVE.

2020-08-14 Thread Thorsten via Phabricator via cfe-commits
tschuett added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:162 + svfloat64_t vout = svadd_x(Pg, vx, vy); +svst1(Pg, [i], vout); + } Nit: indentation? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85977/new/

[PATCH] D85191: [AST] Get field size in chars rather than bits in RecordLayoutBuilder.

2020-08-06 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I don't know whether the name of your downstream target is a secret. Wouldn't it help you to add a fake 16bit per char target and add units tests to prevent regressions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

2020-08-04 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Sorry. I meant ABI. Can link GCC .o files with Clang .o files using the attributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85128/new/ https://reviews.llvm.org/D85128

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-03 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I would appreciate it, if somebody could commit this patch on my behalf. Thorsten Schuett schu...@gmail.com Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___

[PATCH] D85128: [Prototype][SVE] Support arm_sve_vector_bits attribute

2020-08-03 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Stupid questions. - Is it for convenience? You get arrays, global variables, structs, ... . Vectorization becomes easier ... - Are there any potential performance benefits over scalable vectors? - Is it compatible with GCC? Repository: rG LLVM Github Monorepo

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-03 Thread Thorsten via Phabricator via cfe-commits
tschuett updated this revision to Diff 282637. tschuett added a comment. added missing "alignment" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-03 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I wanted to save space. I know that the alignment is missing there, but the line is already too long. I have no rights to commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-02 Thread Thorsten via Phabricator via cfe-commits
tschuett updated this revision to Diff 282485. tschuett added a comment. add/updated test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-02 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. introduced in https://reviews.llvm.org/D45319 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-02 Thread Thorsten via Phabricator via cfe-commits
tschuett updated this revision to Diff 282483. tschuett added a comment. Replaced (...) by ; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85102/new/ https://reviews.llvm.org/D85102 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D85102: [clang] improve diagnostics for misaligned and large atomics

2020-08-02 Thread Thorsten via Phabricator via cfe-commits
tschuett created this revision. tschuett added a reviewer: rsmith. Herald added a reviewer: jfb. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. tschuett requested review of this revision. Herald added a subscriber: dexonsmith. "Listing the alignment and access size (==

[PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

2020-07-05 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. You could try: clangxx_host -Xclang -fdump-record-layouts %p/Inputs/layout.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 ___ cfe-commits mailing list

[PATCH] D68115: Zero initialize padding in unions

2020-05-18 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I watched the talk, but I still prefer compile-time errors over runtime crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68115/new/ https://reviews.llvm.org/D68115 ___

[PATCH] D68115: Zero initialize padding in unions

2020-05-17 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. As an outsider: In Swift, reading an uninitialized variable is a compile-time error. Clang is not powerful enough to do this analysis. Aren't you really looking for the Clang Intermediate Language (CIL) ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D78903: [Driver] Add option -fproc-stat-report

2020-05-02 Thread Thorsten via Phabricator via cfe-commits
tschuett added inline comments. Comment at: clang/lib/Driver/Driver.cpp:83 #include "llvm/Support/raw_ostream.h" +#include #include https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D66555: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation

2019-08-22 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. How does it relate to the -MJ option? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66555/new/ https://reviews.llvm.org/D66555 ___ cfe-commits mailing list

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

2019-04-08 Thread Thorsten via Phabricator via cfe-commits
thorsten-klein added a comment. Hello @alexfh , Let me extend your example $ cat a.cc #include "b.h" #include "d.h" int main(){check(nullptr);} $ cat b.h #include "c.h" inline void b() { c(/*y=*/42); } $ cat c.h void c(int x); $ cat d.h inline char* check(char* buffer)

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

2019-04-02 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. Are you planning to do this recursively? The minimizer does not help much for the following example, while Sema.h contains 10,000 lines of useless code. #include "clang/Sema/Sema.h" int foo() {} Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

2019-03-19 Thread Thorsten via Phabricator via cfe-commits
thorsten-klein updated this revision to Diff 191415. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59135/new/ https://reviews.llvm.org/D59135 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp Index: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

2019-03-19 Thread Thorsten via Phabricator via cfe-commits
thorsten-klein added a comment. Hello, can you please support with this Pull-Request? You really have better knowledge about source code. For our case this solution was working fine and I wanted to share with you. Maybe it will help you if I create an examplary project which reproduces the

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

2019-03-08 Thread Thorsten via Phabricator via cfe-commits
thorsten-klein added a comment. Sorry for delay. I am currently not able to build master (Error: "sort" is not a member of "llvm"). And if I try to build 6.0.1-rc3 I can build clang-tidy but I am not able to build corresponding unittests "ClangTidyTests". I will try to solve as soon as

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

2019-03-08 Thread Thorsten via Phabricator via cfe-commits
thorsten-klein added a comment. Hello, Can you please support how to do that? :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59135/new/ https://reviews.llvm.org/D59135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

2019-03-08 Thread Thorsten via Phabricator via cfe-commits
thorsten-klein updated this revision to Diff 189859. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59135/new/ https://reviews.llvm.org/D59135 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp Index: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp

[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

2019-03-08 Thread Thorsten via Phabricator via cfe-commits
thorsten-klein created this revision. thorsten-klein added reviewers: aaron.ballman, klimek, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixed issue of not considering HeaderFilter which resulted in findings although they should be filtered out. Patch by