[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

thomasanderson added a comment. We appear to still be carrying a patch for this in Chromium, so I think the issue still stands. https://source.chromium.org/chromium/chromium/src/+/master:buildtools/third_party/libc++/BUILD.gn;drc=21272efa27e69622c6d174f29e4a73f1a6088cfc;l=135 Repository: rG

[PATCH] D49745: Generate fundamental type info with weak linkage

thomasanderson created this revision. thomasanderson added a reviewer: pcc. https://reviews.llvm.org/D49745 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/rtti-fundamental.cpp test/CodeGenCXX/windows-itanium-type-info.cpp Index: test/CodeGenCXX/windows-itanium-type-info.cpp

[PATCH] D49109: Borrow visibility from __fundamental_type_info for generated fundamental type infos

This revision was automatically updated to reflect the committed changes. Closed by commit rC337788: Borrow visibility from __fundamental_type_info for generated fundamental type… (authored by thomasanderson, committed by ). Repository: rC Clang https://reviews.llvm.org/D49109 Files:

[PATCH] D49109: Borrow visibility from __fundamental_type_info for generated fundamental type infos

thomasanderson updated this revision to Diff 156943. thomasanderson added a comment. Added test. Also verified that all tests in llvm/tools/clang/test pass. https://reviews.llvm.org/D49109 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/rtti-fundamental.cpp Index:

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

This revision was automatically updated to reflect the committed changes. Closed by commit rL337771: Fix typo in test/CodeGen/Mips/dins.ll (authored by thomasanderson, committed by ). Herald added subscribers: llvm-commits, jrtc27. Changed prior to commit:

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

thomasanderson added a comment. pcc ptal I've been granted commit-after-approval, and this is my test CL. https://reviews.llvm.org/D49704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49704: Fix typo in test/CodeGen/Mips/dins.ll

thomasanderson created this revision. thomasanderson added a reviewer: pcc. Herald added subscribers: atanasyan, arichardson, sdardis. https://reviews.llvm.org/D49704 Files: test/CodeGen/Mips/dins.ll Index: test/CodeGen/Mips/dins.ll

[PATCH] D49109: Borrow visibility from __fundamental_type_info for generated fundamental type infos

thomasanderson updated this revision to Diff 156399. thomasanderson marked 5 inline comments as done. https://reviews.llvm.org/D49109 Files: lib/CodeGen/ItaniumCXXABI.cpp Index: lib/CodeGen/ItaniumCXXABI.cpp === ---

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

thomasanderson added a comment. In https://reviews.llvm.org/D35388#1167305, @ldionne wrote: > ABI-wise, I think this change is OK. Indeed, if `__type_visibility__` is not > supported, we're already marking the base template as > `__visibility__("default")`, so marking the extern template

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

thomasanderson added a comment. Hm.. is there anyone else who might be able to review? https://reviews.llvm.org/D35388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

thomasanderson added a comment. Friendly ping for @EricWF https://reviews.llvm.org/D35388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits