[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. In D116778#3276421 , @aaron.ballman wrote: > In D116778#3259189 , > @MuAlphaOmegaEpsilon wrote: > >> In D116778#3255414 , >>

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. In D116778#3255414 , @aaron.ballman wrote: > LGTM! The CI failure is finally down to just an unrelated one (yay?). Do you > need someone to commit on your behalf? If so, what name and email address > would you like

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. Let me know if I should rebase this onto the latest main branch, at the moment the Windows build is passing but the Debian build is not, failing at `compiler-rt/test/sanitizer_common/tsan-x86_64-Linux/Linux/Output/decorate_proc_maps.cpp` for no immediately

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:290-292 +// Do not warn on naked functions. +[[gnu::naked]] int nakedFunction(int a, float b, const char *c) { ; } +__attribute__((naked)) void

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 400143. MuAlphaOmegaEpsilon added a comment. Update warning amount on CHECK-unused check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/ https://reviews.llvm.org/D116778 Files:

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. The warning would be correct if the compiler could actually tell the parameter is unused, but at the moment it cannot, as far as I know. I stumbled upon this thing myself, and there are a few ways to silence the warning: -removing names -marking every

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 400078. MuAlphaOmegaEpsilon added a comment. Fix failing test by updating clang/test/Sema/warn-unused-parameters.c expected warnings amount Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. In D116778#3244233 , @aaron.ballman wrote: > The changes look good aside from the precommit CI failing. Can you > investigate? Absolutely, I'm already giving a look at it! :) Repository: rG LLVM Github Monorepo

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 399793. MuAlphaOmegaEpsilon added a comment. Update code after review and add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/ https://reviews.llvm.org/D116778 Files:

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 398182. MuAlphaOmegaEpsilon added a comment. Rebased to more recent main branch, updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/ https://reviews.llvm.org/D116778 Files:

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon created this revision. MuAlphaOmegaEpsilon added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, xazax.hun. MuAlphaOmegaEpsilon requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This