[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 closed this revision. usaxena95 added a comment. closed by ac2d2652db8de9ea2b750dd2bf1232941039dffe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 updated this revision to Diff 554962. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/ https://reviews.llvm.org/D158842 Files:

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:217 +void $2^func2() requires $Bar4^Bar {} + )cpp"); + Inputs.Code = Code.code(); sammccall wrote: > to complete the set I think you want > > `void

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 updated this revision to Diff 554955. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Rebased over AST changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158842/new/ https://reviews.llvm.org/D158842 Files:

[PATCH] D158842: [include-cleaner] Handle decls/refs to concepts.

usaxena95 created this revision. usaxena95 added reviewers: massberg, sammccall. Herald added a subscriber: kadircet. Herald added a project: All. usaxena95 requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This is similar

[PATCH] D155898: [clangd] Fix go-to-type target location

usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:347 +void enhanceLocatedSymbolsFromIndex( +llvm::MutableArrayRef Result, +const llvm::DenseMap ,

[PATCH] D155614: [clangd] Make an include always refer to itself. Background: clang-review expects all referents to have definition, declaration or reference(s).

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1361-1362 }); - if (Results.References.empty()) -return std::nullopt; - Sorry for the confusion. This looks intentional and somewhat valuable for unused headers. We

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed365f464a0a: [clangd] Use FileEntryRef for canonicalizing filepaths. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513219. usaxena95 marked 6 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files:

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513168. usaxena95 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files: clang-tools-extra/clangd/Diagnostics.cpp

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513165. usaxena95 added a comment. More refactorings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files: clang-tools-extra/clangd/Diagnostics.cpp

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

usaxena95 added a comment. > starting a line with an opening paren is pretty weird!) I do not think this is weird. On the contrary, this is more readable to me and separates the requires clause from the parameters list. For example this one looks so much better: // trunk. template void

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 added a comment. This does not seem to be a pressing issue as there are no other reported module/cpp20 related crashes which were fixed by this. Also since it has no tests, it should be fine to postpone it to the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D145154: Change ClangTidy unit tests to run in C++20 mode instead of C++11.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc396073a0de6: Change ClangTidy unit tests to run in C++20 mode instead of C++11. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D145154: Change ClangTidy unit tests to run in C++20 mode instead of C++11.

usaxena95 created this revision. usaxena95 added a reviewer: gribozavr2. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4d9ac8b453e: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode (authored by usaxena95). Repository: rG LLVM Github

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

usaxena95 updated this revision to Diff 501822. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144480/new/ https://reviews.llvm.org/D144480 Files:

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

usaxena95 created this revision. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D142384: [C++20] Fix a crash with modules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb6121432da79: [C++20] Fix a crash with modules. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 494314. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 Files:

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 added a comment. In D142384#4096935 , @ilya-biryukov wrote: > @usaxena95 could you give an example of the code that fails the assertion? Is > it some of the tests? `assert(getDefinition())` fails about 3.6k tests. `assert(!isa(this) ||

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 493926. usaxena95 added a comment. Moved to RecordDecl::field_begin. Assertion is no more valid in RecordDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 493652. usaxena95 added a comment. Use definition based field access only for CXXRecordDecl. Avoid dynamic dispatch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 493538. usaxena95 added a comment. Moved the use of definition where fields are accessed. This now resolves several other C++20/Module related crashes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 493489. usaxena95 marked an inline comment as done. usaxena95 added a comment. Add message in the assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 Files:

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 491661. usaxena95 edited the summary of this revision. usaxena95 added a comment. Use `getDefinition` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142384/new/ https://reviews.llvm.org/D142384 Files:

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142384 Files: clang/lib/AST/ExprConstant.cpp

[PATCH] D141818: Add test for an invalid requirement in requires expr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG15ad244670a9: Add test for an invalid requirement in requires expr. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141818/new/

[PATCH] D141818: Add test for an invalid requirement in requires expr.

usaxena95 created this revision. usaxena95 added reviewers: ilya-biryukov, erichkeane. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The one introduced in D140547

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 marked 4 inline comments as done. usaxena95 added a comment. I have deleted the test in https://github.com/llvm/llvm-project/commit/a3b632ab8772237ae23638f702bdceda028b2016. It is safe to delete as this is a brittle test trying to generate an invalid requirement using very deep

[PATCH] D140547: Perform access checking to private members in simple requirement.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e0474fbb9c5: Perform access checking to private members in simple requirement. (authored by usaxena95). Changed prior to commit:

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 487866. usaxena95 added a comment. Remove new lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140547/new/ https://reviews.llvm.org/D140547 Files: clang/include/clang/AST/ExprConcepts.h

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1375 +if (Trap.hasErrorOccurred()) + TransReq.getAs()->setSatisfied(false); + } ilya-biryukov wrote: > ilya-biryukov wrote: > > `TransReq` may be

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 487865. usaxena95 marked 6 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140547/new/ https://reviews.llvm.org/D140547 Files:

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 486604. usaxena95 added a comment. Use ParsingDeclRAIIObject instead of ContextRAII. This creates a separate diagnostic pool for diagnositcs associated to the RequiresExprBodyDecl. This is important because dependent diagnostics should not leak to higher

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 486357. usaxena95 added a comment. Return a valid RequriesExpr instead of a ExprError in case of depenedent diagnositcs. We would also need to store the diagnositcs in the RequiresExpr for better diagnosis. Repository: rG LLVM Github Monorepo

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 486313. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added more tests. Still investigating libcxx failure and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140547/new/

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1367 + if (E->getBody()->isDependentContext()) { +Sema::SFINAETrap Trap(SemaRef); +// We recreate the RequiresExpr body, but

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

usaxena95 abandoned this revision. usaxena95 marked an inline comment as done. usaxena95 added a comment. Moving the changes to https://reviews.llvm.org/D140547 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140876/new/

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 486255. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Adding access check related changes from https://reviews.llvm.org/D140876 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

usaxena95 marked an inline comment as done. usaxena95 added a comment. In D140876#4023286 , @ilya-biryukov wrote: > Should access checks should happen in the context where `concept` is written > or where it's used? > If access-checking should happen

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

usaxena95 updated this revision to Diff 485939. usaxena95 added a comment. More tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140876/new/ https://reviews.llvm.org/D140876 Files: clang/lib/Parse/ParseExprCXX.cpp

[PATCH] D140876: [clang][C++20] Non-dependent access checks in requires expression.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Access to members in a non-dependent context would always yield an invalid expression. When it appears in a

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 485726. usaxena95 added a comment. Improved comment and added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140547/new/ https://reviews.llvm.org/D140547 Files:

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 485725. usaxena95 added a comment. Perform access-dependent checks after transforming requires clause. This is more generic and less invasive than the previous version which changed `RebuildMemberExpr` and also produced duplicate diagnostics. Repository:

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140547 Files:

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2339 +Req->getConstraintExpr()->getSourceRange(), Satisfaction)) + TransConstraint = Result[0]; +

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. usaxena95 marked an inline comment as done. Closed by commit rGb3ce87285186: Make evaluation of nested requirement consistent with requires expr. (authored by

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 484013. usaxena95 added a comment. Herald added a subscriber: arphaman. Removed use of SubstitutionDiagnostic from NestedRequirement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 478819. usaxena95 added a comment. Remove unintended whitespaces and new lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files:

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 478818. usaxena95 added a comment. Removed extraneous colons from diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files:

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:428 + : Requirement(RK_Nested, +Constraint && Constraint->isInstantiationDependent(), +Constraint && Constraint->containsUnexpandedParameterPack(),

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 478814. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/ https://reviews.llvm.org/D138914 Files:

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 updated this revision to Diff 478658. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added tests. Fixed regressions in diagnositcs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138914/new/

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 abandoned this revision. usaxena95 added a comment. Second attempt along the lines of the last comment: https://reviews.llvm.org/D138914 PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137712/new/ https://reviews.llvm.org/D137712

[PATCH] D138914: Make evaluation of nested requirement consistent with requires expr.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: https://github.com/llvm/llvm-project/issues/45563 template concept True = true; template concept C1

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 added inline comments. Comment at: clang/include/clang/AST/ExprConcepts.h:103 + bool hasSubstitutionFailureInArgs() const { +return ArgsHasSubstitutionFailure; erichkeane wrote: > Does this really belong here instead of as a part of the >

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 updated this revision to Diff 475054. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed commented. Added Release notes. Removed infrastructure changes and deferred them to a future patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 updated this revision to Diff 474716. usaxena95 added a comment. Moving closer to show diagnostic of entity for which SFNIAE occurred. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137712/new/ https://reviews.llvm.org/D137712 Files:

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137712 Files:

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. Coincidentally 2 of the bugs were just fixed in b9a77b56d8 . I do not completely agree with the approach there though. We should be fixing the root cause instead of circumventing

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. My suggestion would be to properly handle cycles in `CheckConstraintSatisfaction`. This problem goes beyond cycles introduced by conversion. See #53213 and #44304

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. Not sure if this has come up already but this would still crash on template concept C = requires(T a) { foo(a); }; struct D1 { template D1(TO); }; struct D2 { friend void foo(D1); }; static_assert(C); as we only consider conversion to

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56099d242809: [clang] Do not hide base member using-decls with different template head. (authored by usaxena95). Changed prior to commit:

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 471086. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 added inline comments. Comment at: clang/test/SemaTemplate/concepts-using-decl.cpp:112 + expect<1>(baz{}.foo()); // expected-error {{call to member function 'foo' is ambiguous}} +} +} ilya-biryukov wrote: > Could you also check that `requires`

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 470505. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files:

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 470174. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files:

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 marked 4 inline comments as done. usaxena95 added a comment. I have switched to a version where we matched template heads only when they are constraints. This is for the moment to unblock the existing bugs and not break existing code prior to C++20. Let us continue the discussion over

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 469552. usaxena95 added a comment. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D136440: Do not hide base member using decls with different template head.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136440 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c87e12484b3: Fix crash in constraining partial specialization on nested template. (authored by usaxena95). Repository: rG LLVM Github Monorepo

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 updated this revision to Diff 468962. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136259/new/ https://reviews.llvm.org/D136259 Files:

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 updated this revision to Diff 468925. usaxena95 added a comment. Added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136259/new/ https://reviews.llvm.org/D136259 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: https://github.com/llvm/llvm-project/issues/53354 Repository: rG LLVM Github Monorepo

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

usaxena95 added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

usaxena95 added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added a comment. In D134529#3853086 , @BertalanD wrote: > Does it deserve a mention in the Potentially Breaking Changes section of the > release notes? You are right. I was thinking the same after this discussion. I will add this to the

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added a comment. In D134529#3852990 , @erichkeane wrote: > Note that @BertalanD noticed an issue with what I expect to be this patch: > https://godbolt.org/z/Wjb9rsEYG > > Can someone more knowledgable about this paper please make sure it is

[PATCH] D135608: Update implementation status of P2468R2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe66cfb63ceed: Update implementation status of P2468R2 (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D135608: Update implementation status of P2468R2

usaxena95 updated this revision to Diff 466571. usaxena95 marked an inline comment as done. usaxena95 added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135608/new/ https://reviews.llvm.org/D135608 Files:

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added a comment. Sent out https://reviews.llvm.org/D135608 to update implementation status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 ___

[PATCH] D135608: Update implementation status of P2468R2

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D135608 Files: clang/www/cxx_status.html Index:

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38b9d313e694: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For (authored by usaxena95). Repository: rG LLVM Github Monorepo

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 465686. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 Files:

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added inline comments. Comment at: clang/include/clang/Sema/Overload.h:1024 /// candidates for operator Op. - bool shouldAddReversed(OverloadedOperatorKind Op); + bool mayAddReversed(OverloadedOperatorKind Op); ilya-biryukov wrote: >

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 465393. usaxena95 marked 11 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 Files:

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:887 -bool OverloadCandidateSet::OperatorRewriteInfo::shouldAddReversed( -OverloadedOperatorKind Op) { ilya-biryukov wrote: > Why do we need to move this from `OperatorRewriteInfo`

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 464012. usaxena95 added a comment. Added test for static operator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 Files: clang/docs/ReleaseNotes.rst

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 464010. usaxena95 marked 7 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/ https://reviews.llvm.org/D134529 Files:

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 updated this revision to Diff 463237. usaxena95 added a comment. Added better diagnostic for non-const symmetric operator==. Added release notes. Updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134529/new/

[PATCH] D134529: [C++20][Clang] P2468R2 The Equality Operator You Are Looking For

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2468r2.html. Primarily we now accept template

[PATCH] D133299: [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. Sorry I missed this. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:487-497 { // Switch caller's context with LSPServer's background context.

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7eec3824656: [clang] Skip re-building lambda expressions in parameters to consteval fns. (authored by usaxena95). Changed prior to commit:

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 457546. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments and added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 added a comment. Gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 456745. usaxena95 added a comment. This actually fixes two more issues. Update release notes and add more documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 456739. usaxena95 added a comment. Add some test with expected errors as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132945 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 456685. usaxena95 added a comment. new line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132945 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp

  1   2   3   4   5   >