[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

gargvaibhav64 added a comment. Thanks. I incorporated all the changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86514/new/ https://reviews.llvm.org/D86514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

gargvaibhav64 updated this revision to Diff 288186. gargvaibhav64 marked 5 inline comments as done. gargvaibhav64 edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86514/new/ https://reviews.llvm.org/D86514 Files:

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

gargvaibhav64 updated this revision to Diff 287609. gargvaibhav64 edited the summary of this revision. gargvaibhav64 added a comment. Resolve a typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86514/new/ https://reviews.llvm.org/D86514 Files:

[PATCH] D86514: Correctly parse LateParsedTemplates in case of multiple dependent modules

gargvaibhav64 created this revision. gargvaibhav64 added reviewers: rsmith, v.g.vassilev. Herald added a project: clang. Herald added a subscriber: cfe-commits. gargvaibhav64 requested review of this revision. While parsing LateParsedTemplates, Clang assumes that the Global DeclID matches with

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 287060. gargvaibhav64 added a comment. I updated the -triple option to x86_64-pc-windows-msvc (as it was more consistent with current tests). I also updated the path to Unix style in the -I option. CHANGES SINCE LAST ACTION

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 added a comment. In D83174#2230546 , @aaron.ballman wrote: > LGTM, thank you for the fix! Do you need someone to commit on your behalf? If > so, please be sure you're fine with the license agreement and let us know > what name and email

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 287004. gargvaibhav64 marked an inline comment as done. gargvaibhav64 added a comment. Updated the regex to be less-greedy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files:

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 286786. gargvaibhav64 added a comment. The test is now working properly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files: clang/lib/Serialization/ASTReaderDecl.cpp

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 added a comment. Hi everyone, are there any more changes required to this review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 ___ cfe-commits mailing list

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 278399. gargvaibhav64 added a comment. The tests weren't failing for me. So, we are possibly missing test coverage. I have made the change now. Also, I would like to add that the current test present in this diff does not fail in the existing system

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 277022. gargvaibhav64 marked 3 inline comments as done. gargvaibhav64 added a comment. Incorporated the changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files:

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 276680. gargvaibhav64 marked 3 inline comments as done. gargvaibhav64 added a comment. Added a new attribute instead of using the previous one CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files:

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 updated this revision to Diff 276351. gargvaibhav64 edited the summary of this revision. gargvaibhav64 added a comment. I incorporated the changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83174/new/ https://reviews.llvm.org/D83174 Files:

[PATCH] D83174: Teach AttachPreviousImpl to inherit MSInheritanceAttr attribute

gargvaibhav64 created this revision. gargvaibhav64 added reviewers: rsmith, v.g.vassilev. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit attaches teaches ASTDeclReader::attachPreviousDecl to successfully merge two Decl's when one contains an inheritable