[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-08 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D82659#2138228 , @michele.scandale wrote: > In D82659#2136999 , @clementval > wrote: > > > Looks good but just one question ... When clang is built as standalone it > > does not

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-07 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D82659#2136909 , @michele.scandale wrote: > Why `omp_gen` is now a dependency of `clang-tablegen-targets` rather than > being in the `LLVM_COMMON_DEPENDS` list like `clang-tablegen-targets`? > > Moreover I've noticed that

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-03 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D82659#2130022 , @simon_tatham wrote: > @jdoerfert , @clementval : over in D83032 > is a polished-up version of the script I used to check where the missing deps > needed to go. Might be

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-01 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. @simon_tatham Can you just update the description so it is consistent with your fix when it lands? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D82659: Fix missing build dependency on omp_gen.

2020-07-01 Thread Valentin Clement via Phabricator via cfe-commits
clementval accepted this revision. clementval added a comment. LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be removed right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

2020-06-30 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D81098#2112159 , @ABataev wrote: > LG Since this revision landed two tests are failing. ` libomp.env::kmp_set_dispatch_buf.c` and `libomp.worksharing/for::kmp_set_dispatch_buf.c`. It was also reported on the mailing

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-26 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked an inline comment as done. clementval added a comment. In D81736#2117858 , @thakis wrote: > This seems to cause build errors sometimes when buildling libclang. Maybe > there are more missing dependencies? Example failure: >

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

2020-06-25 Thread Valentin Clement via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5b9ce07a761f: [openmp] Use Directive_enumSize instead of OMPD_unknown position (authored by clementval). Changed prior to commit: https://reviews.llvm.org/D82518?vs=273216=273327#toc Repository: rG

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

2020-06-25 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 2 inline comments as done. clementval added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:583 OpenMPDirectiveKind DKind) { - assert(DKind <= OMPD_unknown); + assert(unsigned(DKind) <= llvm::omp::Directive_enumSize); switch (DKind) {

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

2020-06-24 Thread Valentin Clement via Phabricator via cfe-commits
clementval updated this revision to Diff 273216. clementval added a comment. add unsigned cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82518/new/ https://reviews.llvm.org/D82518 Files: clang/lib/Basic/OpenMPKinds.cpp

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-24 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 3 inline comments as done. clementval added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:197 } return DKind < OMPD_unknown ? static_cast(DKind) : OMPD_unknown; vdmitrie wrote: > Should this

[PATCH] D82518: [openmp] Use Directive_enumSize instead of OMPD_unknown position

2020-06-24 Thread Valentin Clement via Phabricator via cfe-commits
clementval created this revision. clementval added reviewers: vdmitrie, jdoerfert, jdenny. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. Previously OMPD_unknown was last item in the Directive enumeration and its position was used in various

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-23 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 3 inline comments as done. clementval added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2 +set(LLVM_TARGET_DEFINITIONS OMP.td) +tablegen(LLVM OMP.h.inc --gen-directive-decls) +add_public_tablegen_target(omp_gen)

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-23 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 2 inline comments as done. clementval added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/CMakeLists.txt:2 +set(LLVM_TARGET_DEFINITIONS OMP.td) +tablegen(LLVM OMP.h.inc --gen-directive-decls) +add_public_tablegen_target(omp_gen)

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-22 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D81736#2107202 , @jdenny wrote: > My cmake skills are lacking. Why are there are so many new DEPENDS > relationships where there were none before? Is it because omp_gen is > generating a header file that's included

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-22 Thread Valentin Clement via Phabricator via cfe-commits
clementval requested review of this revision. clementval added a comment. @jdoerfert @jdenny I had to add a bunch of dependencies so that the file is generated correctly when needed. Do you have any feedback on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-22 Thread Valentin Clement via Phabricator via cfe-commits
clementval reopened this revision. clementval added a comment. This revision is now accepted and ready to land. Missing dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/ https://reviews.llvm.org/D81736

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-19 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. @jdoerfert @jdenny Should we wait until Monday to go ahead with this patch? I have several other patches that will follow this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-17 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 10 inline comments as done. clementval added a comment. @jdenny I will have a look at your suggestion to dump the name instead of the id. If it looks straight forward I will do it. Other comments were addressed. Thanks. Comment at:

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-16 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D81736#2096336 , @jdoerfert wrote: > In D81736#2095947 , @clementval > wrote: > > > In D81736#2093926 , @jdoerfert > > wrote: > > > > >

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-16 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. In D81736#2093926 , @jdoerfert wrote: > Assuming this passes all the tests, it looks good to me. Let's wait a day or > two for people to take a look though :) @jdoerfert Sure let's wait a bit. I see a failure because of some

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-15 Thread Valentin Clement via Phabricator via cfe-commits
clementval marked 3 inline comments as done. clementval added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:496 +def OMP_EndDeclareVariant : Directive<"end declare variant"> {} +def OMP_Unknown : Directive<"unknown"> {} jdoerfert wrote: >

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-12 Thread Valentin Clement via Phabricator via cfe-commits
clementval updated this revision to Diff 270481. clementval added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Keep same ordering than OMPKinds.def + add dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION