[PATCH] D82574: Merge TableGen files used for clang options

2020-07-10 Thread Valeriy Dmitriev via Phabricator via cfe-commits
vdmitrie added inline comments. Comment at: clang/include/clang/Driver/Options.td:3668 + HelpText<"Do not emit code that uses the red zone.">; +def dwarf_column_info : Flag<["-"], "dwarf-column-info">, + HelpText<"Turn on column location information.">; This

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-24 Thread Valeriy Dmitriev via Phabricator via cfe-commits
vdmitrie added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:197 } return DKind < OMPD_unknown ? static_cast(DKind) : OMPD_unknown; Should this be a comparison against llvm::omp::Directive_enumSize rather than