[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

NeHuang added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117355/new/ https://reviews.llvm.org/D117355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

NeHuang updated this revision to Diff 407877. NeHuang marked an inline comment as done. NeHuang added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117355/new/ https://reviews.llvm.org/D117355 Files:

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, amyk, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds the fix for undef virtual register reading failure when trap

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

NeHuang added a comment. - Comment at: clang/lib/Headers/altivec.h:19050 +} + +static __inline__ long __bcdcmpeq(vector unsigned char __a, Do we need to add a case for "__CR6_SO_REV"? It is defined in line 25 but not used. Comment at:

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae27ca9a6783: [PowerPC] PPC backend optimization on conditional trap intrustions (authored by NeHuang). Repository: rG LLVM Github Monorepo

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang updated this revision to Diff 387652. NeHuang added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 Files: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang marked 7 inline comments as done. NeHuang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp:1020 +// We can only do the optimization for the "reg + reg" form. +if (!(LiMI1 && (Opcode1 == PPC::LI || Opcode1 == PPC::LI8))) +

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

This revision was automatically updated to reflect the committed changes. NeHuang marked 5 inline comments as done. Closed by commit rG18fe0a0d9eb1: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics… (authored by NeHuang). Changed prior to commit:

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang updated this revision to Diff 385282. NeHuang marked 3 inline comments as done. NeHuang added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 Files:

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

NeHuang updated this revision to Diff 384768. NeHuang marked 3 inline comments as done. NeHuang added a comment. Address review comments from @nemanjai Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112285/new/ https://reviews.llvm.org/D112285

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

NeHuang updated this revision to Diff 384479. NeHuang marked 5 inline comments as done. NeHuang added a comment. Addressed review comments from @amy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112285/new/ https://reviews.llvm.org/D112285 Files:

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:131 +; CHECK: # %bb.0: +; CHECK-NEXT:tdi 3, 3, 32767 +; CHECK-NEXT:blr amyk wrote: > amyk wrote: > > nemanjai wrote: > > > Can we add

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

NeHuang updated this revision to Diff 383506. NeHuang added a comment. Addressed review comments from @nemanjai and @amyk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112285/new/ https://reviews.llvm.org/D112285 Files:

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112285: [PowerPC] PPC backend optimization to lower int_ppc_tdw/int_ppc_tw intrinsics to TDI/TWI machine instructions

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds the backend optimization to match XL behavior for the two builtins

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. Thanks. LGTM. One minor can be addressed when commit it. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c:71 + + /*shift = 31, mask = 0x1FF =

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

NeHuang added a comment. Please check and add a test in `clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c` with `shift` as a variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111229/new/ https://reviews.llvm.org/D111229

[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-error.c:46 unsigned int mask; - unsigned int res = __builtin_ppc_rlwnm(ui, shift, 7); // expected-error {{argument to '__builtin_ppc_rlwnm' must be a constant integer}} + unsigned int res =

[PATCH] D110935: [NFC] Update vec_extract builtin signatures to take signed int.

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. LTGM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110935/new/ https://reviews.llvm.org/D110935

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang updated this revision to Diff 378284. NeHuang added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111434/new/ https://reviews.llvm.org/D111434 Files: llvm/lib/Target/PowerPC/PPCMIPeephole.cpp

[PATCH] D111434: [PowerPC] PPC backend optimization on conditional trap intrustions

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added projects: LLVM, PowerPC. Herald added subscribers: shchenz, JDevlieghere, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds PPC back end optimization to analyze the

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e1aaf18af6c: [PowerPC] Mark splat immediate instructions as rematerializable (authored by NeHuang). Changed prior to commit: https://reviews.llvm.org/D108823?vs=369101=374892#toc Repository: rG

[PATCH] D109599: [PowerPC][MMA] Allow MMA builtin types in pre-P10 compilation units

NeHuang added inline comments. Comment at: clang/test/Sema/ppc-mma-builtins.c:1 +// RUN: %clang_cc1 -triple powerpc64le-unknown-unknown -target-cpu pwr10 \ +// RUN: -target-feature -mma -fsyntax-only %s -verify can you please add `// REQUIRES:

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

NeHuang added a comment. Do we already have a backend test case for `fdiv` emitting a software estimate when `-Ofast` is used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959

[PATCH] D110273: [PowerPC] Fix lharx and lbarx builtin signatures

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond.c:27 char test_lbarx(volatile unsigned char *a) { // CHECK-LABEL: @test_lbarx Do you also need to update the input argument type here as well to match

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a226529e2cf: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields (authored by NeHuang). Repository: rG LLVM Github

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-int128.c:4 +// RUN: -triple powerpc64-unknown-unknown -target-cpu pwr8 \ +// RUN: -emit-llvm %s -o - -U__XL_COMPAT_ALTIVEC__ | FileCheck %s +// RUN: %clang_cc1 -target-feature +altivec -target-feature

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

NeHuang updated this revision to Diff 370428. NeHuang added a comment. Address review comments - typo update - use proper mcpu in the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108302/new/ https://reviews.llvm.org/D108302 Files:

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

NeHuang updated this revision to Diff 369531. NeHuang added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108302/new/ https://reviews.llvm.org/D108302 Files: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e5c17d19e37: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and… (authored by NeHuang). Repository: rG LLVM Github

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, lei, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya, qcolombet. NeHuang requested review of this revision. This patch marks splat immediate instructions `XXSPLTIDP` and

[PATCH] D108702: [PowerPC][NFC] Rename P10 builtins vec_clrl, vec_clrr to vec_clr_first and vec_clr_last

NeHuang created this revision. NeHuang added reviewers: amyk, lei, stefanp, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, nemanjai. NeHuang requested review of this revision. Herald added a project: clang. This patch renames the vector clear left/right

[PATCH] D108302: [PowerPC] Fixed the crash due to early if conversion with fixed CR fields.

NeHuang created this revision. NeHuang added reviewers: stefanp, nemanjai, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds a fix to do early if conversion to select when conditional branch

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

This revision was automatically updated to reflect the committed changes. Closed by commit rG99e00663d4cd: [PowerPC] Fix return address computation for __builtin_return_address (authored by NeHuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

NeHuang updated this revision to Diff 365761. NeHuang added a comment. Address review comment from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107646/new/ https://reviews.llvm.org/D107646 Files:

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

NeHuang accepted this revision. NeHuang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107138/new/ https://reviews.llvm.org/D107138 ___ cfe-commits mailing list

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107461/new/ https://reviews.llvm.org/D107461 ___ cfe-commits mailing list

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

NeHuang added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107002/new/ https://reviews.llvm.org/D107002 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

NeHuang updated this revision to Diff 365470. NeHuang added a comment. Address review comments on the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107646/new/ https://reviews.llvm.org/D107646 Files:

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

NeHuang updated this revision to Diff 364856. NeHuang added a comment. - Rebased with ToT - Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107646/new/ https://reviews.llvm.org/D107646 Files:

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-swdiv.c:17 +// CHECK-LABEL: @test_swdiv( +// CHECK:[[TMP0:%.*]] = load double, double* @a, align 8 +// CHECK-NEXT:[[TMP1:%.*]] = load double, double* @b, align 8 nit:

[PATCH] D107461: [PowerPC] Do not define __PRIVILEGED__

NeHuang added inline comments. Comment at: clang/test/Driver/ppc-mprivileged-support-check.c:25 +// HASPRIV: test() #0 { +// HASPRIV: attributes #0 { +// HASPRIV-SAME: +privileged maybe check for `attributes #0 = {` Repository: rG LLVM Github Monorepo

[PATCH] D107646: [PowerPC] Fix the frame addresss computing return address for `__builtin_return_address`

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. When depth > 0, callee frame address is used to compute the return address of

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:45 + // CHECK-AIX-NEXT: ret { double, double } %.fca.1.insert + return __cmplxl(lda, ldb); +} nemanjai wrote: > We really only need this test case and we should be

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/O3-pipeline.ll:211 ret void -} \ No newline at end of file +} unrelated change? Comment at: llvm/test/CodeGen/PowerPC/int-ppc-ftdivdp.ll:7 +; RUN: llc

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:1 +// RUN: %clang_cc1 -O2 -triple powerpc64-unknown-unknown \ +// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s `// REQUIRES: powerpc-registered-target`

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

NeHuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3426 + case PPC::BI__builtin_ppc_addex: { +if (SemaFeatureCheck(*this, TheCall, "power9-vector", + diag::err_ppc_builtin_only_on_arch, "9") || I think we

[PATCH] D106817: [PowerPC] Changed sema checking range for tdw td builtin

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106817/new/ https://reviews.llvm.org/D106817

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. NeHuang marked an inline comment as done. Closed by commit rG26ea4a443243: [PowerPC] Add PowerPC __stbcx builtin and intrinsic for XL compatibility (authored by

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

NeHuang marked an inline comment as done. NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:31 + return __builtin_ppc_stbcx(c_addr, c); +} lei wrote: > Why not just add this tc to >

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

NeHuang updated this revision to Diff 360803. NeHuang added a comment. - Addressed review comments from Lei - Rebased the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106484/new/ https://reviews.llvm.org/D106484 Files:

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. This

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

NeHuang added subscribers: jroelofs, NeHuang. NeHuang added a comment. @jroelofs committed `f6769b663a0d4432b5e00e0c03904a5dfba7b077` to move the backend test cases from `CodeGen` -> `CodeGen/PowerPC` so they don't fail when the PPC backend isn't built. Repository: rG LLVM Github Monorepo

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang added a comment. Thanks @jroelofs for moving the test cases! Those cases were added in https://reviews.llvm.org/D105946 and I have notified the author. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a762f93f816: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL… (authored by NeHuang). Repository: rG LLVM Github

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 360109. NeHuang added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang marked 4 inline comments as done. NeHuang added a comment. Rebased the patch with ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 ___ cfe-commits

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 359843. NeHuang added a comment. Address review comments from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 Files:

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

NeHuang accepted this revision. NeHuang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 ___ cfe-commits mailing list

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 359467. NeHuang added a comment. Herald added subscribers: llvm-commits, hiraditya. Address review comment to rework 32 bit handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/

[PATCH] D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. NeHuang marked an inline comment as done. Closed by commit rG4eb107ccbad7: [PowerPC] Add PowerPC population count, reversed load and store related… (authored by

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd40e8091bd1f: [PowerPC] Add PowerPC rotate related builtins and emit target independent code… (authored by NeHuang). Changed prior to commit:

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang updated this revision to Diff 358761. NeHuang marked 4 inline comments as done. NeHuang added a comment. Address review comments from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104744/new/ https://reviews.llvm.org/D104744

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang marked an inline comment as done. NeHuang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15081 } + case PPC::BI__builtin_ppc_cmpb: { +llvm::Type *Ty = Ops[0]->getType(); NeHuang wrote: > nemanjai wrote: > > I find it rather

[PATCH] D106021: [PowerPC] Add PowerPC population count, reversed load and store related builtins and instrinsics for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15081 } + case PPC::BI__builtin_ppc_cmpb: { +llvm::Type *Ty = Ops[0]->getType(); nemanjai wrote: > I find it rather surprising that we are emitting this complex sequence for >

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18c19414eb70: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for… (authored by NeHuang). Changed prior to commit:

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 358397. NeHuang marked 4 inline comments as done. NeHuang added a comment. Addressed review comments from Nemanja. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10e0cdfc6526: [PowerPC][NFC] Power ISA features for Semachecking (authored by NeHuang). Changed prior to commit:

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-multiply.ll:9 +; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \ +; RUN: -mcpu=pwr9 < %s | FileCheck %s --check-prefix=CHECK-64 + amyk wrote: > Does it

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added a comment. Need to merge with https://reviews.llvm.org/D105501 changes once approved for pwr9 (or later processor) only sema checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 357626. NeHuang added a comment. Remove entry check in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3356 + case PPC::BI__builtin_ppc_maddld: +return SemaFeatureCheck(*this, TheCall, "power9-vector", +diag::err_ppc_builtin_only_on_pwr9); amyk wrote: >

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 357625. NeHuang marked 3 inline comments as done. NeHuang added a comment. Address review comments on test case and remove change not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang added a comment. gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104744/new/ https://reviews.llvm.org/D104744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added a comment. gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

NeHuang accepted this revision. NeHuang added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

NeHuang resigned from this revision. NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-conversionfunc.c:2 +// RUN: %clang_cc1 -O2 -triple powerpc64-unknown-unknown \ +// RUN: -emit-llvm %s -o - -target-cpu pwr8 | FileCheck %s +// RUN:

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 356701. NeHuang marked 4 inline comments as done. NeHuang added a comment. Address review comments on the test case. Target cpu sema checking covered in front end test cases. will keep current coverage in backend test. Repository: rG LLVM Github Monorepo

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. This revision is now accepted and ready to land. Overall LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105236/new/ https://reviews.llvm.org/D105236

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-LoadReseve-StoreCond-64bit-only.c:1 +// RUN: not %clang_cc1 -triple=powerpc-unknown-aix -O2 -S -emit-llvm %s -o - 2>&1 |\ +// RUN: FileCheck %s --check-prefix=CHECK32-ERROR

[PATCH] D105236: [PowerPC] Implament Load and Reserve and Store Conditional Builtins

NeHuang added a comment. Please add the sema check & error test case for the two 64 bit only builtins `ldarx` and `stdcx` Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64-only.ll:10 +declare i64 @llvm.ppc.ldarx(i8*) +define dso_local i64

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-sync.c:240 +void test_icbt() { + __icbt(c); } From the document, `__icbt` only valid when -qarch is set to target pwr8 or higher processors. It looks like target cpu sema

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

NeHuang added inline comments. Comment at: llvm/test/CodeGen/builtins-ppc-xlcompat-fp.ll:18 + +define dso_local double @test_fsel(double %a, double %b, double %c) local_unnamed_addr #0 { +; CHECK-PWR7-LABEL: test_fsel you can remove `#0`, `#1` and `#2`

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

NeHuang added a comment. Overall looks good. Some nits as below. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-fp.c:9 +// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s + +double test_fric(double a) { - You can define three extern variables for

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

NeHuang requested changes to this revision. NeHuang added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:32 -// builtins for compatibility with the XL compiler +// XL Compatibility built-ins

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, lei, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton. NeHuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is in a

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang updated this revision to Diff 354082. NeHuang added a comment. - Rebased the patch with ToT and the patch https://reviews.llvm.org/D102875 - Create the patch with all contexts. (Thanks @qiucf) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 354081. NeHuang added a comment. - Added Sema check for the pwr9 only builtins and updated the test cases. - Rebased the patch with ToT. - Cleaned up the test cases and address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D104744: [PowerPC] Add PowerPC rotate related builtins and emit target independent code for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, PowerPC. NeHuang added projects: LLVM, clang. Herald added subscribers: shchenz, kbarton. NeHuang requested review of this revision. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide

[PATCH] D104664: [PowerPC][NFC] Clean up builtin sema checks

NeHuang accepted this revision. NeHuang added a comment. This revision is now accepted and ready to land. LGTM. Please give it some time (~24hrs) before commit to wait for the other reviewers' comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 352560. NeHuang added a comment. - Add AIX 32&64 bit run line checks (front and back end test cases) - Create builtin-ppc-xlcompat-error.c for arguments related error check, add error test case for `__builtin_ppc_cmprb` - Remove 32 bit linux run line checks

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 351989. NeHuang added a comment. Rebased the patch with changes in https://reviews.llvm.org/D104125 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 Files:

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 350991. NeHuang added a comment. - Renamed the XLCompat builtin as `__builtin_ppc_*` and add them to `definedXLCompatMacros` and update the test cases. - Report error in SemaChecking when 64 bit only builtins run on a 32 bit target and update the test

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. NeHuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is patch is in a series of patches to provide builtins for

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46475a79f85b: [AIX][TLS] Diagnose use of unimplemented TLS models (authored by NeHuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang updated this revision to Diff 344258. NeHuang added a comment. Address review comment for the diagnostic message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070 Files:

[PATCH] D102070: [AIX][TLS] Diagnose use of unimplemented TLS models

NeHuang updated this revision to Diff 343743. NeHuang added a comment. Addressed review comment for the diagnostic message and update the test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102070/new/ https://reviews.llvm.org/D102070

  1   2   >