[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

vit9696 accepted this revision. vit9696 added a comment. This revision is now accepted and ready to land. Looks good to me, thank you! Comment at: clang/test/Driver/emulated-tls.cpp:57 +// LTO related checks +//LTO_NOEMUTLS: plugin-opt=-emulated-tls=0 +//LTO_NOEMUTLS-NOT:

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

vit9696 added a comment. Got it. To be honest, I cannot imagine a situation where one would prefer to keep separate behaviour, and with GCC it would be exactly just one. In my view, if we introduce -fprofile-prefix-map, it should rather mirror the entire -fcoverage-prefix-map behaviour, not

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

vit9696 added a comment. In D124767#3486286 , @keith wrote: > Based on the issue it sounds like this should be gated behind a new > `-fprofile-prefix-map` flag? I assume we'd also want `-ffile-prefix-map` to > apply to it as well, similar to the

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

vit9696 updated this revision to Diff 426414. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124767/new/ https://reviews.llvm.org/D124767 Files: clang/lib/CodeGen/CodeGenModule.cpp Index: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D124767: [Clang] Map .gcda paths according to -fcoverage-prefix-map

vit9696 created this revision. vit9696 added reviewers: keith, phosek. Herald added a project: All. vit9696 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://github.com/llvm/llvm-project/issues/54670 Repository: rG LLVM Github

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 accepted this revision. vit9696 added a comment. This revision is now accepted and ready to land. Actually thanks for adding C checks too. The new revision also looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 accepted this revision. vit9696 added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 added a comment. I noticed a typo in the file, but the rest looks good now. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:61 .Case("a2q", "a2q") +.Case("8548", "e500") +.Case("e500", "e500") That looks like a typo to me.

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 added a comment. Yes, that's the point, since 8548 is an alias. A side note regarding SPE support. I am currently upgrading to LLVM 9.0 and I discovered that this patch was not committed anyhow at all: https://reviews.llvm.org/D54583#1444288 Repository: rC Clang CHANGES SINCE LAST

[PATCH] D67787: Add 8548 CPU definition and attributes

vit9696 added a comment. @jhibbits Should not the test in test/Preprocessor/init.c also ensure that `__SPE__` and `__NO_FPRS__` macros are defined with CPU 8548? The rest looks good to me, thank you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/