[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce7eb2e05544: [Coroutines] Avoid creating conditional cleanup markers in suspend block (authored by weiwang). Repository: rG LLVM Github Monorepo

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang updated this revision to Diff 501205. weiwang added a comment. add target triple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144680/new/ https://reviews.llvm.org/D144680 Files: clang/lib/CodeGen/CGCoroutine.cpp clang/lib/CodeGen/CGEx

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang updated this revision to Diff 500958. weiwang edited the summary of this revision. weiwang added a comment. add test case and some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144680/new/ https://reviews.llvm.org/D144680 Files:

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang added a comment. In D144680#4149149 , @ChuanqiXu wrote: > BTW, what is the conclusion for the concern about sanitizers? Would change > make sanitizers to perform false positive diagnostics? This change is limited to the `await.suspend` block, wh

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang created this revision. Herald added subscribers: ChuanqiXu, hoy, wenlei. Herald added a project: All. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144680 F

[PATCH] D122759: [time-report] Add timers to codegen actions

weiwang updated this revision to Diff 419261. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122759/new/ https://reviews.llvm.org/D122759 Files: clang/include/clang/Frontend/FrontendAction.h clang/include/clang

[PATCH] D122759: [time-report] Add timers to codegen actions

weiwang created this revision. Herald added subscribers: ormris, hoy, wenlei. Herald added a project: All. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122759 File

[PATCH] D117605: [time-trace] Add optimizer and codegen regions to NPM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55d887b83364: [time-trace] Add optimizer and codegen regions to NPM (authored by weiwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D117605: [time-trace] Add optimizer and codegen regions to NPM

weiwang created this revision. Herald added subscribers: ormris, hoy, wenlei. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Optimizer and codegen regions were only added to legacy PM. Add them to NPM as well. Repository: rG L

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

This revision was automatically updated to reflect the committed changes. Closed by commit rGa075d6722283: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType (authored by weiwang). Changed prior to commit: https://reviews.llvm.org/D112481?vs=382375&id=388616#toc Repo

[PATCH] D112481: [Sema] fix nondeterminism in ASTContext::getDeducedTemplateSpecializationType

weiwang added a comment. This issue has been blocking our internal module re-enablement for some time now, and we really appreciate any feedback. We also wonder if only `DeducedTemplateSpecializationType` is affected or it could also happen to other types. Repository: rG LLVM Github Monorep

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

This revision was automatically updated to reflect the committed changes. Closed by commit rGb283d55c90dd: [openmp] Emit deferred diag only when device compilation presents (authored by weiwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/n

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

weiwang added a comment. In D109175#2989997 , @yaxunl wrote: > In D109175#2989823 , @weiwang wrote: > >> In D109175#2987048 , @jdoerfert >> wrote: >> >>> In D109175#29867

[PATCH] D109175: [openmp] Emit deferred diag only when device compilation presents

weiwang added a comment. In D109175#2987048 , @jdoerfert wrote: > In D109175#2986782 , @yaxunl wrote: > >> I agree with Johannes and Alexey that deferred diags are only needed when >> LangOpts.OMPTargetTriples.em

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang updated this revision to Diff 370630. weiwang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D109175 Files: clang/lib/Sema/SemaDecl.cpp clang/test/OpenMP/declare_target_messag

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980900 , @jdoerfert wrote: > In D109175#2980806 , @weiwang wrote: > >> In D109175#2980744 , @jdoerfert >> wrote: >> >>> Why do we nee

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980744 , @jdoerfert wrote: > Why do we need this flag, is the absence of -fopenmp-targets not sufficient? Just double checked, this is the full omp related options currently in use: "-fopenmp" "-fopenmp-version=3

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. In D109175#2980446 , @lebedev.ri wrote: > In D109175#2980333 , @weiwang wrote: > >> Our internal codebase never uses the target directive. Once the deferred >> diags is bypassed, we obse

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang added a comment. Our internal codebase never uses the target directive. Once the deferred diags is bypassed, we observed 18% e2e build time improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109175/new/ https://reviews.llvm.org/D10

[PATCH] D109175: [openmp] Add clang cc1 option -fopenmp-skip-deferred-diags

weiwang created this revision. Herald added subscribers: hoy, dexonsmith, wenlei, dang, guansong, yaxunl. weiwang requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. There are cases where no target c

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

weiwang added a comment. In D70172#2964118 , @sugak wrote: > Hi @yaxunl! I'm working on upgrading a large codebase from LLVM-9 to LLVM-12. > I noticed on average 10% compilation speed regression that seems to be caused > this change. We use Clang modules

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2772717 , @yaxunl wrote: > In D101793#2772461 , @weiwang wrote: > >> Thanks for the approval! >> >> Just want to understand the list of "decls to check for deferred >> diagnost

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. Thanks for the approval! Just want to understand the list of "decls to check for deferred diagnostics" better, where are these decls coming from? And why do they need to be checked for warnings? I see decls from libc are in the list, but I have no idea why are they sel

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6b8320c0a63: [clang][AST] Improve AST Reader/Writer memory footprint (authored by weiwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang updated this revision to Diff 346866. weiwang added a comment. make both ASTReader::DeclsToCheckForDeferredDiags and Sema::DeclsToCheckForDeferredDiags SmallSetVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101793/new/ https://review

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2772021 , @yaxunl wrote: > In D101793#2769297 , @weiwang wrote: > >> Tried to make `Sema::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. >> The heap RSS did drop signifi

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. Tried to make `Sema::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. The heap RSS did drop significantly (from peak 100GB to 59GB) , but not as good as the current fix (peak 26GB), which makes `ASTReader::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. I th

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2760639 , @yaxunl wrote: > I think the root cause might be duplicated decls are added to > Sema::DeclsToCheckForDeferredDiags defined in > > https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Sema/Sema.

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. Finally dealt with the other issues I need to take care. Let's resume the discussion. I printed out the decls that are duplicated. The list of very long, but the top ones all seem from glibc headers. For example (the number after 'c:' is the duplication count), stat

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2735336 , @yaxunl wrote: > Decls in Sema::DeclsToCheckForDeferredDiags is supposed to be unique. > Therefore the fact that '1,734,387,685 out of 1,734,404,000 elements are the > same' is surprising. Did this happen wh

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. We've seen a huge memory footprint from AST Reader/Writer in a single CU with module enabled. Upon further analysis, the content of vector `DeclsToCheckForDeferredDiags` seems mostly redundant. In one case, 1,734,387,685 out of 1,734,404,000 elements are the same. While

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang created this revision. Herald added subscribers: hoy, wenlei. weiwang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Reduce memory footprint of AST Reader/Writer: 1. Adjust internal data containers' element type. 2. Switch to set

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. Ah, I am sorry. Thanks for fixing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93dc1b5b8cb2: [Remarks][2/2] Expand remarks hotness threshold option support in more tools (authored by weiwang). Repository: rG LLVM Github Monor

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. In D85808#2424588 , @tejohnson wrote: > lgtm with a couple of minor nits noted below that you can fix before > submitting Thanks for pointing them out. Really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 308536. weiwang added a comment. 1. Fix typo. 2. Minor order adjustment in testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Files: clang/include/clang/Basic/

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 308433. weiwang added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basi

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. Herald added a subscriber: hoy. @tejohnson @MaskRay Do you have other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 ___ cfe-c

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. In D85808#2403587 , @tejohnson wrote: > Thanks for adding the Driver test. I was thinking of something to test the > CompilerInvocation changes, similar to your test using opt, that ensures the > option has the desired behavior w

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 306256. weiwang added a comment. 1. Add clang test with remarks output. 2. Fix a missing dependency on PSI in legacy pass manager. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.o

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang updated this revision to Diff 305891. weiwang added a comment. update test case for clang option pass-through Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Files: clang/include/clang/Basic/CodeG

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang closed this revision. weiwang added a comment. Diff was committed, but did not close automatically. Manual close it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 _

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 301140. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/opt-re

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added a comment. @tejohnson @MaskRay Do you have other comments to the change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 ___ cfe-commits mailing lis

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 293296. weiwang added a comment. minor update to test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/t

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 293276. weiwang added a comment. 1. remove unreachable code 2. udpate test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/Com

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang marked an inline comment as done. weiwang added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:90 + } else { +if (Output.isFilename()) + F = Output.getFilename(); MaskRay wrote: > The output selection logic is untested.

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 292676. weiwang added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Drive

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 288447. weiwang added a comment. remove redundant check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:596 + // Handle remark diagnostics on screen options: '-Rpass-*'. + if (usesRpassOptions(Args)) +renderRpassOptions(Args, CmdArgs); tejohnson wrote: > Is this guard needed

[PATCH] D85808: [Remarks][2/2] Expand remarks hotness threshold option support in more tools

weiwang added inline comments. Comment at: llvm/lib/Analysis/OptimizationRemarkEmitter.cpp:103 BFI = &getAnalysis().getBFI(); - else +// Get hotness threshold from PSI. This should only happen once. +if (Context.isDiagnosticsHotnessThresholdSetFromPSI()) { -

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 286468. weiwang marked an inline comment as done. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang marked 5 inline comments as done. weiwang added inline comments. Comment at: clang/include/clang/Driver/Driver.h:638 +/// This checks for clang specific R-value ('-Rpass-*') group. +bool hasRpassOptions(const llvm::opt::ArgList &Args); + bruno wrote: > Ni

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 286467. weiwang added a comment. coding style change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Dri

[PATCH] D85810: [clang] Pass-through remarks options to linker

weiwang updated this revision to Diff 286204. weiwang added a comment. move some unrelated change into parent diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/Driver

[PATCH] D85808: [remarks] Optimization remarks hotness filtering from profile summary

weiwang updated this revision to Diff 286203. weiwang added a comment. update: 1. reorganize code splitting with parent diff. 2. format and style change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85808/new/ https://reviews.llvm.org/D85808 Fil

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang updated this revision to Diff 286124. weiwang added a comment. Herald added subscribers: dang, arichardson, emaste. Herald added a reviewer: espindola. update: 1. add `--plugin-opt` alias for remarks in lld 2. handle both lld and ld.gold pass-through 3. simplify target checking logic 4. c

[PATCH] D85808: [remarks] Optimization remarks hotness filtering from profile summary

weiwang added a comment. In D85808#2214272 , @tejohnson wrote: > In D85808#2212297 , @weiwang wrote: > >> This is the 3rd of 3 dependent patches: >> >> 1. [lld] Enable remarks hotness filtering in lld: >> https://r

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang updated this revision to Diff 285205. weiwang added a comment. update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang abandoned this revision. weiwang added a comment. Diff has been split into 3 smaller ones: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks] Optimization remarks h

[PATCH] D85808: [remarks] Optimization remarks hotness filetering from profile summary

weiwang added reviewers: wenlei, hoyFB. weiwang added a comment. This is the the 3rd of 3 dependent patches: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks] Optimization

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang added reviewers: wenlei, hoyFB. weiwang added a comment. This is the the 2nd of 3 dependent patches: 1. [lld] Enable remarks hotness filtering in lld: https://reviews.llvm.org/D85809 2. [clang] Pass-through remarks options to lld: https://reviews.llvm.org/D85810 3. [remarks] Optimization

[PATCH] D85810: [clang] Pass-through remarks options to lld

weiwang created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. weiwang requested review of this revision. Propagate driver commandline remarks options to link. Pass-through happens when: 1. LTO is enabled; 2. Single arch target is specified; 3. Th

[PATCH] D85808: [remarks] Optimization remarks hotness filetering from profile summary

weiwang created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, hiraditya, eraman, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added projects: clang, LLVM. weiwang requested review of this revisi

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang added a comment. still waiting for inputs. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84246/new/ https://reviews.llvm.org/D84246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang updated this revision to Diff 281077. weiwang added a comment. Fix msvc build failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84246/new/ https://reviews.llvm.org/D84246 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang added a comment. I put everything together in a single diff so that it is easier to get the whole idea. The change itself is too big to go in as a single diff, and I'd like to get inputs on how to split it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, MaskRay, hiraditya, eraman, arichardson, inglorion, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added projects: clang, LLVM. Expand remarks hot