[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 236295. wwagner19 added a comment. To be honest, I'm not sure how to remedy this. So I just rebased all my commits into one and dropped the `git show HEAD -U99` into here. Please let me know if you need me to fix anything / open a new diff. CHANGES

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 236293. wwagner19 added a comment. The last diff was broken, this most recent one - Changes IsIncoming boolean to an enum - Refactors the matching path logic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64305/new/

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 added a comment. Hey @sammccall, any update here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64305/new/ https://reviews.llvm.org/D64305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 marked 2 inline comments as done. wwagner19 added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.cpp:153 +// Converts \pPath to a posix-style absolute, i.e. if it's a windows path +// then the backward-slash notation will be converted to forward

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 229969. wwagner19 marked 2 inline comments as done. wwagner19 added a comment. Awesome! I am not an LLVM committer, so if you could commit on my behalf that'd be great- although I'm not sure how LLVM handles squashing/merging, continuous integration,

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 marked 9 inline comments as done and an inline comment as not done. wwagner19 added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.cpp:153 +// Converts \pPath to a posix-style absolute, i.e. if it's a windows path +// then the backward-slash notation

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 229721. wwagner19 marked 5 inline comments as done. wwagner19 added a comment. Thanks for the second review Sam, I addressed most of your comments, notably: - Changed the bool IsIncoming to an enum - Fixed the "doxygen" comments, - Removed some redundant

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 227643. wwagner19 added a comment. Herald added a subscriber: usaxena95. Unfortunately, I had to take a bit of a hiatus there, but i'm back a few months later with an updated patch incorporating all of @sammccall 's feedback! Notably, - Windows paths are

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 marked 9 inline comments as done. wwagner19 added a comment. Thanks for all the feedback, Sam! I'll try and get an updated patch up sometime tomorrow. Comment at: clang-tools-extra/clangd/PathMapping.cpp:30 + const auto = V.kind(); + if (K == Kind::Object) { +

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 marked 2 inline comments as done. wwagner19 added a comment. Herald added a subscriber: ormris. Hey, This is my first proposed change to LLVM, so sorry if I messed anything up. The proposed changes here follow from discussion on clangd-dev (from janruary

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 created this revision. wwagner19 added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. Add path mappings to clangd which translate file URIs on inbound and outbound LSP messages.