[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao marked an inline comment as done. shixiao added inline comments. Comment at: clang-tools-extra/test/clang-tidy/modernize-concat-nested-namespaces.h:1 +#pragma once + alexfh wrote: > alexfh wrote: > > Please put the header under Inputs// directory to

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao added a comment. Could someone please take a look? I think I've addressed all of Jonas's comments above. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao added a comment. Ping =) @JonasToth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 205731. shixiao added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao added a comment. Ping =) @JonasToth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 203276. shixiao edited the summary of this revision. shixiao added a comment. Herald added subscribers: sunfish, aheejin, kristof.beyls, tpr, javed.absar. update commit summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 203275. shixiao added a comment. rebase, fix comments, enable for c++2a, add report for running the check on llvm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao marked 2 inline comments as done. shixiao added a comment. > Could you please run this check over LLVM and give a short report of your > finding? I would imagine that there is a lot of duplication, given the > include-heavy nature of big c++ code bases. Sure. I'll run it and report

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao added a comment. @JonasToth, does this look reasonable to you? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61989/new/ https://reviews.llvm.org/D61989 ___ cfe-commits mailing list

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 199942. shixiao added a subscriber: Eugene.Zelenko. shixiao added a comment. edit doc, add note in release notes, extend unit test to test transitive header includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao updated this revision to Diff 199940. shixiao marked 2 inline comments as done. shixiao edited the summary of this revision. shixiao removed a subscriber: Eugene.Zelenko. shixiao removed a project: clang-tools-extra. shixiao added a comment. elide braces for single-stmt if-s, extend unit

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

shixiao created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. For header files that pass the -header-filter, the modernize-concat-nested-namespaces check does not generate the expected warning and fix for un-concatenated namespaces. This diff