[PATCH] D76029: Summary: Fix DanglingHandleCheck to match conversion operator whose return type is a type alias, e.g. `std::string`'s conversion operator to `std::string_view`.

2020-03-11 Thread Xiaoyi Zhang via Phabricator via cfe-commits
zhangxy988 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zhangxy988 added a reviewer: alexfh. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76029 Files: clang-tools-extra/clang-tidy/bugprone/DanglingHandleCheck.cpp

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

2019-07-08 Thread Xiaoyi Zhang via Phabricator via cfe-commits
zhangxy988 marked an inline comment as done. zhangxy988 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/abseil-faster-strsplit-delimiter.cpp:55 + + absl::StrSplit("ABC", R"(A)"); + // CHECK-MESSAGES: [[@LINE-1]]:25: warning: absl::StrSplit() called with a

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

2019-07-08 Thread Xiaoyi Zhang via Phabricator via cfe-commits
zhangxy988 updated this revision to Diff 208500. zhangxy988 marked 2 inline comments as done. zhangxy988 added a comment. - Remove empty line and add assertion message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64151/new/

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

2019-07-03 Thread Xiaoyi Zhang via Phabricator via cfe-commits
zhangxy988 added a comment. I don't think I have commit access. Please commit it for me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64151/new/ https://reviews.llvm.org/D64151 ___

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

2019-07-03 Thread Xiaoyi Zhang via Phabricator via cfe-commits
zhangxy988 created this revision. zhangxy988 added a reviewer: gribozavr. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently it fails on cases like '\001'. Note: Since `StringLiteral::outputString` dumps most nonprintable characters in octal value, the exact string