[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

2023-01-19 Thread Xing Xue via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xingxue marked an inline comment as done. Closed by commit rGb05fa4faf64d: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified (authored by xingxue).

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

2023-01-19 Thread Xing Xue via Phabricator via cfe-commits
xingxue added inline comments. Comment at: clang/test/Driver/aix-ld.c:1027 +// RUN:-fopenmp \ +// RUN: | FileCheck --check-prefix=CHECK-FOPENMP-OMP %s +// CHECK-FOPENMP-OMP-NOT: warning: daltenty wrote: > nit: since the output for these tests are

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

2023-01-18 Thread Xing Xue via Phabricator via cfe-commits
xingxue updated this revision to Diff 490167. xingxue added a comment. Addressed comments. - added test scenarios for option `fopenmp` in `clang/test/Driver/aix-ld.c` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141862/new/

[PATCH] D141862: [clang][driver][AIX] Add OpenMP runtime if -fopenmp specified

2023-01-16 Thread Xing Xue via Phabricator via cfe-commits
xingxue created this revision. xingxue added reviewers: daltenty, cebowleratibm, kkwli0. xingxue added a project: LLVM. Herald added subscribers: guansong, yaxunl. Herald added a project: All. xingxue requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay.

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

2022-11-18 Thread Xing Xue via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfa7477eb87fd: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and… (authored by xingxue). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

2022-11-16 Thread Xing Xue via Phabricator via cfe-commits
xingxue added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:110 + // The AIX library functions frexpl, ldexpl, and modfl are for 128-bit + // 'long double'. Map to the 'double' versions if it is 64-bit 'long + // double' mode. daltenty wrote: >

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

2022-11-16 Thread Xing Xue via Phabricator via cfe-commits
xingxue updated this revision to Diff 475853. xingxue marked 5 inline comments as done. xingxue edited the summary of this revision. xingxue added a comment. Addressed comments: - rename `AIXLongDoubleBuiltins` to `AIXLongDouble64Builtins` - test IR output instead of assembly output - fix a typo

[PATCH] D137986: [Clang][CodeGen][AIX] Map __builtin_frexpl, __builtin_ldexpl, and __builtin_modfl to 'double' version lib calls in 64-bit 'long double' mode

2022-11-14 Thread Xing Xue via Phabricator via cfe-commits
xingxue created this revision. xingxue added reviewers: rjmccall, hubert.reinterpretcast, daltenty, cebowleratibm. xingxue added a project: LLVM. Herald added a project: All. xingxue requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX

[PATCH] D129165: [AIX][clang/test] Set/propagate AIXTHREAD_STK for AIX

2022-07-05 Thread Xing Xue via Phabricator via cfe-commits
xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM; thanks! The IBM OpenMP runtime sets the default thread stack size to 4MiB on AIX as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

2020-02-13 Thread Xing Xue via Phabricator via cfe-commits
xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72736/new/ https://reviews.llvm.org/D72736 ___ cfe-commits mailing list

[PATCH] D63786: Print NULL as "(null)" in diagnostic message

2019-06-26 Thread Xing Xue via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL364462: Print NULL as (null) in diagnostic message (authored by xingxue, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

2019-06-20 Thread Xing Xue via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL363939: AIX system headers need stdint.h and inttypes.h to be re-enterable (authored by xingxue, committed by ). Changed

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

2019-06-11 Thread Xing Xue via Phabricator via cfe-commits
xingxue added a comment. Hi @mclow.lists, Do you have any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 ___ cfe-commits mailing list

[PATCH] D63041: [PlistSupport] Produce a newline to end plist output files

2019-06-10 Thread Xing Xue via Phabricator via cfe-commits
xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63041/new/ https://reviews.llvm.org/D63041 ___

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

2019-06-03 Thread Xing Xue via Phabricator via cfe-commits
xingxue updated this revision to Diff 202734. xingxue added a comment. Addressed comments: - Fixed typo _XOPEN_SOUECE->_XOPEN_SOURCE Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 Files:

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

2019-06-03 Thread Xing Xue via Phabricator via cfe-commits
xingxue marked 2 inline comments as done. xingxue added inline comments. Comment at: libcxx/test/std/depr/depr.c.headers/stdint_h.sh.cpp:21 +// Test that limits macros are available when is included with +// or without macro _XOPEN_SOUECE=700. +

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

2019-05-28 Thread Xing Xue via Phabricator via cfe-commits
xingxue marked an inline comment as done. xingxue added inline comments. Comment at: libcxx/include/stdint.h:16 +#endif // _STD_TYPES_T /* hubert.reinterpretcast wrote: > mclow.lists wrote: > > I don't think that this will do what you want it to. > > Is this

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

2019-05-28 Thread Xing Xue via Phabricator via cfe-commits
xingxue updated this revision to Diff 201746. xingxue added a comment. Updated comments explaining the scenario of the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 Files:

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

2019-05-23 Thread Xing Xue via Phabricator via cfe-commits
xingxue updated this revision to Diff 200967. xingxue added a comment. Herald added subscribers: jsji, jfb. Added test case `stdint_h.sh.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 Files:

[PATCH] D61530: Add AIX Version Macros

2019-05-16 Thread Xing Xue via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC360900: Add AIX Version Macros (authored by xingxue, committed by ). Changed prior to commit: https://reviews.llvm.org/D61530?vs=198056=199825#toc Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59741: [lit] Set shlibpath_var on AIX

2019-03-27 Thread Xing Xue via Phabricator via cfe-commits
xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59741/new/ https://reviews.llvm.org/D59741 ___

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

2019-03-15 Thread Xing Xue via Phabricator via cfe-commits
xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59233/new/ https://reviews.llvm.org/D59233 ___

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

2019-03-12 Thread Xing Xue via Phabricator via cfe-commits
xingxue created this revision. xingxue added reviewers: hubert.reinterpretcast, jasonliu, mclow.lists. xingxue added a project: LLVM. Herald added a reviewer: EricWF. Herald added subscribers: libcxx-commits, cfe-commits, christof. Herald added projects: clang, libc++. AIX system headers need