yamaguchi added a comment.
We have both explicitly and implicitly prebuilt modules, but this patch only
relates to implicit ones. I agree that our usecase is a bit unique where we're
installing and distributing implicitly built pcm, but I also imagine there
might be a usecase where you built im
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, dblaikie.
Previous code was comparing the location of "modulemap which
is currently loaded and gives a definition of current module"
and "the location of the modulemap where the current implicit module was built".
This check was
yamaguchi created this revision.
yamaguchi added a reviewer: thakis.
Herald added a subscriber: mgorny.
Generate Checkers.inc also under include/clang/Driver so that we can
include this file from Driver/CC1Options.td without making Driver's
tablegen output depending on StaticAnalyzer/Checker's tab
yamaguchi added a comment.
FYI, raw benchmarking data:
https://gist.github.com/yamaguchi1024/4f28406f51b413129cc762365fdd76c8
https://gist.github.com/yamaguchi1024/318b30db03adb10b7b230b706012a14c
https://reviews.llvm.org/D54097
___
cfe-commits mail
yamaguchi created this revision.
yamaguchi added a reviewer: rsmith.
ReadASTBlock was allocating extra memory by resizing vector for all
record decls, and half of them stayed nullptr without being loaded. For
us this part was crucial and this patch had large amount of memory
improvement.
About cl
yamaguchi closed this revision.
yamaguchi added a comment.
Landed in https://reviews.llvm.org/rL345121
https://reviews.llvm.org/D53589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345133: [autocompletion] Handle the space before pressing
tab (authored by yamaguchi, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53639?vs=170849&id=170856#toc
Repository:
rL L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345133: [autocompletion] Handle the space before pressing
tab (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53639?vs
yamaguchi updated this revision to Diff 170849.
yamaguchi added a comment.
Updated HasSpace, added comments, fixed typo in the commit message
https://reviews.llvm.org/D53639
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
yamaguchi created this revision.
yamaguchi added reviewers: teemperor, ruiu.
Distinguish "--autocomplete=-someflag" and "--autocomplete=-someflag,"
because the latter indicates that the user put space before pushing tab
which should end up in a file completion.
https://reviews.llvm.org/D53639
F
yamaguchi created this revision.
yamaguchi added reviewers: teemperor, ruiu.
There was a bug that when a flag ends with '=' and no value was suggested,
clang autocompletes the flag itself.
For example, in bash, it looked like this:
$ clang -fmodule-file=[tab]
-> $clang -fmodule-file=-fmodule-
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, v.g.vassilev.
This is a follow-up patch of
https://reviews.llvm.org/rL338503: [Modules] Do not emit relocation error when
-fno-validate-pch is set
File modification with modules is also fine for our usecase as we
want to reuse p
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338503: [Modules] Do not emit relocation error when
-fno-validate-pch is set (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, dblaikie, v.g.vassilev.
Clang emits error when implicit modules was relocated from the
first build directory. However this was biting our usecase where we copy
the contents of build directory to another directory in order to
distr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336660: [modules] Fix 37878; Autoload subdirectory
modulemaps with specific LangOpts (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
yamaguchi updated this revision to Diff 152876.
yamaguchi added a comment.
Delete a.out)
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/HeaderSearch.h
clang/lib/Frontend/CompilerInstance.cpp
clang/lib/Lex/HeaderSearch.cpp
clang/lib/Serialization/ASTReader.cpp
clang/tes
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
yamaguchi updated this revision to Diff 152875.
yamaguchi added a comment.
Add #import test and add branch AllowExtraModuleMapSearch when ModuleName was
from @import
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/HeaderSearch.h
clang/lib/Frontend/CompilerInstance.cpp
clan
yamaguchi updated this revision to Diff 152664.
yamaguchi added a comment.
use %clang_cc1 instead of %clang
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
clang/test/Modules/Inputs/autoload-subdirectory/a.h
clang/test/Modules/In
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
yamaguchi updated this revision to Diff 152240.
yamaguchi added a comment.
Add a test case
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
clang/test/Modules/Inputs/autoload-subdirectory/a.h
clang/test/Modules/Inputs/autoload-sub
yamaguchi updated this revision to Diff 152086.
yamaguchi added a comment.
Update commmit message and comment, add ObjC2
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
Index: clang/lib/Lex/HeaderSearch.cpp
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, aprantl, bruno.
Reproducer and errors:
https://bugs.llvm.org/show_bug.cgi?id=37878
lookupModule was falling back to loadSubdirectoryModuleMaps when it couldn't
find ModuleName in (proper) search paths. This was causing iteration
yamaguchi accepted this revision.
yamaguchi added a comment.
LGTM
https://reviews.llvm.org/D47273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330946: Add getDeserializationListener to ASTReader
(authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45921?vs=143441&id
yamaguchi added a comment.
Do you mean something like `addDeserializationListener` which create a
multiplex listener with an existing listener? I think that'll be good as well!
https://reviews.llvm.org/D45921
___
cfe-commits mailing list
cfe-commit
yamaguchi created this revision.
yamaguchi added reviewers: v.g.vassilev, rsmith, dblaikie, thakis.
We need to know if ASTReader already has a DeserializationListner or
not, and this also helps to create a multiplexing deserialization
listener if there is one already attached.
https://reviews.ll
yamaguchi updated this revision to Diff 138671.
yamaguchi added a comment.
@marsupial Thanks for the commment, found a bug in my script and fixed. Now
this patch removes only includes which are not used in each TU.
Repository:
rL LLVM
https://reviews.llvm.org/D44508
Files:
clang/lib/Drive
yamaguchi created this revision.
yamaguchi added a reviewer: dlj.
Herald added a subscriber: llvm-commits.
Clang compiles and test passes without these includes.
Repository:
rL LLVM
https://reviews.llvm.org/D44508
Files:
clang/lib/Driver/Driver.cpp
Index: clang/lib/Driver/Driver.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326889: Add Clang ReleaseNotes that --autocomplete breaks
backward compatibily (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
yamaguchi updated this revision to Diff 137352.
yamaguchi added a comment.
Fixed typos
https://reviews.llvm.org/D44191
Files:
clang/docs/ReleaseNotes.rst
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
++
yamaguchi created this revision.
yamaguchi added reviewers: teemperor, v.g.vassilev.
--autocomplete flag now handles all the flags passed to shell, and this
implementation breaks backward compatibily before Clang 6.0.
https://reviews.llvm.org/D44191
Files:
clang/docs/ReleaseNotes.rst
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326684: [Bash-autocompletion] Pass all flags in shell
command-line to Clang (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
yamaguchi accepted this revision.
yamaguchi added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D40234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
yamaguchi updated this revision to Diff 121449.
yamaguchi added a comment.
Made a trivial fix in the testcase
https://reviews.llvm.org/D39342
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/l
yamaguchi updated this revision to Diff 121444.
yamaguchi added a comment.
Herald added a subscriber: hiraditya.
Update diff. Pass all flags just with "," including values.
https://reviews.llvm.org/D39342
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
clang/test/Dr
yamaguchi added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:1171
+ StringRef TargetFlag = PassedFlags;
+ for (; TargetFlag.find(':') != StringRef::npos;) {
+StringRef CurFlag;
v.g.vassilev wrote:
> Why not a `while` loop?
I didn't have special
yamaguchi created this revision.
Previously, we passed "#" to --autocomplete to indicate to enable cc1
flags. For example, when -cc1 or -Xclang was passed to bash, bash
executed `clang --autocomplete=#-`.
However, this was not a good implementation because it depends -Xclang
and -cc1 parsing to s
yamaguchi accepted this revision.
yamaguchi added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks for the fix!
Repository:
rL LLVM
https://reviews.llvm.org/D37465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312018: [Bash-autocomplete] Refactor autocomplete code into
own function (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D37249?vs=113027&id=113118#toc
Repository:
rL LLVM
yamaguchi updated this revision to Diff 113027.
yamaguchi marked an inline comment as done.
yamaguchi added a comment.
Update diff. I agree that this is more generic.
https://reviews.llvm.org/D37249
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
Index: clang/lib/Dri
yamaguchi created this revision.
We wrote many codes in HandleImediateArgs, so I've refactored it into
handleAutocompletions.
https://reviews.llvm.org/D37249
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
Index: clang/lib/Driver/Driver.cpp
==
yamaguchi abandoned this revision.
yamaguchi added a comment.
https://reviews.llvm.org/D37217 has already landed, so we don't need this
anymore.
https://reviews.llvm.org/D37203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311971: [Bash-autocompletion] Add support for -std=
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36820?vs=111804&id=113009#toc
Repository:
rL LLVM
https://reviews.llvm
yamaguchi created this revision.
https://reviews.llvm.org/D36782 broke lld buildbots, because I've changed
OptionInfo's type
from ArrayRef to std::vector, so it became a copy, not a reference.
In this patch, I changed Table to static, so that it won't be freed
after the return. However, I'm not s
This revision was automatically updated to reflect the committed changes.
yamaguchi marked an inline comment as done.
Closed by commit rL311552: [Bash-autocompletion] Add support for static
analyzer flags (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36782?vs=11154
yamaguchi added a comment.
@ruiu
I addressed your comments in https://reviews.llvm.org/D36820, so please take a
look at it. Thank you!
https://reviews.llvm.org/D36782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
yamaguchi updated this revision to Diff 111804.
yamaguchi added a comment.
Update diff. Thank you for your comments!
https://reviews.llvm.org/D36820
Files:
clang/include/clang/Driver/Options.td
clang/test/Driver/autocomplete.c
llvm/utils/TableGen/OptParserEmitter.cpp
Index: llvm/utils/T
yamaguchi added inline comments.
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:319-320
OS << ", Values);\n";
OS << "(void)ValuesWereAdded;\nassert(ValuesWereAdded &&";
OS << " \"Couldn't add values to OptTable!\");\n";
}
r
yamaguchi updated this revision to Diff 111611.
yamaguchi marked 3 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36820
Files:
clang/include/clang/Driver/Options.td
clang/test/Driver/autocomplete.c
llvm/utils/TableGen/OptParserEmitter.cpp
Inde
yamaguchi added inline comments.
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:314
for (const std::string &Pref : R.getValueAsListOfStrings("Prefixes")) {
-OS << "bool ValuesWereAdded = ";
+OS << "ValuesWereAdded = ";
OS << "Opt.addValues(";
yamaguchi updated this revision to Diff 111549.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36820
Files:
clang/include/clang/Driver/Options.td
clang/test/Driver/autocomplete.c
llvm/utils/TableGen/OptParserEmitter.cpp
Inde
yamaguchi updated this revision to Diff 111548.
yamaguchi added a comment.
const char* Values -> const char *Values
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/include/llvm/Optio
yamaguchi updated this revision to Diff 111547.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/in
yamaguchi created this revision.
Add support for autocompleting values of -std= by including
LangStandards.def. This patch relies on https://reviews.llvm.org/D36782, and is
using two-stage
code generation.
https://reviews.llvm.org/D36820
Files:
clang/include/clang/Driver/Options.td
clang/t
yamaguchi added a comment.
@ruiu
I understand your concern. However by doing this (rather than building
functions for each flag), we will be able to get all information in OptTable
itself. It is true that this is quite fragile, but adding ValuesCode to new
flag is not complicated, so I believe
yamaguchi updated this revision to Diff 111457.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/in
yamaguchi updated this revision to Diff 111318.
yamaguchi marked 7 inline comments as done.
yamaguchi added a comment.
Update diff according to Raphael's comments.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test
yamaguchi created this revision.
Herald added a subscriber: hiraditya.
This is a patch for clang autocomplete feature.
It will collect values which -analyzer-checker takes, which is defined in
clang/StaticAnalyzer/Checkers/Checkers.inc, dynamically.
First, from ValuesCode class in Options.td, Tab
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310700: [Bash-autocompletion] Add --autocomplete flag to 5.0
release notes (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36567?vs=110518&id=110679#toc
Repository:
rL LLV
yamaguchi created this revision.
I thought we should add this information to release notes, because we
added a new flag to clang driver.
https://reviews.llvm.org/D36567
Files:
clang/docs/ReleaseNotes.rst
Index: clang/docs/ReleaseNotes.rst
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309794: [Bash-autocompletion] Add comment to test so that it
is easier to fix (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36209?vs=109283&id=109285#toc
Repository:
rL
yamaguchi updated this revision to Diff 109283.
yamaguchi added a comment.
Fixed typo.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Driver/au
yamaguchi updated this revision to Diff 109281.
yamaguchi added a comment.
Modified comment.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Dri
yamaguchi added a comment.
@ruiu
This test will break for instance, when someone add new value to
mrelocation-model because values has to be shown in row 78- 83 order, or when
someone made a new flags which start with `-Wno-invalid-pp-` because in row 96
only -Wno-invalid-pp-token is expected
yamaguchi updated this revision to Diff 109277.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Driver/a
yamaguchi created this revision.
clang/test/Driver/autocomplete.c is a test for --autocomplete, and this
test might break if people add/modify flags or HelpText. So I've add
comment for future developers so that they can fix this file according
to the change they had made.
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309113: [Bash-autocompletion] Show HelpText with possible
flags (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D35759?vs=107791&id=108267#toc
Repository:
rL LLVM
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309112: [Bash-completion] Fixed a bug that file doesn't
autocompleted after = (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D35763?vs=107787&id=108266#toc
Repository:
rL
yamaguchi added a comment.
@ruiu
Yeah, we are planning to merge this to 5.0, so that clang Driver interface will
be compatible among further versions.
https://reviews.llvm.org/D35759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
yamaguchi updated this revision to Diff 107791.
yamaguchi added a comment.
Update diff according to Rui's comment.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/lib/Option/OptTable.cpp
Index: ll
yamaguchi updated this revision to Diff 107790.
yamaguchi added a comment.
Update diff.
Use llvm::join because we don't want to print two '\n's.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/lib/
yamaguchi created this revision.
File path wasn't autocompleted after `-fmodule-cache-path=[tab]`, so
fixed this bug by checking if $flags contains only a newline or not.
https://reviews.llvm.org/D35763
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308824: [Bash-autocompletion] Fixed typo and add '-' after
-Wno (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D35762?vs=107780&id=107782#toc
Repository:
rL LLVM
https://
yamaguchi updated this revision to Diff 107781.
yamaguchi added a comment.
Update diff. Delete trailing whitespace so that -stdlib= autocompletion works
correctly.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocom
yamaguchi created this revision.
-Wno- was autocompleted as -Wno, so fixed this typo.
https://reviews.llvm.org/D35762
Files:
clang/lib/Basic/DiagnosticIDs.cpp
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
=
yamaguchi updated this revision to Diff 107779.
yamaguchi added a comment.
Add newline after the end of the line.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/lib/Option/OptTable.cpp
Index: llv
yamaguchi added inline comments.
Comment at: llvm/lib/Option/OptTable.cpp:240
if (StringRef(S).startswith(Cur))
-Ret.push_back(S);
+Ret.push_back(S + "\t" + std::string(StringRef(In.HelpText)));
}
ruiu wrote:
> I believe
>
> Ret.pus
yamaguchi updated this revision to Diff 107778.
yamaguchi added a comment.
Fixed test and update diff according to Rui's comment.
https://reviews.llvm.org/D35759
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/lib/Option/OptTable
yamaguchi created this revision.
Herald added a subscriber: hiraditya.
`clang --autocomplete=-std` will show
-std: Language standard to compile for
-std= Language standard to compile for
-stdlib=C++ standard library to use
by this change.
However, showing HelpText with complet
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308139: [Bash-autocompletion] Add support for -W
and -Wno (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D35447?vs=106774&id=106805#toc
Repository:
rL LLVM
https://review
yamaguchi updated this revision to Diff 106774.
yamaguchi added a comment.
Fixed indent.
https://reviews.llvm.org/D35447
Files:
clang/include/clang/Basic/DiagnosticIDs.h
clang/lib/Basic/DiagnosticIDs.cpp
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
Index: clang/test/Dr
yamaguchi updated this revision to Diff 106764.
yamaguchi added a comment.
Add code comment.
https://reviews.llvm.org/D35447
Files:
clang/include/clang/Basic/DiagnosticIDs.h
clang/lib/Basic/DiagnosticIDs.cpp
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
Index: clang/tes
yamaguchi updated this revision to Diff 106763.
yamaguchi added a comment.
Update diff according to Rui and teemperor's comments.
https://reviews.llvm.org/D35447
Files:
clang/include/clang/Basic/DiagnosticIDs.h
clang/lib/Basic/DiagnosticIDs.cpp
clang/lib/Driver/Driver.cpp
clang/test/Dri
yamaguchi added a comment.
@teemperor
I forgot to include in DiagnosticIDs, thanks!
What do you mean `reuse the normal flags` ?
Do you think we should define these -W in Options.td like other flags?
https://reviews.llvm.org/D35447
___
cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL308091: [Bash-autocompletion] Fixed a bug on bash (authored
by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D35448?vs=106752&id=106762#toc
Repository:
rL LLVM
https://reviews.llvm.o
yamaguchi created this revision.
Maybe I mismerged when merging previous commits by hand.
https://reviews.llvm.org/D35448
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
===
--- clang/utils/bash-
yamaguchi created this revision.
`-W[tab]` will autocomplete warnings defined in this link:
https://clang.llvm.org/docs/DiagnosticsReference.html#wweak-vtables
https://reviews.llvm.org/D35447
Files:
clang/include/clang/Basic/DiagnosticIDs.h
clang/lib/Basic/DiagnosticIDs.cpp
clang/lib/Driv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307478: [Bash-autocompletion] Fix a bug that -foo=bar
doesn't handled properly (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34927?vs=105208&id=105771#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307479: [Bash-autocompletion] Auto complete cc1 options if
-cc1 is specified (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34770?vs=105209&id=105772#toc
Repository:
rL L
This revision was automatically updated to reflect the committed changes.
Closed by commit rL307116: [Bash-autocompletion] Show flags which has HelpText
or GroupID (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34930?vs=105017&id=105211#toc
Repository:
rL LLVM
h
yamaguchi added inline comments.
Comment at: clang/utils/bash-autocomplete.sh:16
+ if [[ "${COMP_WORDS[1]}" == "-cc1" || "$w1" == "-Xclang" ]]; then
+arg="#"
+ fi
compnerd wrote:
> `prefix` may be a better term?
Thanks for reviewing!
$arg has string like `-
yamaguchi added a comment.
We are going to ask community which flags should be autocompleted or not, and
tidy Options.td.
https://reviews.llvm.org/D34930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
yamaguchi updated this revision to Diff 105208.
yamaguchi added a comment.
Update diff.
Thanks for the pointing out.
https://reviews.llvm.org/D34927
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
==
yamaguchi updated this revision to Diff 105209.
yamaguchi added a comment.
Fixed typo.
https://reviews.llvm.org/D34770
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/include/llvm/Option/OptTable.h
llvm/lib/Option/OptTable.cpp
yamaguchi created this revision.
Herald added a subscriber: hiraditya.
Otherwise internal flags will be also completed.
https://reviews.llvm.org/D34930
Files:
llvm/lib/Option/OptTable.cpp
Index: llvm/lib/Option/OptTable.cpp
===
yamaguchi created this revision.
Fixed a bug that -foo=bar wasn't handled properly on old version of bash.
https://reviews.llvm.org/D34927
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
===
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306962: [Bash-autocompletion] Add support for older bash
version. (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34924?vs=104996&id=104999#toc
Repository:
rL LLVM
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306957: [Bash-completion] Fixed a bug that ~ doesn't
expanded to $HOME (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34925?vs=104991&id=104997#toc
Repository:
rL LLVM
h
1 - 100 of 165 matches
Mail list logo
