[PATCH] D52524: Add -Wno-poison-system-directories flag

yunlian created this revision. Herald added a subscriber: cfe-commits. When using clang as a cross-compiler, we should not use system headers or libraries to do the compilation. This CL creates a new warning flag -Wpoison-system-directories support to emit warnings if --sysroot is set and

[PATCH] D48680: Add missing visibility annotation for __base

yunlian created this revision. Herald added subscribers: cfe-commits, ldionne. This adds missing visibility annotation for __base. Repository: rCXX libc++ https://reviews.llvm.org/D48680 Files: include/functional Index: include/functional

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

This revision was automatically updated to reflect the committed changes. Closed by commit rL335546: Add an option to support debug fission on implicit ThinLTO. (authored by yunlian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 152794. https://reviews.llvm.org/D44788 Files: lib/Driver/ToolChains/CommonArgs.cpp test/Driver/lto-dwo.c Index: test/Driver/lto-dwo.c === --- /dev/null +++ test/Driver/lto-dwo.c @@ -0,0

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian marked 2 inline comments as done. yunlian added a comment. ping? https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 152120. yunlian added a comment. Removed redundant 'if' statement https://reviews.llvm.org/D44788 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/lto-dwo.c Index: test/Driver/lto-dwo.c

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:428 + + if (Args.hasArg(options::OPT_gsplit_dwarf)) { +if (!Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) { pcc wrote: > If you make this `else if

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian added a comment. ping? https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian added a comment. ping? https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 150419. yunlian added a comment. Makes the default value to /path/to/binary_dwo, when DWO_DIR is provided, make the path to DWO_DIR/path/to/binary_dwo https://reviews.llvm.org/D44788 Files: include/clang/Driver/Options.td

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 150028. https://reviews.llvm.org/D44788 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/lto-dwo.c Index: test/Driver/lto-dwo.c === --- /dev/null

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian marked an inline comment as done. yunlian added a comment. Herald added a subscriber: steven_wu. ping? https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 146698. yunlian edited the summary of this revision. yunlian added a comment. Herald added subscribers: JDevlieghere, aprantl. Use the option -gsplit-dwarf to make it more consistent. https://reviews.llvm.org/D44788 Files: include/clang/Driver/Options.td

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian added a comment. ping? https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian added a comment. ping? https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian added a comment. I prefer to have a dedicated directory to store all the .dwo files. As dblaikie said, all the .dwo files are temporary files. In addition, in order to differentiate the .dwo files generated by different link stage with the same .o, we need to add some suffixes to the

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 140857. https://reviews.llvm.org/D44788 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/lto-dwo.c Index: test/Driver/lto-dwo.c

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian updated this revision to Diff 139956. https://reviews.llvm.org/D44788 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td lib/Driver/ToolChains/CommonArgs.cpp test/Driver/lto-dwo.c Index: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian added a comment. I have another one https://reviews.llvm.org/D44792 on LLVM side. Repository: rC Clang https://reviews.llvm.org/D44788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44788: Add an option to support debug fission on implicit ThinLTO.

yunlian created this revision. yunlian added reviewers: tejohnson, dblaikie, pcc. Herald added subscribers: cfe-commits, inglorion, mehdi_amini. This adds an option -gthinlto-dwo-dir=. LLVM can create .dwo files in the given directory during the implicit ThinLTO link stage. Repository: rC

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

yunlian added a comment. I've sent a reproduce test case to tejohnson. https://reviews.llvm.org/D35081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

yunlian added a comment. This error happens when I try to triage a thinLTO failure on ARM. Initially I got some error like Instruction does not dominate all uses! %205 = bitcast i1 (%"class.blink::LayoutObject"*)** %194 to i8*, !dbg !51180 %200 = getelementptr i8, i8* %205, i32 ptrtoint