[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun added a comment. Thanks for reviewing! Can you merge this patch? I have no commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74531/new/ https://reviews.llvm.org/D74531 ___

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun updated this revision to Diff 380554. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74531/new/ https://reviews.llvm.org/D74531 Files: clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp clang/test/PCH/pch-wasm.c

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun updated this revision to Diff 380551. kateinoigakukun added a comment. Thank you for taking a look again. OK, I extracted `writeStringWithAlignment` and updated comment lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun updated this revision to Diff 380283. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74531/new/ https://reviews.llvm.org/D74531 Files: clang/lib/CodeGen/ObjectFilePCHContainerOperations.cpp clang/test/PCH/pch-wasm.c

[PATCH] D74531: [WebAssembly] Emit clangast in custom section aligned by 4 bytes

kateinoigakukun updated this revision to Diff 380282. kateinoigakukun retitled this revision from " [WebAssembly] Emit PCH __clang_ast in custom section" to "[WebAssembly] Emit clangast in custom section aligned by 4 bytes". kateinoigakukun edited the summary of this revision. kateinoigakukun

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun added a comment. Could you merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71823/new/ https://reviews.llvm.org/D71823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun added a comment. In D71823#1834488 , @dschuff wrote: > Sorry we left this dangling for so long. This little change looks fine; I > guess you must be in the process of porting swift to wasm? Do you have any > more detailed plans for that

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun marked an inline comment as done. kateinoigakukun added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:122 +case CC_Swift: + return CCCR_OK; +default: sbc100 wrote: > This seems to disagree with the longer list in

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun updated this revision to Diff 235085. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71823/new/ https://reviews.llvm.org/D71823 Files:

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Support Swift calling convention for WebAssembly targets This adds basic support for the Swift calling convention with WebAssembly