[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

yroux added a comment. > I've committed this and it looks like the bot is back to green :) > https://lab.llvm.org/buildbot/#/builders/65/builds/1400. Sorry for the > delayed fix Great, thanks a lot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D99426: [SystemZ][z/OS][Windows] Add new OF_TextWithCRLF flag and use this flag instead of OF_Text

yroux added a comment. Hi, Sorry I'm bit lost in the various patches proposed to fix the issue introduced by https://reviews.llvm.org/D97785 My understanding is that this is missing one to fix our Windows on ARM bots (broken for more than 2 weeks now) So it'd be great to have it applied Repo

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux abandoned this revision. yroux added a comment. All patches are now committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054 ___ cfe-commits mailing list

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c41b1c9f93c: [Driver][MachineOutliner] Support outlining option with LTO (authored by yroux). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

yroux added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93385/new/ https://reviews.llvm.org/D93385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D93385: [Driver][MachineOutliner] Support outlining option with LTO

yroux created this revision. yroux added reviewers: paquette, efriedma, samparker. Herald added a subscriber: inglorion. yroux requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch propagates the -moutline flag when LTO is enabled and

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e4827aa4e4a: [ARM][MachineOutliner] Add Machine Outliner support for ARM. (authored by yroux). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ htt

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 263830. yroux added a comment. I found a last issue when doing a full bootstrap with -moutline used to build clang, there was a case of thunk outlining where the original was call a `BLX LR` which was broken by the outlining call `BL OUTLINE_FUNCTION_X` I fix

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added a comment. In D76066#2022025 , @samparker wrote: > Ah, yes, good point. Then I have nothing else, but definitely worth waiting > to see if Eli has further comments. Yes I'll wait for Eli's feedback and update the other patches. Thanks for t

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 262205. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp llvm/lib/Target/ARM/ARMB

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added a comment. In D76066#2014697 , @samparker wrote: > Thanks for adding the MVE changes, but I also still don't see any DSP tests, > i.e QADD, SADD16. hmm... I was wrong w/r to DSP instructions Q and GE flags handling, I don't get what I did i

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 261237. yroux added a comment. This update avoids outlining MVE instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.c

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don't need sampark

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don't need yroux w

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 260921. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp llvm/lib/Target/ARM/ARMB

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 260916. yroux edited the summary of this revision. yroux added a comment. Here is a new update of the patch. I remove the logic to disable LowOverheadLoops pass since Eli has added the live-ins infos inside outlined functions in D78605

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added inline comments. Comment at: llvm/lib/Target/ARM/ARMTargetMachine.cpp:553 addPass(createARMConstantIslandPass()); - addPass(createARMLowOverheadLoopsPass()); + if (!MachineOutlinerEnabled) +addPass(createARMLowOverheadLoopsPass()); samparker

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added a comment. Hi Sam, Thanks for your comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [&TRI](outliner::Candidate &C) { +// If the unsafe registers in this block are all dead, then we don'

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 254834. yroux added a comment. Here is an update of the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/includ

[PATCH] D53272: Add target requirement to profile remap test.

yroux closed this revision. yroux added a comment. Herald added a subscriber: danielkiss. This was closed by commit r344593 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53272/new/ https://reviews.llvm.org/D53272 ___

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux marked 5 inline comments as done. yroux added a comment. Thanks for the review Sam, I'll update the patch with more tests (for CPSR/LR it was part of D76068 but you are right it should be done here) and take your comments into account. In D76066#1921331

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux created this revision. yroux added reviewers: t.p.northover, efriedma, paquette, samparker, SjoerdMeijer. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Enables Machine Outlining support on ARM for ARM and Thum

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux marked an inline comment as done. yroux added inline comments. Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:1159 + MF.getProperties().reset(MachineFunctionProperties::Property::IsSSA); + MF.getProperties().set(MachineFunctionProperties::Property::NoPHIs); + MF.getPro

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux marked 2 inline comments as done. yroux added a comment. Thanks for the comments Sam, Thumb1 is disabled in this version (see inline comment). The is to bundle Machine Outliner to -Oz like it was done for AArch64, but here it just run when the flags are used (-moutline for clang or -enab

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux updated this revision to Diff 241188. yroux added a comment. Here is a new version, which disables ARM Low Overhead Loops pass when the Machine Outliner is enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llv

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. > ! In D57054#1811740 , @samparker > wrote: > Hmm, would it be possible to pass a bool to the pass which will control > whether liveness is updated? The other, suboptimal, option would be to not do > outlining when we have the LOB

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. In D57054#1811486 , @samparker wrote: > This, and the fact that LowOverheadLoops is dependent upon block sizes and > placement (I need to add a comment in the header on that pass). So, > ConstantIslands would have to guarantee

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux added a comment. Ah right, let's wait for Sam comments/advises and I'll prepare a proper patch for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/ https://reviews.llvm.org/D57054

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux updated this revision to Diff 236838. yroux added a comment. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. Hi, here is an update for the Machine Outliner support on ARM targets. It addresses the comments received on the initial version and is rebased on c

[PATCH] D53272: Add target requirement to profile remap test.

yroux created this revision. yroux added a reviewer: rsmith. Herald added a reviewer: javed.absar. Herald added a subscriber: kristof.beyls. Fix bots which don't have x86_64 target built (ARM/AArch64). Repository: rC Clang https://reviews.llvm.org/D53272 Files: test/CodeGenCXX/profile-rema

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

This revision was automatically updated to reflect the committed changes. Closed by commit rL339865: [libcxxabi] Fix test_exception_address_alignment test for ARM (authored by yroux, committed by ). Herald added a subscriber: christof. Changed prior to commit: https://reviews.llvm.org/D50170?vs

[PATCH] D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3

yroux added a comment. Notice that the affected bots run two times the test cases where one execution passes and one fails, as you can see in (search Analysis/plist-macros.cpp for instance): http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/5450/steps/ninja%20check%201/logs/stdio

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

yroux added a comment. I dug a bit and can give more context. The usage of _LIBUNWIND_ARM_EHABI was introduced by https://reviews.llvm.org/D31178 but from what we are seeing with the release builds, libunwind headers are not picked up (at least in these configs) and since r309226

[PATCH] D50170: [libcxxabi] Fix test_exception_address_alignment test for ARM

yroux created this revision. yroux added reviewers: mclow.lists, hans. Herald added a reviewer: EricWF. Herald added a reviewer: javed.absar. Herald added subscribers: ldionne, chrib, kristof.beyls. Check _LIBCXXABI_ARM_EHABI macro instead of libunwind version Repository: rCXXA libc++abi http