[PATCH] D117579: Add assert on End iteration distance to Rewriter::getRewrittenText.

2022-01-18 Thread ahedberg via Phabricator via cfe-commits
ahedberg created this revision. ahedberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I currently have code that is crashing in the second std::advance call, and it was not straightforward to identify the problem, as the first line of

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

2018-03-02 Thread ahedberg via Phabricator via cfe-commits
ahedberg added a comment. In https://reviews.llvm.org/D43847#1024018, @aaron.ballman wrote: > In https://reviews.llvm.org/D43847#1023452, @hokein wrote: > > > In https://reviews.llvm.org/D43847#1021967, @aaron.ballman wrote: > > > > > I need a bit more context because I'm unfamiliar with `absl`.