[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

2022-05-13 Thread cha5on via Phabricator via cfe-commits
cha5on added a comment. In D125162#3510737 , @curdeius wrote: > LGTM. Tell us if you need help landing this. I don't have commit access, so some help would be great :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

2022-05-12 Thread cha5on via Phabricator via cfe-commits
cha5on added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:374-375 return false; + if (Changes[i].Tok->is(tok::l_brace) && + Changes[i].Tok->is(BK_BracedInit)) +return true; curdeius wrote: >

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

2022-05-12 Thread cha5on via Phabricator via cfe-commits
cha5on updated this revision to Diff 429138. cha5on marked 4 inline comments as done. cha5on added a comment. Update for review. - Further simplify testcases. - Update issue URL in comment to use llvm.org alias. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

2022-05-09 Thread cha5on via Phabricator via cfe-commits
cha5on marked 3 inline comments as done. cha5on added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17321 + +verifyFormat(Expected, ToFormat, Alignment); + } curdeius wrote: > I don't think you need to create variables, just online the

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

2022-05-09 Thread cha5on via Phabricator via cfe-commits
cha5on updated this revision to Diff 428262. cha5on added a comment. Update for review - Add and link bug report. - Remove braces per LLVM style. - Shrink down test case and add second case for direct-list-initialization alignment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

2022-05-07 Thread cha5on via Phabricator via cfe-commits
cha5on created this revision. Herald added a project: All. cha5on requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The combination of - AlignConsecutiveAssignments.Enabled = true - BinPackArguments = false would result in the first