[clang] 5bdd5d0 - Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

Author: faisal vali Date: 2023-09-16T13:29:59-05:00 New Revision: 5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea URL: https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea DIFF: https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea.diff

Re: [PATCH] D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions.

I'll try and look into it this weekend and have some sort of updated news for you by monday? Faisal Vali On Thu, Jan 12, 2023 at 10:40 PM Shafik Yaghmour via Phabricator < revi...@reviews.llvm.org> wrote: > shafik added a comment. > > Is this PR still workable or does it need a major rework

[clang] 9930d4d - [NFC, Refactor] Modernize enum FunctionDefinitionKind (DeclSpech.h) into a scoped enum

Author: Faisal Vali Date: 2020-11-21T09:49:52-06:00 New Revision: 9930d4dff31a130890f21a64f43d530a83ae3d0a URL: https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a DIFF: https://github.com/llvm/llvm-project/commit/9930d4dff31a130890f21a64f43d530a83ae3d0a.diff

Re: [PATCH] D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum

yay! Thanks Thorsten - if no one else does it - i'll try and commit this for you later today :) Faisal Vali On Sat, Nov 14, 2020 at 11:08 AM Thorsten via Phabricator < revi...@reviews.llvm.org> wrote: > tschuett added a comment. > > I started with specifiers.h here:

[clang] e4d2793 - [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to remove duplication

Author: Faisal Vali Date: 2020-11-10T23:40:12-06:00 New Revision: e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9 URL: https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9 DIFF: https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9.diff

[clang] accd9af - Revert "[nfc] test commit"

Author: faisal vali Date: 2020-05-16T15:12:04-05:00 New Revision: accd9af838b071ff6e8ba4ff3c99a2542cd0ce25 URL: https://github.com/llvm/llvm-project/commit/accd9af838b071ff6e8ba4ff3c99a2542cd0ce25 DIFF: https://github.com/llvm/llvm-project/commit/accd9af838b071ff6e8ba4ff3c99a2542cd0ce25.diff

[clang] 0ee46e8 - [nfc] test commit

Author: faisal vali Date: 2020-05-16T15:08:30-05:00 New Revision: 0ee46e857d81ea815e5b11d266c0c118a2c2e714 URL: https://github.com/llvm/llvm-project/commit/0ee46e857d81ea815e5b11d266c0c118a2c2e714 DIFF: https://github.com/llvm/llvm-project/commit/0ee46e857d81ea815e5b11d266c0c118a2c2e714.diff

r330889 - Fix a merge conflict that was inadvertently introduced in r330888

Author: faisalv Date: Wed Apr 25 18:05:05 2018 New Revision: 330889 URL: http://llvm.org/viewvc/llvm-project?rev=330889=rev Log: Fix a merge conflict that was inadvertently introduced in r330888 - during the reversion of r330794 Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified:

r330888 - Revert rC330794 and some dependent tiny bug fixes

Author: faisalv Date: Wed Apr 25 17:42:40 2018 New Revision: 330888 URL: http://llvm.org/viewvc/llvm-project?rev=330888=rev Log: Revert rC330794 and some dependent tiny bug fixes See Richard's humbling feedback here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20180423/226482.html

Re: r330794 - [c++2a] [concepts] Add rudimentary parsing support for template concept declarations

On Wed, Apr 25, 2018 at 3:37 PM, Richard Smith <rich...@metafoo.co.uk> wrote: > On 24 April 2018 at 19:42, Faisal Vali via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: faisalv >> Date: Tue Apr 24 19:42:26 2018 >> New Revision: 330

Re: FW: [Diffusion] rC330802: Fix buildbot problems after rC330794

That should work - although i wonder if we still need makeArrayRef once we explicitly declare an array - either way thank you for fixing it Bjorn!! Faisal Vali On Wed, Apr 25, 2018 at 4:16 AM, Björn Pettersson A wrote: > Hello Faisal. > > Lots of buildbots have

r330798 - [NFC] Make dependent parameter non-deducible, so that we are forced to use the default template parameter.

Author: faisalv Date: Tue Apr 24 20:54:20 2018 New Revision: 330798 URL: http://llvm.org/viewvc/llvm-project?rev=330798=rev Log: [NFC] Make dependent parameter non-deducible, so that we are forced to use the default template parameter. This might provide users with more graceful diagnostics if

r330796 - Fix rC330794 - a parameter that should have been dependent was inadvertently not -

Author: faisalv Date: Tue Apr 24 20:28:23 2018 New Revision: 330796 URL: http://llvm.org/viewvc/llvm-project?rev=330796=rev Log: Fix rC330794 - a parameter that should have been dependent was inadvertently not - and compiled in MSVC - but not so for the other bots. The fix was to make it

r330794 - [c++2a] [concepts] Add rudimentary parsing support for template concept declarations

Author: faisalv Date: Tue Apr 24 19:42:26 2018 New Revision: 330794 URL: http://llvm.org/viewvc/llvm-project?rev=330794=rev Log: [c++2a] [concepts] Add rudimentary parsing support for template concept declarations This patch is a tweak of changyu's patch: https://reviews.llvm.org/D40381. It

r321628 - Again reverting an attempt to convert the DeclSpec enums into scoped enums.

Author: faisalv Date: Mon Jan 1 10:23:28 2018 New Revision: 321628 URL: http://llvm.org/viewvc/llvm-project?rev=321628=rev Log: Again reverting an attempt to convert the DeclSpec enums into scoped enums. - reverts r321622, r321625, and r321626. - the use of bit-fields is still resulting in

r321625 - Use 'unsigned int' instead of enum bit-fields to silence some warnings from r321622

Author: faisalv Date: Mon Jan 1 08:36:47 2018 New Revision: 321625 URL: http://llvm.org/viewvc/llvm-project?rev=321625=rev Log: Use 'unsigned int' instead of enum bit-fields to silence some warnings from r321622 - bots were complaining that the bit-field width was less than the width of the

r321622 - [NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType into scoped enums with underlying types.

Author: faisalv Date: Mon Jan 1 07:42:13 2018 New Revision: 321622 URL: http://llvm.org/viewvc/llvm-project?rev=321622=rev Log: [NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType into scoped enums with underlying types. - Since these enums are used as bit-fields -

r321616 - Revert r321614 and r321615

Author: faisalv Date: Sun Dec 31 18:49:17 2017 New Revision: 321616 URL: http://llvm.org/viewvc/llvm-project?rev=321616=rev Log: Revert r321614 and r321615 - the enum changes to TypeSpecifierType are breaking some tests - and will require a more careful integration. Sorry about rushing these

r321615 - Add scope specifiers to updated scoped-enums (that I somehow missed in r321614)

Author: faisalv Date: Sun Dec 31 18:35:43 2017 New Revision: 321615 URL: http://llvm.org/viewvc/llvm-project?rev=321615=rev Log: Add scope specifiers to updated scoped-enums (that I somehow missed in r321614) Modified: cfe/trunk/lib/AST/TypeLoc.cpp

r321614 - [NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType into scoped enums.

Author: faisalv Date: Sun Dec 31 18:19:52 2017 New Revision: 321614 URL: http://llvm.org/viewvc/llvm-project?rev=321614=rev Log: [NFC] Modernize enums TypeSpecifierWidth, TypeSpecifierSign & TypeSpecifierType into scoped enums. Modified: cfe/trunk/include/clang/AST/Type.h

r321590 - [NFC] Modernize enum DeclSpecContext into a scoped enum.

Author: faisalv Date: Sat Dec 30 16:06:40 2017 New Revision: 321590 URL: http://llvm.org/viewvc/llvm-project?rev=321590=rev Log: [NFC] Modernize enum DeclSpecContext into a scoped enum. Modified: cfe/trunk/include/clang/Parse/Parser.h cfe/trunk/lib/Parse/ParseDecl.cpp

r321574 - [NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum UnqualifiedIdKind.

Author: faisalv Date: Fri Dec 29 20:15:27 2017 New Revision: 321574 URL: http://llvm.org/viewvc/llvm-project?rev=321574=rev Log: [NFC] Modernize enum 'UnqualifiedId::IdKind' into a scoped enum UnqualifiedIdKind. Modified: cfe/trunk/include/clang/Sema/DeclSpec.h

r321546 - [NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum.

Author: faisalv Date: Thu Dec 28 21:41:00 2017 New Revision: 321546 URL: http://llvm.org/viewvc/llvm-project?rev=321546=rev Log: [NFC] Modernize enum Declarator::TheContext to a type-safe scoped enum. Note, we don't do any bitwise manipulations when using them. Modified:

r321449 - Add a fixit for attributes incorrectly placed prior to 'struct/class/enum' keyword.

Author: faisalv Date: Mon Dec 25 14:23:20 2017 New Revision: 321449 URL: http://llvm.org/viewvc/llvm-project?rev=321449=rev Log: Add a fixit for attributes incorrectly placed prior to 'struct/class/enum' keyword. Suggest moving the following erroneous attrib list (based on location) [[]] struct

r321410 - [NFC] Remove a cast rendered unnecessary by r321409

Author: faisalv Date: Sat Dec 23 11:27:07 2017 New Revision: 321410 URL: http://llvm.org/viewvc/llvm-project?rev=321410=rev Log: [NFC] Remove a cast rendered unnecessary by r321409 See https://reviews.llvm.org/rC321409 for additional context. Modified: cfe/trunk/lib/Parse/ParseTemplate.cpp

r321409 - [NFC] Update the template-parameter parsers and analyzers to return NamedDecl (vs Decl)

Author: faisalv Date: Sat Dec 23 10:56:34 2017 New Revision: 321409 URL: http://llvm.org/viewvc/llvm-project?rev=321409=rev Log: [NFC] Update the template-parameter parsers and analyzers to return NamedDecl (vs Decl) This patch addresses a FIXME and has the template-parameter processing

r321339 - Diagnose the various invalid decl-specifiers on nontype template parameters.

Author: faisalv Date: Thu Dec 21 19:50:55 2017 New Revision: 321339 URL: http://llvm.org/viewvc/llvm-project?rev=321339=rev Log: Diagnose the various invalid decl-specifiers on nontype template parameters. The standard correctly forbids various decl-specifiers that dont make sense on non-type

r317984 - Adjust r316292 - remove the anonymous union for sharing a bitfield in FunctionDecl.

Author: faisalv Date: Sat Nov 11 10:02:29 2017 New Revision: 317984 URL: http://llvm.org/viewvc/llvm-project?rev=317984=rev Log: Adjust r316292 - remove the anonymous union for sharing a bitfield in FunctionDecl. The anonymous union did NOT save us storage, but instead behaved as if we added

r316304 - [c++2a] Update cxx_status w __VA_OPT__ marked as completed in SVN.

Author: faisalv Date: Sun Oct 22 15:29:52 2017 New Revision: 316304 URL: http://llvm.org/viewvc/llvm-project?rev=316304=rev Log: [c++2a] Update cxx_status w __VA_OPT__ marked as completed in SVN. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.html URL:

r316292 - [C++17] Fix PR34970 - tweak overload resolution for class template deduction-guides in line with WG21's p0620r0.

Author: faisalv Date: Sun Oct 22 07:45:08 2017 New Revision: 316292 URL: http://llvm.org/viewvc/llvm-project?rev=316292=rev Log: [C++17] Fix PR34970 - tweak overload resolution for class template deduction-guides in line with WG21's p0620r0. In order to identify the copy deduction candidate, I

r315842 - [c++2a] Fix failing regression test related to not adding the extension warning to a diagnostic group (in r315840)

Author: faisalv Date: Sat Oct 14 19:13:17 2017 New Revision: 315842 URL: http://llvm.org/viewvc/llvm-project?rev=315842=rev Log: [c++2a] Fix failing regression test related to not adding the extension warning to a diagnostic group (in r315840) In passing also complete a comment that I left

r315840 - [c++2a] Implement P0306 __VA_OPT__ (Comma omission and comma deletion)

Author: faisalv Date: Sat Oct 14 18:26:26 2017 New Revision: 315840 URL: http://llvm.org/viewvc/llvm-project?rev=315840=rev Log: [c++2a] Implement P0306 __VA_OPT__ (Comma omission and comma deletion) This patch implements an extension to the preprocessor: __VA_OPT__(contents) --> which expands

r314753 - Add parens around the boolean condition of one of the added asserts in r314747 ...

Author: faisalv Date: Mon Oct 2 18:33:36 2017 New Revision: 314753 URL: http://llvm.org/viewvc/llvm-project?rev=314753=rev Log: Add parens around the boolean condition of one of the added asserts in r314747 ... ... in the hopes of teaching the bots the gift of silence ;) For quick reference:

r314748 - Remove an assertion I added from the refactoring of pasteTokens (https://reviews.llvm.org/rL314747).

Author: faisalv Date: Mon Oct 2 18:20:40 2017 New Revision: 314748 URL: http://llvm.org/viewvc/llvm-project?rev=314748=rev Log: Remove an assertion I added from the refactoring of pasteTokens (https://reviews.llvm.org/rL314747). - it made the bots v angry! I'm not exactly sure why the

r314747 - [NFC] Refactor PasteTokens so that it can be passed the Token Stream and Index to start concatenating at.

Author: faisalv Date: Mon Oct 2 17:52:14 2017 New Revision: 314747 URL: http://llvm.org/viewvc/llvm-project?rev=314747=rev Log: [NFC] Refactor PasteTokens so that it can be passed the Token Stream and Index to start concatenating at. In passing: - change the name of the function to

r314600 - [NFC] Add assertion that we assume a valid macro argument index.

Author: faisalv Date: Sat Sep 30 12:34:27 2017 New Revision: 314600 URL: http://llvm.org/viewvc/llvm-project?rev=314600=rev Log: [NFC] Add assertion that we assume a valid macro argument index. Modified: cfe/trunk/lib/Lex/MacroArgs.cpp Modified: cfe/trunk/lib/Lex/MacroArgs.cpp URL:

[clang-tools-extra] r314595 - [NFC] Sync function call with changes to interface made in r314593.

Author: faisalv Date: Sat Sep 30 07:36:00 2017 New Revision: 314595 URL: http://llvm.org/viewvc/llvm-project?rev=314595=rev Log: [NFC] Sync function call with changes to interface made in r314593. Modified: clang-tools-extra/trunk/modularize/PreprocessorTracker.cpp Modified:

r314593 - [NFC] Remove superfluous parameter

Author: faisalv Date: Sat Sep 30 06:58:38 2017 New Revision: 314593 URL: http://llvm.org/viewvc/llvm-project?rev=314593=rev Log: [NFC] Remove superfluous parameter - MacroArgs already knows the maximum number of arguments that can be supplied to the macro. No need to pass MacroInfo

r314484 - [NFC] Replace 'arguments' with 'parameters' in comments relating to lexing a macro definition.

Author: faisalv Date: Thu Sep 28 19:43:22 2017 New Revision: 314484 URL: http://llvm.org/viewvc/llvm-project?rev=314484=rev Log: [NFC] Replace 'arguments' with 'parameters' in comments relating to lexing a macro definition. Modified: cfe/trunk/lib/Lex/PPDirectives.cpp Modified:

r314483 - [NFC] Rename variable 'Arguments' to 'Parameters' when lexing the Macro Definition.

Author: faisalv Date: Thu Sep 28 19:17:31 2017 New Revision: 314483 URL: http://llvm.org/viewvc/llvm-project?rev=314483=rev Log: [NFC] Rename variable 'Arguments' to 'Parameters' when lexing the Macro Definition. Modified: cfe/trunk/lib/Lex/PPDirectives.cpp Modified:

Re: r314373 - [NFC] Don't use C++17 standard lib variable template helper traits, instead use ::value.

wrote: > This still doesn't work on some compilers, because > std::is_trivially_copyable isn't available: > http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/265/steps/build/logs/stdio > > On Wed, Sep 27, 2017 at 10:00 PM, Faisal Vali via cfe-c

r314373 - [NFC] Don't use C++17 standard lib variable template helper traits, instead use ::value.

Author: faisalv Date: Wed Sep 27 19:00:40 2017 New Revision: 314373 URL: http://llvm.org/viewvc/llvm-project?rev=314373=rev Log: [NFC] Don't use C++17 standard lib variable template helper traits, instead use ::value. Modified: cfe/trunk/lib/Lex/MacroArgs.cpp Modified:

r314372 - [NFC] Modernize MacroArgs using TrailingObjects

Author: faisalv Date: Wed Sep 27 18:50:23 2017 New Revision: 314372 URL: http://llvm.org/viewvc/llvm-project?rev=314372=rev Log: [NFC] Modernize MacroArgs using TrailingObjects Refactor MacroArgs to use TrailingObjects when creating a variably sized object on the heap to store the unexpanded

Re: r313521 - Another attempt to fix warning discovered by r313487. [-Wunused-lambda-capture]

thanks! Faisal Vali On Mon, Sep 18, 2017 at 4:10 AM, NAKAMURA Takumi wrote: > Seems fixed! Thanks! > > On Mon, Sep 18, 2017 at 5:27 PM Vitaly Buka via cfe-commits > wrote: >> >> Author: vitalybuka >> Date: Mon Sep 18 01:26:01 2017 >> New

r313487 - Fix the second half of PR34266: Don't implicitly capture '*this' if the members are found in a class unrelated to the enclosing class.

Author: faisalv Date: Sun Sep 17 08:37:51 2017 New Revision: 313487 URL: http://llvm.org/viewvc/llvm-project?rev=313487=rev Log: Fix the second half of PR34266: Don't implicitly capture '*this' if the members are found in a class unrelated to the enclosing class.

r311975 - revert r311839 (ongoing cwg discussion)

Author: faisalv Date: Mon Aug 28 20:04:13 2017 New Revision: 311975 URL: http://llvm.org/viewvc/llvm-project?rev=311975=rev Log: revert r311839 (ongoing cwg discussion) apologies. Modified: cfe/trunk/lib/Sema/SemaExprMember.cpp cfe/trunk/test/SemaCXX/member-expr.cpp Modified:

r311855 - revert changes from r311851.

Author: faisalv Date: Sun Aug 27 12:00:08 2017 New Revision: 311855 URL: http://llvm.org/viewvc/llvm-project?rev=311855=rev Log: revert changes from r311851. The right answers here (and how clang needs to be tweaked) require further analysis (ongoing cwg thread). sorry. Modified:

r311851 - Don't see through 'using member-declarations' when determining the relation of any potential implicit object expression to the parent class of the member function containing the function cal

Author: faisalv Date: Sun Aug 27 09:49:47 2017 New Revision: 311851 URL: http://llvm.org/viewvc/llvm-project?rev=311851=rev Log: Don't see through 'using member-declarations' when determining the relation of any potential implicit object expression to the parent class of the member function

r311839 - Pass the correct object argument when a member call to an 'unrelated' class is made.

Author: faisalv Date: Sat Aug 26 19:21:21 2017 New Revision: 311839 URL: http://llvm.org/viewvc/llvm-project?rev=311839=rev Log: Pass the correct object argument when a member call to an 'unrelated' class is made. Prior to this patch, clang would do the wrong thing here (see inline comments

r311788 - [NFC] Remove a cstyle cast and replace some uses of Decl with NamedDecl during the processing of TemplateParameterLists.

Author: faisalv Date: Fri Aug 25 11:24:20 2017 New Revision: 311788 URL: http://llvm.org/viewvc/llvm-project?rev=311788=rev Log: [NFC] Remove a cstyle cast and replace some uses of Decl with NamedDecl during the processing of TemplateParameterLists. Modified:

r308948 - [NFC] Use RAII to un-poison and then re-poison __VA_ARGS__

Author: faisalv Date: Mon Jul 24 20:15:36 2017 New Revision: 308948 URL: http://llvm.org/viewvc/llvm-project?rev=308948=rev Log: [NFC] Use RAII to un-poison and then re-poison __VA_ARGS__ - This will also be used for the forthcoming __VA_OPT__ feature approved for C++2a. - recommended by

r308823 - [NFC, documentation] Prefer the term expansion instead of macro instantiation

Author: faisalv Date: Sat Jul 22 05:04:37 2017 New Revision: 308823 URL: http://llvm.org/viewvc/llvm-project?rev=308823=rev Log: [NFC, documentation] Prefer the term expansion instead of macro instantiation ... in the few remaining places where this was not corrected. Modified:

r308574 - [NFC] Update local variable names to upper-case as per LLVM Coding Standards.

Author: faisalv Date: Wed Jul 19 18:10:56 2017 New Revision: 308574 URL: http://llvm.org/viewvc/llvm-project?rev=308574=rev Log: [NFC] Update local variable names to upper-case as per LLVM Coding Standards. Modified: cfe/trunk/lib/Lex/TokenLexer.cpp Modified:

[clang-tools-extra] r308191 - [NFC] Update function call names as changed in MacroInfo that should refer to Parameters (as opposed to Arguments).

Author: faisalv Date: Mon Jul 17 10:20:57 2017 New Revision: 308191 URL: http://llvm.org/viewvc/llvm-project?rev=308191=rev Log: [NFC] Update function call names as changed in MacroInfo that should refer to Parameters (as opposed to Arguments). This syncs them up with clang commit r308190

r308190 - [NFC] Refactor the Preprocessor function that handles Macro definitions and rename Arguments to Parameters in Macro Definitions.

Author: faisalv Date: Mon Jul 17 10:18:43 2017 New Revision: 308190 URL: http://llvm.org/viewvc/llvm-project?rev=308190=rev Log: [NFC] Refactor the Preprocessor function that handles Macro definitions and rename Arguments to Parameters in Macro Definitions. - Extracted the reading of the

r308158 - Revert changes from my previous refactoring - will need to fix dependencies in clang's extra tooling (such as clang-tidy etc.).

Author: faisalv Date: Sun Jul 16 19:03:21 2017 New Revision: 308158 URL: http://llvm.org/viewvc/llvm-project?rev=308158=rev Log: Revert changes from my previous refactoring - will need to fix dependencies in clang's extra tooling (such as clang-tidy etc.). Sorry about that. Modified:

r308157 - [NFC] Refactor the Preprocessor function that handles Macro definitions and rename Arguments to Parameters in Macro Definitions.

Author: faisalv Date: Sun Jul 16 18:27:53 2017 New Revision: 308157 URL: http://llvm.org/viewvc/llvm-project?rev=308157=rev Log: [NFC] Refactor the Preprocessor function that handles Macro definitions and rename Arguments to Parameters in Macro Definitions. - Extracted the reading of the

r308118 - [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features

Author: faisalv Date: Sat Jul 15 17:23:04 2017 New Revision: 308118 URL: http://llvm.org/viewvc/llvm-project?rev=308118=rev Log: [c++2a] Add option -std=c++2a to enable support for potential/transitional C++2a features - as usual C++2a implies all the C++'s that came before it. Thank you Aaron

r303492 - Fix PR25627: constant expressions being odr-used in template arguments.

Author: faisalv Date: Sat May 20 14:58:04 2017 New Revision: 303492 URL: http://llvm.org/viewvc/llvm-project?rev=303492=rev Log: Fix PR25627: constant expressions being odr-used in template arguments. This patch ensures that clang processes the expression-nodes that are generated when

r303030 - Silence buildbots by tweaking an IR codegen test to be less specific w register names.

Author: faisalv Date: Sun May 14 21:56:02 2017 New Revision: 303030 URL: http://llvm.org/viewvc/llvm-project?rev=303030=rev Log: Silence buildbots by tweaking an IR codegen test to be less specific w register names. Modified: cfe/trunk/test/CodeGenCXX/vla.cpp Modified:

r303027 - [NFC] Remove some comments (IR aid) from a test file erroneous committed in r303026

Author: faisalv Date: Sun May 14 20:54:02 2017 New Revision: 303027 URL: http://llvm.org/viewvc/llvm-project?rev=303027=rev Log: [NFC] Remove some comments (IR aid) from a test file erroneous committed in r303026 Modified: cfe/trunk/test/CodeGenCXX/vla.cpp Modified:

r303026 - Fix PR32933: crash on lambda capture of VLA

Author: faisalv Date: Sun May 14 20:49:19 2017 New Revision: 303026 URL: http://llvm.org/viewvc/llvm-project?rev=303026=rev Log: Fix PR32933: crash on lambda capture of VLA https://bugs.llvm.org/show_bug.cgi?id=32933 Turns out clang wasn't really handling vla's (*) in C++11's for-range entirely

r302507 - Fix PR32638 : Make sure we switch Sema's CurContext to the substituted FunctionDecl when instantiating the exception specification.

Author: faisalv Date: Mon May 8 23:17:15 2017 New Revision: 302507 URL: http://llvm.org/viewvc/llvm-project?rev=302507=rev Log: Fix PR32638 : Make sure we switch Sema's CurContext to the substituted FunctionDecl when instantiating the exception specification. This fixes the bug:

r301973 - [NFC] Add original test that triggered crash post r301735

Author: faisalv Date: Tue May 2 16:02:46 2017 New Revision: 301973 URL: http://llvm.org/viewvc/llvm-project?rev=301973=rev Log: [NFC] Add original test that triggered crash post r301735 - this is added just for completeness sake (though the general case should be represented by the test added

r301972 - Fix PR32831 (Try Again): 'this' capture while instantiating generic lambda call operator specialization

Author: faisalv Date: Tue May 2 15:56:34 2017 New Revision: 301972 URL: http://llvm.org/viewvc/llvm-project?rev=301972=rev Log: Fix PR32831 (Try Again): 'this' capture while instantiating generic lambda call operator specialization When computing the appropriate cv-qualifiers for the 'this'

r301735 - Fix PR32831: 'this capture while instantiating generic lambda call operator specialization

Author: faisalv Date: Fri Apr 28 22:49:17 2017 New Revision: 301735 URL: http://llvm.org/viewvc/llvm-project?rev=301735=rev Log: Fix PR32831: 'this capture while instantiating generic lambda call operator specialization When computing the appropriate cv-qualifiers for the 'this' capture, we

r299316 - [NFC, Scoped Enum] Convert Sema::ExpressionEvaluationContext into a scoped Enum

Author: faisalv Date: Sat Apr 1 16:30:49 2017 New Revision: 299316 URL: http://llvm.org/viewvc/llvm-project?rev=299316=rev Log: [NFC, Scoped Enum] Convert Sema::ExpressionEvaluationContext into a scoped Enum - also replace direct equality checks against the ConstantEvaluated enumerator with

Re: r295279 - [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

Of course Richard - I'll be happy to bump that value for C++1z hopefully later today. Thanks! Faisal Vali On Wed, Feb 15, 2017 at 10:30 PM, Richard Smith <rich...@metafoo.co.uk> wrote: > On 15 February 2017 at 20:12, Faisal Vali via cfe-commits > <cfe-commits@lists.llvm.org> w

r295279 - [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas.

Author: faisalv Date: Wed Feb 15 22:12:21 2017 New Revision: 295279 URL: http://llvm.org/viewvc/llvm-project?rev=295279=rev Log: [cxx1z-constexpr-lambda] Implement captures - thus completing implementation of constexpr lambdas. Enable evaluation of captures within constexpr lambdas by using a

r291525 - [NFC] Rename RAII ExpressionEvaluationContext variable from Unevaluated to ConstantEvaluated when parsing a constant expression.

Author: faisalv Date: Mon Jan 9 19:29:41 2017 New Revision: 291525 URL: http://llvm.org/viewvc/llvm-project?rev=291525=rev Log: [NFC] Rename RAII ExpressionEvaluationContext variable from Unevaluated to ConstantEvaluated when parsing a constant expression. This renaming makes it consistent

r291439 - [cxx1z-constexpr-lambda] [NFC] Add a FIXME to reinstate certain restrictions on constexpr lambdas from appearing within function-signatures (CWG1607)

Author: faisalv Date: Mon Jan 9 05:47:51 2017 New Revision: 291439 URL: http://llvm.org/viewvc/llvm-project?rev=291439=rev Log: [cxx1z-constexpr-lambda] [NFC] Add a FIXME to reinstate certain restrictions on constexpr lambdas from appearing within function-signatures (CWG1607) For further

Re: r291416 - [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions.

On Mon, Jan 9, 2017 at 12:13 AM, Richard Smith <rich...@metafoo.co.uk> wrote: > On 8 January 2017 at 19:02, Faisal Vali via cfe-commits > <cfe-commits@lists.llvm.org> wrote: >> >> Author: faisalv >> Date: Sun Jan 8 21:02:53 2017 >> New Revision: 291

r291416 - [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions.

Author: faisalv Date: Sun Jan 8 21:02:53 2017 New Revision: 291416 URL: http://llvm.org/viewvc/llvm-project?rev=291416=rev Log: [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions. Add a visitor for lambda expressions to RecordExprEvaluator in

r291397 - [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker.

Author: faisalv Date: Sun Jan 8 12:56:11 2017 New Revision: 291397 URL: http://llvm.org/viewvc/llvm-project?rev=291397=rev Log: [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker. This patch has been sitting in review

[PATCH] D22997: [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker.

faisalv updated this revision to Diff 77926. faisalv marked an inline comment as done. faisalv added a comment. Simplify the check for zero captures in a lambda expression (within the assert) by comparing the begin and end pointers directly (as opposed to using distance) - thanks to Akira!

[PATCH] D22997: [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker.

faisalv removed rL LLVM as the repository for this revision. faisalv updated this revision to Diff 77767. faisalv marked 4 inline comments as done. faisalv added a comment. Addressed Aaron's requests regarding improving formatting and assert messages. Thanks! https://reviews.llvm.org/D22997

[PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv closed this revision. faisalv added a comment. Fixed by commit: r286748 http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20161107/176865.html Thanks for the review! https://reviews.llvm.org/D23493 ___ cfe-commits mailing list

r286748 - Fix PR28366: Handle variables from enclosing local scopes more gracefully during constant expression evaluation.

Author: faisalv Date: Sun Nov 13 00:09:16 2016 New Revision: 286748 URL: http://llvm.org/viewvc/llvm-project?rev=286748=rev Log: Fix PR28366: Handle variables from enclosing local scopes more gracefully during constant expression evaluation. Only look for a variable's value in the constant

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv added a comment. Address Richard's comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:190 @@ -189,3 +189,3 @@ if (A->getCond()->isValueDependent() && !Cond->isValueDependent() && - !Expr::isPotentialConstantExprUnevaluated(Cond, cast(Tmpl), +

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv updated this revision to Diff 68644. faisalv marked 4 inline comments as done. faisalv added a comment. Address Richard's comments. https://reviews.llvm.org/D23493 Files: lib/AST/ExprConstant.cpp lib/Sema/SemaTemplateInstantiateDecl.cpp test/SemaCXX/constant-expression-cxx11.cpp

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

faisalv closed this revision. faisalv added a comment. Closed by http://llvm.org/viewvc/llvm-project?view=revision=278771 https://reviews.llvm.org/D23485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv marked an inline comment as done. faisalv added a comment. https://reviews.llvm.org/D23493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv removed rL LLVM as the repository for this revision. faisalv updated this revision to Diff 68091. faisalv added a comment. Updated the patch per Richard's direction (which helped clarify my thinking about this): Check only the current call frame - if the VarDecl is contained within the

[PATCH] D23493: Fix PR28366: Teach the const-expression evaluator to be more fault tolerant with non-const enclosing local variables, or otherwise fold them if const.

faisalv created this revision. faisalv added reviewers: rsmith, hans. faisalv added a subscriber: cfe-commits. faisalv set the repository for this revision to rL LLVM. Fix the following Bug: https://llvm.org/bugs/show_bug.cgi?id=28366 This patch teaches the constant expression evaluator to

Re: [PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

faisalv added a comment. Everything compiles - and all tests in clang/test pass. https://reviews.llvm.org/D23485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23485: [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)

faisalv created this revision. faisalv added reviewers: hans, rsmith. faisalv added a subscriber: cfe-commits. Per Richard's request here: https://llvm.org/bugs/show_bug.cgi?id=28366#c10 This patch essentially reverses all the changes from the following commit: https://reviews.llvm.org/rL264513

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

On Thu, Aug 11, 2016 at 1:07 PM, Richard Smith wrote: > Yes, this should be merged. It's not quite right, but it's certainly better > than what we had before. I would agree that the comment is broken - but, unless i'm missing something subtle, the subsequent logic and

[PATCH] D22997: [cxx1z-constexpr-lambda] Make conversion function constexpr, and teach the expression-evaluator to evaluate the static-invoker.

faisalv created this revision. faisalv added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman, erik.pilkington. faisalv added a subscriber: cfe-commits. faisalv set the repository for this revision to rL LLVM. faisalv added a project: clang-c. This patch enables the following code:

r277287 - [NFC] Rearrange an example-file so the c++14 specific example is on top.

Author: faisalv Date: Sat Jul 30 20:19:17 2016 New Revision: 277287 URL: http://llvm.org/viewvc/llvm-project?rev=277287=rev Log: [NFC] Rearrange an example-file so the c++14 specific example is on top. This makes it easier to add C++1z examples to the bottom, just before the #endif. Modified:

[PATCH] D22996: [cxx1z-constexpr-lambda] Implement constant evaluation of non-capturing lambda expressions.

faisalv created this revision. faisalv added reviewers: rsmith, hubert.reinterpretcast, aaron.ballman, erik.pilkington. faisalv added a subscriber: cfe-commits. faisalv set the repository for this revision to rL LLVM. faisalv added a project: clang-c. Add a visitor for lambda expressions to

Re: [PATCH] D22844: Tweak the diagnostic machinery to emit a NamedDecl's type, instead of empty quotes, if it represents an unnamed TypeDecl.

faisalv updated this revision to Diff 65654. faisalv added a comment. Refactored the common code from each insertion operator into a single template function called: addNameDeclOrItsTypeToDiagnostic(...). https://reviews.llvm.org/D22844 Files: include/clang/AST/Decl.h

[PATCH] D22844: Tweak the diagnostic machinery to emit a NamedDecl's type, instead of empty quotes, if it represents an unnamed TypeDecl.

faisalv created this revision. faisalv added a reviewer: rsmith. faisalv added a subscriber: cfe-commits. Currently the following code triggers diagnostics that match: auto L = []{ }; //expected-note{{'' is not literal}} constexpr int f(decltype(L)) { return 0; } //expected-error{{not a literal

Re: [PATCH] D22662: [cxx1z-constexpr-lambda] Make a lambda's closure type a literal type in C++1z.

faisalv accepted this revision. faisalv added a reviewer: faisalv. faisalv added a comment. This revision is now accepted and ready to land. Thanks Richard. Your request to separate out and centralize the diagnostic portion of the patch certainly seems like a good idea - and I shall do so

r276514 - [cxx1z-constexpr-lambda] Make a lambda's closure type eligible as a literal-type in C++1z

Author: faisalv Date: Fri Jul 22 23:05:19 2016 New Revision: 276514 URL: http://llvm.org/viewvc/llvm-project?rev=276514=rev Log: [cxx1z-constexpr-lambda] Make a lambda's closure type eligible as a literal-type in C++1z Additionally, for pre-C++1z, instead of forbidding a lambda's closure type

Re: [PATCH] D22662: [cxx1z-constexpr-lambda] Make a lambda's closure type a literal type in C++1z.

faisalv updated this revision to Diff 65026. faisalv added a comment. Factor out the diagnostic builder RAII creation (through Sema.Diag) and reduce repetition. https://reviews.llvm.org/D22662 Files: include/clang/AST/DeclCXX.h lib/Sema/SemaType.cpp

Re: [PATCH] D18510: [cxx1z-constexpr-lambda] Make conversion function constexpr

faisalv updated the summary for this revision. faisalv updated this revision to Diff 62814. faisalv added a comment. Mark the lambda's conversion to function-pointer as incontrovertibly constexpr. auto L = [](auto a) { return a; }; constexpr int* (*fp)(int*) = L; // This is now allowed. Instead

r274454 - [Refactor NFC] Rename the (non-CCE, fold-failure) Diag during constant expression evaluation as FFDiag.

Author: faisalv Date: Sat Jul 2 17:34:24 2016 New Revision: 274454 URL: http://llvm.org/viewvc/llvm-project?rev=274454=rev Log: [Refactor NFC] Rename the (non-CCE, fold-failure) Diag during constant expression evaluation as FFDiag. Currently, we have CCEDiags (C++11 core constant expression

Re: [PATCH] D20349: Fix a clang bug in lambda capture of 'this'

faisalv resigned from this revision. faisalv removed a reviewer: faisalv. faisalv added a comment. Should be fixed by: http://reviews.llvm.org/D19783. Thanks again for your feedback and all the time you put into this =) http://reviews.llvm.org/D20349

Re: [PATCH] D21030: [Sema] Fix rejects-valid where parameter pack was not expanded in type alias

faisalv added a comment. Thanks for working on this bug too! Comment at: lib/Sema/TreeTransform.h:4784 @@ +4783,3 @@ +NewType = getDerived().RebuildPackExpansionType( +NewType, SourceRange(), Loc, NumExpansions); +if (NewType.isNull())

r272631 - Fix PR28100 - Allow redeclarations of deleted explicit specializations.

Author: faisalv Date: Mon Jun 13 22:23:15 2016 New Revision: 272631 URL: http://llvm.org/viewvc/llvm-project?rev=272631=rev Log: Fix PR28100 - Allow redeclarations of deleted explicit specializations. See https://llvm.org/bugs/show_bug.cgi?id=28100. In r266561 when I implemented allowing

  1   2   >