[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. I don't have commit access. @njames93 Could you please commit it for me (`hyd-dev `)? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cf

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev updated this revision to Diff 269765. hyd-dev marked an inline comment as done. hyd-dev added a comment. Address the comment: remove `PathSize` from `BuiltinBitCastExpr`'s constructor and `assert()` it `== 0`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://rev

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev added a comment. If this is OK, please commit it with `--author "hyd-dev "`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev added a comment. **Ping?** CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. Fix typos in the summary. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev updated this revision to Diff 265436. hyd-dev added a comment. Format the test `builtin-bit-cast.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80360/new/ https://reviews.llvm.org/D80360 Files: clang/include/clang/AST/ExprCXX.h clang/include/clang/Serialization/ASTBitC

[PATCH] D80360: [PCH] Support writing BuiltinBitCastExprs to PCHs

hyd-dev created this revision. hyd-dev added reviewers: erik.pilkington, rsmith. hyd-dev added a project: clang. Herald added subscribers: cfe-commits, dexonsmith. hyd-dev edited the summary of this revision. hyd-dev edited the summary of this revision. D62825 add

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev marked 2 inline comments as done. hyd-dev added a comment. Any reply? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. In D79477#2028637 , @njames93 wrote: > What I mean to say is, if the behaviour of the testing environment changes to > pipe the result to a terminal that supports color, it could cause this test > case to also fail. The standar

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. > Would a test case be needed? `clang::tidy::clangTidyMain()` shows that clang-tidy reports all diagnostics by `clang::tidy::handleErrors()`, which constructs a `clang::tidy::(anonymous namespace)::ErrorReporter`, no matter where they come from, so I think a test case

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. > Fair point, will this option also control the color of the diagnostics > emitted by clang or just clang tidy specific diagnostics? This option sets `DiagOpts->ShowColors` to `true`. As I known, it controls **all** diagnostics reported by the `clang-tidy` program (by

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. None of the clang-tidy command line options are prefixed with `-f`. This command line option used to be `--color-diagnostics`, but I've followed @hokein's advice to change it to `--use-color`. If you mean to use the `-fcolor-diagnostics` option from `compile_commands.jso

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev updated this revision to Diff 262887. hyd-dev marked an inline comment as done. hyd-dev added a comment. Change incorrect `detect` to `detected` in the comment of `UseColor` option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ https://reviews.llvm.org/D79477 Files:

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev updated this revision to Diff 262817. hyd-dev marked an inline comment as done. hyd-dev added a comment. Say the `--use-color` command line option overrides the `UseColor` option in `.clang-tidy` file in its help text. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79477/new/ ht

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:99 IO.mapOptional("InheritParentConfig", Options.InheritParentConfig); +IO.mapOptional("UseColor", Options.UseColor); } njames93 wrote: > I'm not entirely sur

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev updated this revision to Diff 262541. hyd-dev retitled this revision from "[clang-tidy] Add --color-diagnostics command line option and ColorDiagnostics option to control colors in diagnostics" to "[clang-tidy] Add --use-color command line option and UseColor option to control colors in

[PATCH] D79477: [clang-tidy] Add --color-diagnostics command line option and ColorDiagnostics option to control colors in diagnostics

hyd-dev updated this revision to Diff 262537. hyd-dev added a comment. Rename `--color-diagnostics` and `ColorDiagnostics` to `--use-color` and `UseColor`. Also, improve the comment of `UseColor` option and the help text of `--use-color`, and add `cl::init(false)` to `cl::opt UseColor`. CHANG

[PATCH] D79477: [clang-tidy] Add --color-diagnostics option to control colors in diagnostics

hyd-dev created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. hyd-dev edited projects, added clang-tools-extra; removed clang. Herald added a project: clang. hyd-dev removed a project: clang. Herald added a project: clang. This patch add `--color-d