[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

2022-12-14 Thread tangcp via Phabricator via cfe-commits
UnionType added a comment.

@v.g.vassilev  Thanks for your reply, the patch is clean and clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127284/new/

https://reviews.llvm.org/D127284

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

2022-12-11 Thread tangcp via Phabricator via cfe-commits
UnionType added inline comments.



Comment at: clang/test/Interpreter/execute-stmts.cpp:34
+
+for (; i > 4; --i) printf("i = %d\n", i);
+// CHECK-NEXT: i = 5

It seems that top-level statements wrapped in braces cannot be handled, maybe I 
made a mistake.
```
for (; i > 4; --i) { printf("i = %d\n", i); }

{ i++; }
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127284/new/

https://reviews.llvm.org/D127284

___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits