[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto : PipelineStartEPCallbacks) +C(MPM); ychen wrote: > asbirlea wrote: > > aeubanks wrote: > > >

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto : PipelineStartEPCallbacks) +C(MPM); asbirlea wrote: > aeubanks wrote: > > ychen wrote: > > > What

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

2020-10-27 Thread Derek Schuff via Phabricator via cfe-commits
dschuff added a comment. This broke the bots for some strange reason that didn't reproduce locally. But because it was ~all of them, I probably just did something stupid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/

[clang] 44eea0b - Revert "[WebAssembly] Add support for DWARF type units"

2020-10-27 Thread Derek Schuff via cfe-commits
Author: Derek Schuff Date: 2020-10-27T17:57:32-07:00 New Revision: 44eea0b1a7301de4c284afed1c023014c391372f URL: https://github.com/llvm/llvm-project/commit/44eea0b1a7301de4c284afed1c023014c391372f DIFF: https://github.com/llvm/llvm-project/commit/44eea0b1a7301de4c284afed1c023014c391372f.diff

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-10-27 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan added a comment. I'd recommend splitting this into two patches, one for LLVM changes and another for Clang changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

2020-10-27 Thread Pengfei Wang via Phabricator via cfe-commits
pengfei added a comment. I agreed with Craig. Emitting constrained intrinsics on an unsupported target may result in problems. It's better to check if it is supported and prevent from the front end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [clang] e97e985 - [c++20] For P0732R2: permit class template argument deduction for non-type template parameters.

2020-10-27 Thread Richard Smith via cfe-commits
0. > On Wed, Oct 21, 2020 at 6:03 PM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> >> Author: Richard Smith >> Date: 2020-10-21T15:03:22-07:00 >> New Revision: e97e9851b227e98e39c27c4c8f5558e331cde8

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

2020-10-27 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 301151. tianshilei1992 added a comment. Fixed a rebase error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[clang] af2f5f9 - Remove unused variable name. NFC.

2020-10-27 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-10-27T17:48:50-07:00 New Revision: af2f5f99bd144ae2f70e21d53b23fc18a3d9d7d0 URL: https://github.com/llvm/llvm-project/commit/af2f5f99bd144ae2f70e21d53b23fc18a3d9d7d0 DIFF: https://github.com/llvm/llvm-project/commit/af2f5f99bd144ae2f70e21d53b23fc18a3d9d7d0.diff

[PATCH] D90099: [Clang][OpenMP][WIP] Added the support for target data nowait

2020-10-27 Thread Shilei Tian via Phabricator via cfe-commits
tianshilei1992 updated this revision to Diff 301150. tianshilei1992 added a comment. Rebased and fixed one test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90099/new/ https://reviews.llvm.org/D90099 Files:

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-10-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D90275#2357951 , @gulfem wrote: > In D90275#2357945 , @jdoerfert wrote: > >> In D90275#2357931 , @mcgrathr wrote: >> >>> There is an RFC going

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-10-27 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem added a comment. In D90275#2357945 , @jdoerfert wrote: > In D90275#2357931 , @mcgrathr wrote: > >> There is an RFC going out with this prototype as reference. When there is >> consensus on the RFC, this

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

2020-10-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:101 + /// Type used in the StringMap. + using MapEntry = llvm::StringMapEntry>; + thakis wrote: > thakis wrote: > > It looks like this is too clever for gcc5.3: > >

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Alina Sbirlea via Phabricator via cfe-commits
asbirlea added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto : PipelineStartEPCallbacks) +C(MPM); aeubanks wrote: > ychen wrote: > > What I have in mind is a

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-10-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D90275#2357931 , @mcgrathr wrote: > There is an RFC going out with this prototype as reference. When there is > consensus on the RFC, this will get in shape for landing with complete tests > and all. Great. I didn't find

[PATCH] D90053: Serialization: Change InputFile to use FileEntryRef and add getVirtualFileRef, NFC

2020-10-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 301148. dexonsmith edited the summary of this revision. dexonsmith added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90053/new/ https://reviews.llvm.org/D90053 Files: clang/include/clang/Basic/FileManager.h

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks marked an inline comment as done. aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1659 + bool DebugLogging) { + for (auto : PipelineStartEPCallbacks) +C(MPM); ychen wrote: >

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-10-27 Thread Wei Wang via Phabricator via cfe-commits
weiwang closed this revision. weiwang added a comment. Diff was committed, but did not close automatically. Manual close it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

2020-10-27 Thread Thomas Lively via Phabricator via cfe-commits
tlively updated this revision to Diff 301147. tlively added a comment. - Use V8 encodings: https://chromium-review.googlesource.com/c/v8/v8/+/2469156/4/src/wasm/wasm-opcodes.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90253/new/

[PATCH] D89836: Change Module::ASTFile and ModuleFile::File => Optional, NFC

2020-10-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 301146. dexonsmith retitled this revision from "Change Module::ASTFile and ModuleFile::File => MaybeFileEntryRef, NFC" to "Change Module::ASTFile and ModuleFile::File => Optional, NFC". dexonsmith edited the summary of this revision. dexonsmith added a

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-10-27 Thread Roland McGrath via Phabricator via cfe-commits
mcgrathr added a comment. There is an RFC going out with this prototype as reference. When there is consensus on the RFC, this will get in shape for landing with complete tests and all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 301145. aeubanks added a comment. run -> invoke Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-10-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. (To clarify, I am not opposing this, my comment before was brief but not meant to be negative. I'm generally for new attributes and this one is already in existing source so that is even better.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c486870 - [clang] Pass-through remarks options to linker

2020-10-27 Thread Wei Wang via cfe-commits
Author: Wei Wang Date: 2020-10-27T17:23:32-07:00 New Revision: c4868700c58078d0f4c71fab5af2bb73270d2d9f URL: https://github.com/llvm/llvm-project/commit/c4868700c58078d0f4c71fab5af2bb73270d2d9f DIFF: https://github.com/llvm/llvm-project/commit/c4868700c58078d0f4c71fab5af2bb73270d2d9f.diff

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-10-27 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Tests missing (on all levels), was there an RFC? What is the expected usage of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275

[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize Optional

2020-10-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith updated this revision to Diff 301138. dexonsmith retitled this revision from "FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef" to "FileManager: Improve the FileEntryRef API and customize Optional". dexonsmith edited the summary of this revision. dexonsmith added a

[PATCH] D90275: [clang][IR] Add support for leaf attribute

2020-10-27 Thread Gulfem Savrun Yeniceri via Phabricator via cfe-commits
gulfem created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, jdoerfert, steven_wu, hiraditya. Herald added a reviewer: aaron.ballman. Herald added projects: clang, LLVM. gulfem requested review of this revision. GCC supports __attribute__((leaf)) as an

[PATCH] D85810: [clang] Pass-through remarks options to linker

2020-10-27 Thread Wei Wang via Phabricator via cfe-commits
weiwang updated this revision to Diff 301140. weiwang added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85810/new/ https://reviews.llvm.org/D85810 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:626 + /// typically run at the very beginning. + void runRegisteredO0EPCallbacks(ModulePassManager , bool DebugLogging); + invokeO0EPCallbacks? I saw there is

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

2020-10-27 Thread Derek Schuff via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcb8a119df21: [WebAssembly] Add support for DWARF type units (authored by dschuff). Changed prior to commit:

[clang] bcb8a11 - [WebAssembly] Add support for DWARF type units

2020-10-27 Thread Derek Schuff via cfe-commits
Author: Derek Schuff Date: 2020-10-27T17:13:41-07:00 New Revision: bcb8a119df210753c5f1a3ac346d49597fef0f51 URL: https://github.com/llvm/llvm-project/commit/bcb8a119df210753c5f1a3ac346d49597fef0f51 DIFF: https://github.com/llvm/llvm-project/commit/bcb8a119df210753c5f1a3ac346d49597fef0f51.diff

[PATCH] D89971: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

2020-10-27 Thread Johannes Doerfert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1a90e1599a6: [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)` (authored by jdoerfert). Repository: rG LLVM Github Monorepo

[clang] b1a90e1 - [OpenMP][CUDA] Add missing overload for `remquo(float,float,int*)`

2020-10-27 Thread Johannes Doerfert via cfe-commits
Author: Johannes Doerfert Date: 2020-10-27T19:12:51-05:00 New Revision: b1a90e1599a65bccf9af985603e198af3876b59a URL: https://github.com/llvm/llvm-project/commit/b1a90e1599a65bccf9af985603e198af3876b59a DIFF:

[clang] 739d4bf - Unbreak build with gcc5.3 after 917acac

2020-10-27 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-10-27T20:10:48-04:00 New Revision: 739d4bf8f43d0a5a3a99e07b1647ded1ce1d81b3 URL: https://github.com/llvm/llvm-project/commit/739d4bf8f43d0a5a3a99e07b1647ded1ce1d81b3 DIFF: https://github.com/llvm/llvm-project/commit/739d4bf8f43d0a5a3a99e07b1647ded1ce1d81b3.diff

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D89158#2357850 , @ychen wrote: > IIUC, this is the NPM version of EP_EarlyAsPossible in legacy PM for O0, > right? Between the choice of (1) [this patch and ] reusing all existing EP > callbacks and letting optnone filtering

[PATCH] D88603: [WebAssembly] Add support for DWARF type units

2020-10-27 Thread Derek Schuff via Phabricator via cfe-commits
dschuff updated this revision to Diff 301133. dschuff added a comment. use GenericSectionID instead of ~0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88603/new/ https://reviews.llvm.org/D88603 Files: llvm/lib/MC/MCObjectFileInfo.cpp Index:

Re: [clang] e97e985 - [c++20] For P0732R2: permit class template argument deduction for non-type template parameters.

2020-10-27 Thread Nico Weber via cfe-commits
gcc points out that DTST is unused in +if (auto *DTST = dyn_cast(DeducedT)) { Should it be used? Or should we delete the lhs of that assignment? On Wed, Oct 21, 2020 at 6:03 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Richard Smith >

[PATCH] D89743: Support Attr in DynTypedNode and ASTMatchers.

2020-10-27 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6763 +/// (but not "nodiscard" or "clang::warn_unused_result"). +AST_MATCHER_P(Attr, hasAttrName, llvm::StringRef, Name) { + return Node.getAttrName() && Node.getAttrName()->isStr(Name);

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 301132. aeubanks added a comment. only run passes in PipelineStartEPCallbacks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89158/new/ https://reviews.llvm.org/D89158 Files:

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

2020-10-27 Thread Yuanfang Chen via Phabricator via cfe-commits
ychen added a comment. IIUC, this is the NPM version of EP_EarlyAsPossible in legacy PM for O0, right? Between the choice of (1) [this patch and ] reusing all existing EP callbacks and letting optnone filtering out non-required passes (which I think does not work for `-disable-O0-optnone`) and

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

2020-10-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:101 + /// Type used in the StringMap. + using MapEntry = llvm::StringMapEntry>; + thakis wrote: > It looks like this is too clever for gcc5.3: >

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

2020-10-27 Thread Galina Kistanova via cfe-commits
Hello Vitaly, This should be fixed. Please let me know if you still see the issue. Thanks Galina On Tue, Oct 27, 2020 at 4:45 PM Vitaly Buka wrote: > It looks fixed. I haven't seen them in recent reports. > > On Tue, 27 Oct 2020 at 16:32, Vitaly Buka wrote: > >> Any news regarding

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

2020-10-27 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90271/new/ https://reviews.llvm.org/D90271 ___

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

2020-10-27 Thread Vitaly Buka via cfe-commits
It looks fixed. I haven't seen them in recent reports. On Tue, 27 Oct 2020 at 16:32, Vitaly Buka wrote: > Any news regarding false-negatives? > > +Mitch Phillips > > On Mon, 19 Oct 2020 at 22:07, Galina Kistanova > wrote: > >> Thanks, Vitaly. >> Somebody is looking at this. >> >> >> On Mon,

[PATCH] D90109: [clang-tidy] Use ANSI escape codes for --use-color on Windows

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D90109#2356317 , @aaron.ballman wrote: > In D90109#2352180 , @dsanders11 > wrote: > >> Added a few inline comments for clarification. >> >> **Note**: I was not able to get a debug

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

2020-10-27 Thread Vitaly Buka via cfe-commits
Any news regarding false-negatives? +Mitch Phillips On Mon, 19 Oct 2020 at 22:07, Galina Kistanova wrote: > Thanks, Vitaly. > Somebody is looking at this. > > > On Mon, Oct 19, 2020 at 9:56 PM Vitaly Buka wrote: > >> it's not just staging, this build must be marked as failed >>

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

2020-10-27 Thread Nico Weber via Phabricator via cfe-commits
thakis added inline comments. Herald added a subscriber: ormris. Comment at: clang/include/clang/Basic/FileManager.h:101 + /// Type used in the StringMap. + using MapEntry = llvm::StringMapEntry>; + It looks like this is too clever for gcc5.3:

[PATCH] D90194: [Driver] differentiate -stack-protector 0 from being unspecified

2020-10-27 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. I split out the first logical change into https://reviews.llvm.org/D90271. I think I'll rework this to both be rebased, and to not add the new enum value. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D90271: [clang][ToolChains] explicitly return LangOptions::StackProtectorMode

2020-10-27 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers created this revision. nickdesaulniers added reviewers: void, rnk, phosek, srhines. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers requested review of this revision. Make the virtual method Toolchain::GetDefaultStackProtectorLevel() return

[PATCH] D90188: Add support for attribute 'using_if_exists'

2020-10-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In addition to moving the diagnostic to `DiagnoseUseOfDecl`, you may well get better error recovery if you teach `ClassifyName` about the new kind of declaration, and have it `DiagnoseUseOfDecl` it immediately and return `NameClassification::Error()` -- that way, the

[PATCH] D88239: [clang-format] Fix spaces around */& in multi-variable declarations

2020-10-27 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added a comment. Sorry for being a bit late here and thanks @klimek for bringing this to my attention. This has been years ago, but if I reconstruct my thinking (and look at the test cases), then I'd say that "left" alignment should not be applied to multi-variable decl statements

[PATCH] D90270: [clangd] Handle absolute/relative path specifications in Config

2020-10-27 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: ormris, MaskRay, ilya-biryukov. This introduces a mechanism for

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D83448#2357574 , @ahatanak wrote: > C structs with ObjC pointer fields are non-trivial when ARC is enabled since > construction, destruction, and copy are non-trivial (see > https://reviews.llvm.org/D41228). As far as I

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

2020-10-27 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. C structs with ObjC pointer fields are non-trivial when ARC is enabled since construction, destruction, and copy are non-trivial (see https://reviews.llvm.org/D41228). As far as I know, this is limited to ObjC. Repository: rG LLVM Github Monorepo CHANGES SINCE

Re: [PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

2020-10-27 Thread Sriraman Tallam via cfe-commits
On Tue, Oct 27, 2020 at 2:14 PM David Blaikie via Phabricator < revi...@reviews.llvm.org> wrote: > dblaikie added a comment. > > @tmsriram ping on the follow-up here > I checked in the patch that emits llvm instead of obj which spews garbage to the terminal as I wasn't redirecting it to

[PATCH] D89500: Fix the error message with -fbasic-block-sections=list=

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. @tmsriram ping on the follow-up here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89500/new/ https://reviews.llvm.org/D89500 ___ cfe-commits mailing list

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Idle curiosity: The patch description says "non-trivial C struct temporaries" - can C have non-trivial structs? Or is this limited to Objective C (judging/guessing by the tests)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89794: [SyntaxTree] Implement "by-pointer output parameter to return value" refactoring.

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. I imagine test coverage would be handy (I'm probably not the right reviewer for this in general, but was/am curious to see how it goes - you might want to search for other contributors/reviewers to the code you're changing and request/add them as reviewers for this

[PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations

2020-10-27 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D90244#2357130 , @aaron.ballman wrote: > Was this caused by a performance concern when profiling something? I'm not > opposed to the changes, but I do think the original formulation is easier to > read. It's not a huge

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D89893#2357480 , @Paul-C-Anagnostopoulos wrote: > I'll remember this, too. > > @dblaikie How did you happen to notice? Reading the mailing list & seeing the phab review and commit without any emails from anyone else in the

[PATCH] D90054: Added remotely ran compiler-rt tests.

2020-10-27 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90054/new/ https://reviews.llvm.org/D90054

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-27 Thread Paul C. Anagnostopoulos via Phabricator via cfe-commits
Paul-C-Anagnostopoulos added a comment. I'll remember this, too. @dblaikie How did you happen to notice? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89893/new/ https://reviews.llvm.org/D89893 ___

[PATCH] D90188: Add support for attribute 'using_if_exists'

2020-10-27 Thread Mark de Wever via Phabricator via cfe-commits
Mordante added a comment. A few questions. I'm not familiar enough with the code to accept the patch. Comment at: clang/include/clang/Basic/AttrDocs.td:5266 + let Content = [{ +The using_if_exists attribute applies to a using-declaration. It allows +programmers to import a

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

2020-10-27 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/AST/APValue.cpp:1047 + if (MergeLV(getLVForType(*TI.getType(), computation))) +break; +} else if (const Expr *E = V.getLValueBase().dyn_cast()) { I'm not sure what ABIs you're thinking about,

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

2020-10-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1866 + while(true) [[unlikely]] { +... // The attribute has no effect + } // Clang elides comparison and generates an infinite loop

[clang] 3700556 - [HIP][NFC] Use correct max in cuda_complex_builtins

2020-10-27 Thread Aaron En Ye Shi via cfe-commits
Author: Aaron En Ye Shi Date: 2020-10-27T19:35:09Z New Revision: 3700556ecb062abf786ad52a5474c27b22c19107 URL: https://github.com/llvm/llvm-project/commit/3700556ecb062abf786ad52a5474c27b22c19107 DIFF: https://github.com/llvm/llvm-project/commit/3700556ecb062abf786ad52a5474c27b22c19107.diff

[PATCH] D89899: [CodeGen] Implement [[likely]] and [[unlikely]] for the iteration statements

2020-10-27 Thread Mark de Wever via Phabricator via cfe-commits
Mordante marked 10 inline comments as done. Mordante added a comment. Thanks for the feedback. I'll update the patch after making the requested changes. Comment at: clang/include/clang/Basic/AttrDocs.td:1866 + while(true) [[unlikely]] { +... // The

[clang] e025d09 - Revert multiple patches based on "Introduce CfgTraits abstraction"

2020-10-27 Thread Nicolai Hähnle via cfe-commits
Author: Nicolai Hähnle Date: 2020-10-27T20:33:30+01:00 New Revision: e025d09b216dc2239e1b502f4f277abb6fb4648a URL: https://github.com/llvm/llvm-project/commit/e025d09b216dc2239e1b502f4f277abb6fb4648a DIFF:

[PATCH] D90188: Add support for attribute 'using_if_exists'

2020-10-27 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added inline comments. Comment at: clang/test/SemaCXX/using-if-exists-attr.cpp:16 +template +using template_alias UIE = NS::x; // expected-warning {{'using_if_exists' attribute only applies to named declarations, types, and value declarations}} +

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

2020-10-27 Thread Amy Huang via Phabricator via cfe-commits
akhuang updated this revision to Diff 301080. akhuang added a comment. Herald added a subscriber: jfb. Moved isUnsignedDIType to DebugHandlerBase to avoid copying it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89072/new/

[PATCH] D89072: [CodeView] Emit static data members as S_CONSTANTs.

2020-10-27 Thread Amy Huang via Phabricator via cfe-commits
akhuang reopened this revision. akhuang added a comment. This revision is now accepted and ready to land. Reverted because my copied `isUnsignedDIType` function had problems (guess I copied it at first but then was messing with the code); I moved it to DebugHandlerBase.h so it doesn't need to

[PATCH] D90188: Add support for attribute 'using_if_exists'

2020-10-27 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added inline comments. Comment at: clang/test/SemaCXX/using-if-exists-attr.cpp:16 +template +using template_alias UIE = NS::x; // expected-warning {{'using_if_exists' attribute only applies to named declarations, types, and value declarations}} + I

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-27 Thread Chris Lattner via Phabricator via cfe-commits
lattner added a comment. Oops, thanks for the head's up @dblaikie ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89893/new/ https://reviews.llvm.org/D89893 ___ cfe-commits mailing list

[clang] 917acac - FileManager: Shrink FileEntryRef to the size of a pointer

2020-10-27 Thread Duncan P . N . Exon Smith via cfe-commits
Author: Duncan P. N. Exon Smith Date: 2020-10-27T14:55:41-04:00 New Revision: 917acac960d40280ea02ea453e594034b1be1f6b URL: https://github.com/llvm/llvm-project/commit/917acac960d40280ea02ea453e594034b1be1f6b DIFF:

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

2020-10-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. dexonsmith marked 2 inline comments as done. Closed by commit rG917acac960d4: FileManager: Shrink FileEntryRef to the size of a pointer (authored by dexonsmith). Herald added a project: clang. Changed prior to commit:

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling supportfor non-type template parameters of class type and template parameter objects.

2020-10-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:657-660 // ::= $1? // ::= $H? // ::= $I? // ::= $J? For what it's worth, I'm fairly

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

2020-10-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D90180#2357178 , @trixirt wrote: > Discussion of change on LKML > https://lkml.org/lkml/2020/10/27/2538 > > On why the existing clang fixit is not practical. > tl;dr > 10,000 changes to look for a treewide fix > The

[PATCH] D89893: [Clang] [TableGen] Clean up !if(!eq(boolean, 1) and related booleans

2020-10-27 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added subscribers: mehdi_amini, dblaikie. dblaikie added a comment. @lattner minor detail/annoyance: Phabricator doesn't email the mailing lists if a review is "approved" with no comments. To ensure the approval is recorded on the list, please include some text (a stub "." would

[PATCH] D89998: [c++20] For P0732R2 / P1907R1: Basic code generation and name mangling support for non-type template parameters of class type and template parameter objects.

2020-10-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith updated this revision to Diff 301070. rsmith added a comment. - Ignore cv-qualifiers in member types for Itanium mangling. - Add MSVC-compatible mangling support. - Fix bug where template argument value mangling would be used when passing a template parameter object as a pointer or

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

2020-10-27 Thread Hiral via Phabricator via cfe-commits
Hiralo added a comment. In D89936#2357088 , @njames93 wrote: > If you plan on contributing quite a lot then it would be wise to upload your > patches with arcanist - https://llvm.org/docs/Phabricator.html. It will help > prevent issues with diffs being

[clang] 5046153 - Revert "[CodeView] Emit static data members as S_CONSTANTs."

2020-10-27 Thread Amy Huang via cfe-commits
Author: Amy Huang Date: 2020-10-27T11:29:58-07:00 New Revision: 504615353f31136dd6bf7a971b6c236fd70582be URL: https://github.com/llvm/llvm-project/commit/504615353f31136dd6bf7a971b6c236fd70582be DIFF: https://github.com/llvm/llvm-project/commit/504615353f31136dd6bf7a971b6c236fd70582be.diff

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

2020-10-27 Thread Hiral via Phabricator via cfe-commits
Hiralo marked 4 inline comments as done. Hiralo added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:290 DefaultOptions.Checks = DefaultChecks; + DefaultOptions.ConfigFile = ""; DefaultOptions.WarningsAsErrors = "";

[PATCH] D89980: [hip] Remove kernel argument coercion.

2020-10-27 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. Besides the unpromotable `alloca` issue due to indirect accesses, such coercion to GLOBAL pointer directly is not safe as, in HIP/CUDA, both CONSTANT and GLOBAL pointers would be passed as the kernel arguments. Without introducing a new address space combing

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

2020-10-27 Thread Hiral via Phabricator via cfe-commits
Hiralo updated this revision to Diff 301065. Hiralo added a comment. Latest patch with Lit test-case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89936/new/ https://reviews.llvm.org/D89936 Files: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

2020-10-27 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski updated this revision to Diff 301066. awarzynski added a comment. Rebase on top of master + rename accessor method Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88381/new/ https://reviews.llvm.org/D88381 Files:

[PATCH] D90174: [HIP] Fix regressions due to fp contract change

2020-10-27 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:486 + if (LangOpts.HIP) +Options.AllowFPOpFusion = llvm::FPOpFusion::Standard; + tra wrote: > yaxunl wrote: > > tra wrote: > > > yaxunl wrote: > > > > tra wrote: > > > > > I don't

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

2020-10-27 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. In D90180#2357178 , @trixirt wrote: > Discussion of change on LKML > https://lkml.org/lkml/2020/10/27/2538 > > On why the existing clang fixit is not practical. > tl;dr > 10,000 changes to look for a treewide fix > The

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

2020-10-27 Thread Tom Rix via Phabricator via cfe-commits
trixirt added a comment. Discussion of change on LKML https://lkml.org/lkml/2020/10/27/2538 On why the existing clang fixit is not practical. tl;dr 10,000 changes to look for a treewide fix The fixit has whitespace issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D39086: Performance tracing facility for clangd.

2020-10-27 Thread Simon Pilgrim via Phabricator via cfe-commits
RKSimon added inline comments. Herald added subscribers: usaxena95, kadircet, arphaman, MaskRay. Comment at: clang-tools-extra/trunk/unittests/clangd/TraceTests.cpp:57 +} +std::string VS = V->getValue(Tmp).str(); +if (VS != I->second) { @sammccall

[PATCH] D89980: [hip] Remove kernel argument coercion.

2020-10-27 Thread Michael Liao via Phabricator via cfe-commits
hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:19 +// COMMON-LABEL: define amdgpu_kernel void @_Z7kernel1Pi(i32*{{.*}} %x) +// OPT: [[VAL:%.*]] = load i32, i32* %x, align 4 // OPT: [[INC:%.*]] = add nsw i32 [[VAL]], 1

[PATCH] D90244: [clang-tidy][NFC] IdentifierNaming: Remove unnecessary string allocations

2020-10-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Was this caused by a performance concern when profiling something? I'm not opposed to the changes, but I do think the original formulation is easier to read. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90244/new/

[PATCH] D90180: [clang-tidy] find/fix unneeded semicolon after switch

2020-10-27 Thread Tom Rix via Phabricator via cfe-commits
trixirt updated this revision to Diff 301059. trixirt added a comment. fix precheckin lint issues with auto vs const auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90180/new/ https://reviews.llvm.org/D90180 Files:

[PATCH] D88381: [Flang][Driver] Add PrintPreprocessed FrontendAction

2020-10-27 Thread sameeran joshi via Phabricator via cfe-commits
sameeranjoshi added a comment. Looks good, I would wait for a couple of more days for someone to review from community may be from Nvidia's side if someone would verify the initial design. Thank you. Comment at: flang/include/flang/Frontend/CompilerInvocation.h:12 #include

[PATCH] D89834: FileManager: Improve the FileEntryRef API and add MaybeFileEntryRef

2020-10-27 Thread Duncan P. N. Exon Smith via Phabricator via cfe-commits
dexonsmith added a comment. In D89834#2356769 , @arphaman wrote: > What's wrong with using `Optional` instead of > `MaybeFileEntryRef`? Two problems: 1. `const FileEntry*` is stored in lots of places. I am nervous after the memory regression from

[PATCH] D90251: [AMDGPU] Add __builtin_amdgcn_grid_size

2020-10-27 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I think there is value in this change. It may help simplify device library and hide some compiler details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90251/new/ https://reviews.llvm.org/D90251

[PATCH] D87528: Enable '#pragma STDC FENV_ACCESS' in frontend

2020-10-27 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D87528#2357043 , @mibintc wrote: > Actually kludging it by just removing the assert isn't going to work. I'll > ping Pengfei to see about developing a patch for this problem. This is likely a WebAssembly backend problem.

[PATCH] D89936: [clang-tidy] adding "--clang-tidy-config=" to specify custom config file

2020-10-27 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. If you plan on contributing quite a lot then it would be wise to upload your patches with arcanist - https://llvm.org/docs/Phabricator.html. It will help prevent issues with diffs being relative to previous revisions. Personally I just create a branch from master for a

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

2020-10-27 Thread Thomas Lively via Phabricator via cfe-commits
tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. tlively requested review of this revision. As proposed in

[PATCH] D90042: [clang-tidy] performance-unnecessary-copy-initialization: Check for const reference arguments that are replaced template parameter type.

2020-10-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D90042#2356265 , @flx wrote: > In D90042#2356180 , @aaron.ballman > wrote: > >> In D90042#2350035 , @flx wrote: >> >>> I should note that

[PATCH] D90221: Include attribute details when dumping AST in JSON

2020-10-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D90221#2356110 , @aronsky wrote: > In D90221#2356062 , @lebedev.ri > wrote: > >> Are there tests missing? > > Quite possible. I followed the trail of the existing functions to

  1   2   3   4   5   6   7   8   9   10   >