This revision was automatically updated to reflect the committed changes.
Closed by commit rG73733ae526a5: TypeInfo records more information about align
requirement (authored by stevewan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108858/new/
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108858/new/
https://reviews.llvm.org/D108858
stevewan updated this revision to Diff 369258.
stevewan added a comment.
Add RequiredByEnum case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108858/new/
https://reviews.llvm.org/D108858
Files:
clang/include/clang/AST/ASTContext.h
rjmccall added a comment.
Thanks. Generally looks good; feel free to commit after adding a
`RequiredByEnum` case and making sure it compiles.
Comment at: clang/lib/AST/ASTContext.cpp:2300
Info.Align = AttrAlign;
-Info.AlignIsRequired = true;
+
stevewan updated this revision to Diff 369240.
stevewan added a comment.
Fix enum usage
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108858/new/
https://reviews.llvm.org/D108858
Files:
clang/include/clang/AST/ASTContext.h
stevewan updated this revision to Diff 369235.
stevewan added a comment.
Oops missed one flag.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108858/new/
https://reviews.llvm.org/D108858
Files:
clang/include/clang/AST/ASTContext.h
stevewan created this revision.
stevewan requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Extend the information preserved in `TypeInfo` by replacing the
`AlignIsRequired` bool flag with a three-valued enum, the enum also
indicates where
