[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5da7f30f24c4: [AIX][Clang][K] Create `-K` Option for AIX. (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 520502. francii added a comment. Remove leftover marker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, with minor fixup as noted Comment at: clang/test/Driver/aix-ld.c:1123 +// CHECK-K-UNUSED: clang: warning: -K: 'linker' input unused

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 520455. francii added a comment. Don't claim `-k` when checking target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6331 + if (Arg *A = Args.getLastArg(options::OPT_K); A && !TC.getTriple().isOSAIX()) +D.Diag(diag::err_drv_unsupported_opt_for_target) Let's not claim here, just in case

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 511431. francii added a comment. Add unsupported target test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 511208. francii added a comment. Add -c test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

hubert.reinterpretcast added a comment. In D146399#4244479 , @francii wrote: > Do we need a test case for the diagnostic? If we are only supporting one > target, which triple would be used for the test? I think we do need a test case for the

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii added a comment. In D146399#4243803 , @hubert.reinterpretcast wrote: > @francii, what happens when `-K` is used on a pure-compile (`-c`) invocation? > Do we get an "unused" message? Should we be testing that? > I think we should be testing the

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

hubert.reinterpretcast added a comment. @francii, what happens when `-K` is used on a pure-compile (`-c`) invocation? Do we get an "unused" message? Should we be testing that? I think we should be testing the diagnostic for the "wrong target" usage as well? Repository: rG LLVM Github

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 508709. francii added a comment. Remove `NoArgumentUnused`, claim -K when checking target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files:

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506580. francii added a comment. Clean up test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506575. francii added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii updated this revision to Diff 506447. francii added a comment. nit: spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146399/new/ https://reviews.llvm.org/D146399 Files: clang/include/clang/Driver/Options.td

[PATCH] D146399: [AIX][Clang][K] Create `-K` Option for AIX.

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. `-K` is a linker option on AIX, that is used to align the header, text, data, and loader sections of the output